18069 Commits

Author SHA1 Message Date
Tobias Brunner
db139a02cb ikev2: Send deletes also for rekeyed SAs
This way we can use the IKE_REKEYED state for both redundant and old SAs
to suppress ike_updown().

In the ike-delete task we don't suppress events in state IKE_REKEYING as
that's the case when we delete an SA the peer is currently rekeying with
multiple key exchanges.
2021-10-18 18:49:12 +02:00
Tobias Brunner
3baf713767 ikev2: Let ike/child-rekey tasks indicate if the passive task was adopted
This gives us more flexibility with tasks that return NEED_MORE (currently
none of the colliding tasks do, but that will change with multi-KE
rekeyings).  The active task has to check itself if the passive task is
done and should be removed from the task manager.
2021-10-18 18:49:12 +02:00
Tobias Brunner
5673eb57d0 ike-rekey: Remove collision task type checks
Since f67199378df9 ("ike-rekey: Handle undetected collisions also if
delete is delayed") we only ever track tasks of type TASK_IKE_REKEY, so
there is no need to check the type or use the generic task_t interface.

Also changed some of the comments to clarify collision handling.
2021-10-18 18:49:12 +02:00
Tobias Brunner
6c739d8bb7 ike-rekey: Don't actively rekey already rekeyed SAs
If the peer successfully rekeyed the SA it gets marked as IKE_REKEYED
and it remains until the peer deletes it (or a timeout).  There is no
point in rekeying such SAs again.

IKE_REKEYING will be relevant if we have multi-KE rekeyings and are
waiting for followup key exchanges for a passive rekeying.
2021-10-18 18:49:12 +02:00
Tobias Brunner
4afd6d1726 ike-init: Ignore COOKIE payloads during rekeying
This ensures that process_i() only returns NEED_MORE due to multiple
key exchanges or an INVALID_KE_PAYLOAD notify.
2021-10-18 18:49:12 +02:00
Tobias Brunner
8378077602 ike-init: Add support for multiple key exchanges
Initially, this is handled with a key derivation for each
IKE_INTERMEDIATE exchange.  When rekeying the keys are derived only when
all IKE_FOLLOWUP_KE exchanges are done.
2021-10-18 18:49:12 +02:00
Tobias Brunner
e6535ecb03 bus: Support multiple key exchanges in ike/child_keys() events 2021-10-18 18:49:12 +02:00
Tobias Brunner
36d101f7e6 keymat_v2: Support key derivation with multiple key exchanges 2021-10-18 18:49:12 +02:00
Tobias Brunner
d9d0864349 key-exchange: Add helper to concatenate shared secrets of several key exchanges 2021-10-18 18:49:12 +02:00
Tobias Brunner
dcd5c945b5 keymat_v2: Proper cleanup if derive_ike_keys() is called multiple times 2021-10-18 18:49:12 +02:00
Tobias Brunner
5727ab2390 ike-sa-manager: Log SPIs when checking in an IKE_SA 2021-10-18 18:49:12 +02:00
Tobias Brunner
c52413e71e ikev2: Use hashes to detect retransmits
We avoid parsing messages with unexpected message IDs.  This allows us to
process and detect retransmits of messages for which we don't have the keys
anymore (i.e. IKE_INTERMEDIATE after IKE_SA_INIT and changing the keys).

This also changes how retransmits for fragmented messages are triggered,
previously we waited for all fragments and reconstructed the message
before retransmitting the response.  Now we only track the first
fragment and if we receive a retransmit of it respond immediately
without waiting for other fragments (which are now ignored).  This is in
compliance with RFC 7383, section 2.6.1.
2021-10-18 18:49:12 +02:00
Tobias Brunner
778f4e81cf ike-auth: Calculate and collect IntAuth for IKE_INTERMEDIATE exchanges 2021-10-18 18:49:12 +02:00
Tobias Brunner
58106bc07f pubkey-authenticator: Handle IntAuth data 2021-10-18 18:49:12 +02:00
Tobias Brunner
ddb77b9f75 psk-authenticator: Handle IntAuth data 2021-10-18 18:49:11 +02:00
Tobias Brunner
d82bd5e4fb eap-authenticator: Handle IntAuth data 2021-10-18 18:49:11 +02:00
Tobias Brunner
2ff825383c keymat_v2: Include optional IntAuth in signed octets 2021-10-18 18:49:11 +02:00
Tobias Brunner
e0dba02f88 authenticator: Add optional method to set IntAuth data 2021-10-18 18:49:11 +02:00
Tobias Brunner
5383899eb1 message: Add method to generate data to authenticate IKE_INTERMEDIATE exchanges 2021-10-18 18:49:11 +02:00
Tobias Brunner
16b6ae54d1 generator: Make pointer to length field optional
Only useful if we generate an IKE header.
2021-10-18 18:49:11 +02:00
Tobias Brunner
403977a521 message: Fix payload type in last unprotected payload of a fragmented message 2021-10-18 18:49:11 +02:00
Tobias Brunner
9708b2382d keymat_v2: Add method to calculate IntAuth for IKE_INTERMEDIATE exchanges 2021-10-18 18:49:11 +02:00
Tobias Brunner
8c7eee457e ike-rekey: Reset IKE_SA after processing CREATE_CHILD_SA request
This probably didn't cause any problems, as there wasn't really anything
happening between the calls, but reset it anyway, just to be safe.
2021-10-18 18:49:11 +02:00
Tobias Brunner
5a806b9b18 ikev2: Allow tasks to do work after processing requests/responses 2021-10-18 18:49:11 +02:00
Tobias Brunner
c9eb8a4498 task: Add optional post_process() method
This will allows tasks to do some work after a message has been
processed.
2021-10-18 18:49:11 +02:00
Tobias Brunner
6f847786cc ikev2: Allow tasks to do work after generating requests/responses 2021-10-18 18:49:11 +02:00
Tobias Brunner
5c0d987ce9 task: Add optional post_build() method
This will allow tasks to do some work after the message has been
generated.
2021-10-18 18:49:11 +02:00
Tobias Brunner
f5eef00302 ike-auth: Support IKE_INTERMEDIATE exchange between IKE_SA_INIT and IKE_AUTH 2021-10-18 18:49:11 +02:00
Tobias Brunner
0c2080ba02 child-create: Support IKE_INTERMEDIATE exchange between IKE_SA_INIT and IKE_AUTH 2021-10-18 18:49:11 +02:00
Tobias Brunner
78927145fe ike-mobike: Support IKE_INTERMEDIATE exchange between IKE_SA_INIT and IKE_AUTH
This changes the MID of the first IKE_AUTH message.
2021-10-18 18:49:11 +02:00
Tobias Brunner
9f1497d41c ike-config: Support IKE_INTERMEDIATE exchange between IKE_SA_INIT and IKE_AUTH
This changes the MID of the first IKE_AUTH message.
2021-10-18 18:49:11 +02:00
Tobias Brunner
b979511fcb ike-cert-post: Make absolutely sure certificates are only added to IKE_AUTH
The AUTH payload check should be fine, but add some extra checks just to make
really sure and also for clarification.
2021-10-18 18:49:11 +02:00
Tobias Brunner
3234407a95 ike-cert-pre: Support IKE_INTERMEDIATE exchange between IKE_SA_INIT and IKE_AUTH
The first IKE_AUTH does not have MID 1 if that's the case.
2021-10-18 18:49:11 +02:00
Tobias Brunner
004f440f54 status: Add return_need_more() utility function 2021-10-18 18:49:11 +02:00
Tobias Brunner
ec12550000 message: Add rules for IKE_FOLLOWUP_KE exchanges 2021-10-18 18:49:11 +02:00
Tobias Brunner
ef3b6bd45e wip: ike-header: Add IKE_FOLLOWUP_KE exchange type 2021-10-18 18:49:11 +02:00
Tobias Brunner
ba4b27af8b message: Add rules for IKE_INTERMEDIATE exchanges 2021-10-18 18:49:11 +02:00
Tobias Brunner
082a688efd wip: ike-header: Add IKE_INTERMEDIATE exchange type 2021-10-18 18:49:11 +02:00
Tobias Brunner
6b176421b1 wip: notify-payload: Add notify types for multiple key exchanges 2021-10-18 18:49:11 +02:00
Tobias Brunner
d25198a1dd wip: notify-payload: Add notify type for IKE_INTERMEDIATE exchange 2021-10-18 18:49:11 +02:00
Tobias Brunner
d65ae2952a proposal-substructure: Encode additional key exchange methods 2021-10-18 18:49:11 +02:00
Tobias Brunner
8b1a0ba16a child-cfg: Add method to check if an algorithm is proposed 2021-10-18 18:49:11 +02:00
Tobias Brunner
a0356e1861 child-cfg: Generalize get_ke_method() method 2021-10-18 18:49:11 +02:00
Tobias Brunner
da9bedd021 ike-cfg: Generalize get_ke_method() method 2021-10-18 18:49:11 +02:00
Tobias Brunner
f5b7f34876 proposal: Generalize KE methods 2021-10-18 18:49:11 +02:00
Tobias Brunner
1944dbf80d proposal: Make all key exchange transforms optional in ESP/AH proposals 2021-10-18 18:49:11 +02:00
Tobias Brunner
204715d4a3 proposal: Skip all KE transforms if PROPOSAL_SKIP_KE given 2021-10-18 18:49:11 +02:00
Tobias Brunner
c5902bb02e transform: Add helper to check if transform type negotiates key exchange 2021-10-18 18:49:11 +02:00
Tobias Brunner
504a266700 transform: Add additional key exchange transform types 2021-10-18 18:49:11 +02:00
Andreas Steffen
d8d08169bd Rename MODP_NONE to KE_NONE 2021-10-18 18:49:11 +02:00