1355 Commits

Author SHA1 Message Date
Mattia
14b596fd30 Support standalone adapters (#941)
* Expose relevant specs to external adapters
2019-03-10 11:02:19 +01:00
Geoff Hubbard
6ff61c0ecc chore: RuboCop lint Style/Globalvars (#943) 2019-03-09 13:23:48 +00:00
Olle Jonsson
c8c9a0217c README: Add CircleCI badge (#940) 2019-03-09 10:21:56 +00:00
Olle Jonsson
0a47c7b115
CI: CircleCI configuration (#935)
* CI: CircleCI example

* README: Drop Travis CI badge

* NetHttp adapter: include EADDRNOTAVAIL, too

  - this is about connections failing in JRuby tests

* HttpClient adapter: add EADDRNOTAVAIL failing in JRuby tests

* CI: deploy on Git tags

* CI: Try adding JRuby 9.2

* CI: add JRUBY_OPTS=--debug

* CI: Add RspecJunitFormatter

* CI: Identify Test Results via directory names

* CI: Use valid config YAML

* CI: Call rspec CLI

* CI: YAML alias to share steps

* CI: Drop Travis configuration file
2019-03-08 20:03:42 +01:00
Olle Jonsson
a1f698ef44 CI: Drop Travis configuration file 2019-03-08 19:35:38 +01:00
Olle Jonsson
c5632466d9 CI: Avoid bad cache 2019-03-08 19:34:49 +01:00
Olle Jonsson
752b67cad4 CI: YAML alias to share steps 2019-03-08 19:32:54 +01:00
Olle Jonsson
e955e55cb7 CI: Call rspec CLI
- Rakefile: remove CI-specific detail
2019-03-08 19:25:05 +01:00
Olle Jonsson
94a26eb1a8
Merge branch 'master' into use-circleci 2019-03-08 18:46:32 +01:00
risk danger olson
bd322bba6b chore: rubocop lint Metrics/LineLength (#938) 2019-03-08 17:45:12 +00:00
Mattia
4102f3add4
Removes legacy tests as replaced by RSpec (#939) 2019-03-08 11:00:56 +00:00
Mattia
626d68f6ff
Adds rack adapter to RSpec tests (#937) 2019-03-07 23:18:29 +00:00
Olle Jonsson
82c82a9a8f CI: disable JRuby 2019-03-07 22:47:01 +01:00
risk danger olson
c58723d028
Merge pull request #933 from lostisland/rubocop-style-classvars
Rubocop: style/classvars
2019-03-07 10:47:38 -07:00
rick olson
490ee83ddf Merge branch 'master' into rubocop-style-classvars 2019-03-07 10:37:20 -07:00
rick olson
4d88475295 remove #constantize use and unnecessary nil checks 2019-03-07 10:28:55 -07:00
Mattia
609d1768cb
Adds em-synchrony adapter to RSpec tests (#936) 2019-03-07 13:23:41 +00:00
Olle Jonsson
385203be78 CI: Use valid config YAML 2019-03-06 22:04:48 +01:00
Olle Jonsson
780222e1ec CI: Identify Test Results via directory names 2019-03-06 22:02:14 +01:00
Olle Jonsson
e84d1653b7 Linting 2019-03-06 21:57:08 +01:00
Olle Jonsson
5b97393d2b CI: Add RspecJunitFormatter to RSpec rake task 2019-03-06 21:56:14 +01:00
Olle Jonsson
96047c855b CI: add JRUBY_OPTS=--debug 2019-03-06 21:04:14 +01:00
Olle Jonsson
0d3e566f68 CI: Try adding JRuby 9.2 2019-03-06 21:00:38 +01:00
Olle Jonsson
ea1142a4a2 CI: deploy on Git tags 2019-03-06 20:52:30 +01:00
Olle Jonsson
338de4d938 HttpClient adapter: add EADDRNOTAVAIL 2019-03-06 19:53:20 +01:00
Olle Jonsson
148b99ee0f NetHttp adapter: include EADDRNOTAVAIL, too
- this is about connections failing, an experiment
2019-03-06 19:50:23 +01:00
rick olson
726de4a186 use a descriptive variable name 2019-03-06 11:23:52 -07:00
Olle Jonsson
2730f1247a README: Drop Travis CI badge 2019-03-06 18:22:20 +01:00
Olle Jonsson
f6e8d7ad58 CI: CircleCI example 2019-03-06 18:14:58 +01:00
rick olson
907c5190b1 add AdapterRegistry spec 2019-03-06 10:14:10 -07:00
rick olson
73747c66b7 Merge branch 'master' into rubocop-style-classvars 2019-03-06 09:30:09 -07:00
risk danger olson
c801391d18
Merge pull request #932 from lostisland/em-http-tests
Adds em-http adapter to RSpec tests
2019-03-06 09:29:15 -07:00
Sergey Prikhodko
1d3d675821 Add the log formatter that is easy to override and safe to inherit (#889) 2019-03-06 16:13:14 +00:00
iMacTia
04dff67cfa Fixes an issue with macOS require order. 2019-03-06 09:20:47 +00:00
iMacTia
28e995d9c6 Merge branch 'master' of https://github.com/lostisland/faraday into em-http-tests
# Conflicts:
#	spec/spec_helper.rb
2019-03-06 08:53:40 +00:00
Geoff Hubbard
b9ea1d92ce Accurate test code coverage percentage (#934) 2019-03-06 08:46:51 +00:00
rick olson
00cbb94f3d chore: update rubocop_todo 2019-03-05 11:38:44 -07:00
rick olson
5f276b36fa replace @@classvars with AdapterRegistry usage 2019-03-05 11:38:24 -07:00
rick olson
dcb7030289 always require 'monitor' since it's used by AdapterRegistry too. 2019-03-05 11:38:07 -07:00
rick olson
e8382421aa reimplement const-lookup from Faraday::RackBuilder::Handler 2019-03-05 11:37:42 -07:00
rick olson
04b90eb43e chore: replace class vars with class instance var
probably unnecessary since the integration test suite is going away
2019-03-05 11:33:15 -07:00
iMacTia
ab33c8ace1 Adds em-http adapter to RSpec tests 2019-03-05 18:26:46 +00:00
Mattia
ded4f6ef9a
Fixes Rubocop Style/GuardClause (#931) 2019-03-05 12:25:15 +00:00
Geoff Hubbard
e342992751 chore: Rubocop lint Style/MissingRespondToMissing (#930) 2019-03-04 23:25:25 +01:00
Geoff Hubbard
dbba0734d6 Fix test order dependency in default_connection proxy test (#929)
* Fix the default_connection proxy test

The assignment to the mock connection:

`Faraday.default_connection = mock_connection`

was persisting throughout the tests.

If the random number generator is unlucky the following error occurs:

\#<Double "Connection"> was originally created in one example but has leaked into another example and can no longer be used.  rspec-mocks' doubles are designed to only last for one example, and you need to create a new one in each example you wish to use it for.

This commit fixes the issue by explicitly setting the default_connection
back to nil in an "after" block after the tests have run.

Subsequent calls to `default_connection` within the test suite then
behave as previously expected irrespective of the random test ordering.
2019-03-04 23:16:10 +01:00
Geoff Hubbard
c5ceb2679c chore: RuboCop lint Style/MethodMissingSuper (#928) 2019-03-04 21:07:33 +00:00
Mattia
6b0eb71322
chore: RuboCop lint Metrics/BlockLength (#927) 2019-03-04 21:02:46 +00:00
Mattia
ef4044281d chore: RuboCop lint Style/IfUnlessModifier (#926)
* Fixes Rubocop Style/IfUnlessModifier

* Update lib/faraday/adapter/httpclient.rb

Co-Authored-By: iMacTia <iMacTia@users.noreply.github.com>

* Update lib/faraday/request/retry.rb

Co-Authored-By: iMacTia <iMacTia@users.noreply.github.com>
2019-03-04 14:49:25 +01:00
Olle Jonsson
8ba22d5da2
Merge pull request #925 from lostisland/fix/rubocop-style-m
chore: RuboCop lint Style/M*
2019-03-04 14:23:41 +01:00
iMacTia
2a04aeadb3 Fixes Rubocop Style/ModuleFunction 2019-03-04 13:01:46 +00:00