41573 Commits

Author SHA1 Message Date
Nyall Dawson
851c081105 Remove use of deprecated header 2017-09-11 17:10:31 +10:00
Nyall Dawson
c78ca050c0 Ignore =default during doxygen coverage test 2017-09-11 17:10:31 +10:00
Nyall Dawson
07e12e2832 Replace reimplemented default methods by = default
Using clang-tidy modernize-use-equals-default
2017-09-11 17:10:31 +10:00
Nyall Dawson
ba64e3e533 Remove redundant initializations
Fixes when a member is initialized both in the header and
source to the same initial value

(via clang-tidy modernize-use-default-member-init fixit)
2017-09-11 17:09:35 +10:00
Alessandro Pasotti
32dee4480c Merge pull request #5156 from boundlessgeo/gpkg_tab
[feature][needs-docs] Gpkg tab in source select dialog
2017-09-11 08:15:55 +02:00
Nyall Dawson
a650681061 Merge pull request #5131 from nyalldawson/location_algs
Rework Select by Location algorithm
2017-09-11 15:50:43 +10:00
Nyall Dawson
7f5bd00cbf Merge pull request #5154 from nyalldawson/stats
[processing] Improve Stats by Categories algorithm, remove duplicate algs
2017-09-11 15:50:16 +10:00
Nyall Dawson
cf8afc1e5b Merge pull request #5159 from alexbruy/fix-filter
[processing] fix file filter construction for output files
2017-09-11 11:37:59 +10:00
Martin Dobias
8aeffdb457 Reduce debugging noise when using curved geometries 2017-09-10 18:52:07 +02:00
Martin Dobias
1b588c85df Merge pull request #5148 from wonder-sk/adv-digitizing-cleanup-2
Advanced digitizing cleanup - part 2
2017-09-10 18:45:38 +02:00
Martin Dobias
f938b60f12 Handle mouse events of adv.digitizing map tools in the map tool base class 2017-09-10 16:34:13 +02:00
Martin Dobias
ae713b4c81 Move snapSegment() from map mouse event to private area of CAD dock 2017-09-10 16:34:13 +02:00
Martin Dobias
22ad67295b More advanced digitizing dock widget cleanups
- CaptureMode enum has been moved back to QgsMapToolCapture where it belongs
- map tools that need clearing of CAD points do so explicitly when needed
2017-09-10 16:34:13 +02:00
Martin Dobias
2f8afc02ab Remove some workarounds for advanced digitizing from node tool 2017-09-10 16:34:13 +02:00
Martin Dobias
a2b2567ca3 Better control of CAD dock widget operation from map tools 2017-09-10 16:33:02 +02:00
Nyall Dawson
02e8f1e6fa Fix tests 2017-09-10 14:07:52 +10:00
Nyall Dawson
cea7eb8be5 Merge pull request #5119 from nyalldawson/layout_next3
[layouts] Undo/redo framework
2017-09-10 11:38:59 +10:00
Nyall Dawson
2a88a5a953 Optimise calcuation of disjoint features 2017-09-10 10:59:33 +10:00
Nyall Dawson
6d94e6fc5c Optimise Extract/Select by Location alg
Only create and prepare the GEOS representation for intersection
layer features when we encounter a feature in the target layer
within that feature's bounding box.
2017-09-10 10:54:27 +10:00
Nyall Dawson
6a760ef3df More tests for Extract by Location 2017-09-10 10:50:55 +10:00
Nyall Dawson
e0026609bb Fix missing geometries/attributes in Extract by Location 2017-09-10 10:45:34 +10:00
Alessandro Pasotti
c733b366f1 Use auto for const complex vars in for loop 2017-09-09 12:07:05 +02:00
Alessandro Pasotti
9d7273dadc More Q_FOREACH removal 2017-09-08 22:13:52 +02:00
Martin Dobias
1caaa2e697 Range for loop without detach 2017-09-08 15:12:50 +02:00
Martin Dobias
d568ce336e Replace Q_FOREACH by range for loop 2017-09-08 15:12:50 +02:00
Martin Dobias
31b6b5885f Node tool: give priority to the current layer when selecting vertex 2017-09-08 15:12:50 +02:00
Alessandro Pasotti
8abf6dc43e Update tests for OGR getLayers now returning also the geometry column name 2017-09-08 12:36:42 +02:00
Nyall Dawson
640a27b4ea Drop python Select/Extract by Location algs 2017-09-08 20:34:52 +10:00
Nyall Dawson
f4b9bbd8ab Swap unit tests to use native algorithms 2017-09-08 20:32:12 +10:00
Nyall Dawson
cecdf33614 Native c++ Extract by Location algorithm 2017-09-08 20:20:49 +10:00
Nyall Dawson
f799d3afc8 Move allFeatureIds from QgsVectorLayer to QgsFeatureSource 2017-09-08 20:09:29 +10:00
Richard Duivenvoorde
7a62746297 fix capitalisation 2017-09-08 12:05:48 +02:00
Alexander Bruy
1fb48f456c [processing] fix file filter construction for output files 2017-09-08 11:56:23 +03:00
Alessandro Pasotti
f0e021c2fd Merge pull request #5000 from jgrocha/add-default-layers
[FEATURE][needs-docs] Add XYZ connection to provide default OpenStreetMap tiles
2017-09-08 10:40:45 +02:00
Nyall Dawson
1aa76ac175 Port Select by Location to c++ 2017-09-08 17:40:36 +10:00
Alessandro Pasotti
274cc6c86c Disable SQL filter when a raster is selected 2017-09-08 09:36:00 +02:00
Alessandro Pasotti
7d4c24eea5 Give credits to the original author of the source select
and amend some comments
2017-09-08 09:26:18 +02:00
Juergen E. Fischer
25c27b3c80 avoid leak 2017-09-08 09:03:11 +02:00
Juergen E. Fischer
133d16c532 use SIP_SKIP (followup 5c3a72014) 2017-09-08 09:02:53 +02:00
Nyall Dawson
a9f4540081 Remove 'precision' option from spatial relation processing algs
Rationale:
- the correct use for this option is unclear, and users are
mistakenly using it as a 'tolerance' option
- it's very likely to generate invalid geometries as a result
of the snapping, causing unreliable results

Given these substantial issues, it's safer to remove this
option and require that users who need the snap to grid
precision change explicitly do this via an extra model
step before running the algorithm.
2017-09-08 16:48:59 +10:00
Nyall Dawson
24a4ab7f0d Rework Select by Location algorithm
Changes:

- handle different CRS transparently

- don't build a spatial index on the selection layer. Instead
only use feature requests to fetch features which are within
the desired bounds, and rely on the presence of an appropriate
spatial index at the provider's backend. Otherwise, we force
every user of this algorithm to have a full iteration of the
source table, regardless of how large the table is. That means
that trying to select a set of addresses which fall within
a specific locality from a table which contains the addresses
for a whole state will FORCE every address in the state to
be initially read before any calculation begins. With this
change only those features within the bounding box of the
selected localities will ever be fetched from the provider,
resulting in huge speed improvements for the algorithm.

- use prepared geometries for the spatial relation tests.
This dramatically speeds up the algorithm in the case
where the intersection layer features cover multiple
features from the 'selection' layer.

- Add a 'select within current selection' mode

- Optimise feature requests for efficiency (especially
with respect to the 'disjoint' selection mode)
2017-09-08 16:48:59 +10:00
Alessandro Pasotti
eca6137088 Use the new generic OGR source select class 2017-09-08 08:40:22 +02:00
Alessandro Pasotti
ce3d644e74 Generic implementation of OGR file DB connection 2017-09-08 08:39:28 +02:00
Alessandro Pasotti
1a9fa28b05 New generic file-based DB OGR source select 2017-09-08 08:37:00 +02:00
Alessandro Pasotti
6e34681b73 Use the OGR generic methods 2017-09-08 08:35:46 +02:00
Nyall Dawson
4ca972a2ff Fix stats by categories tests on Travis 2017-09-08 16:35:18 +10:00
Alessandro Pasotti
1b72a0d857 Moved some reusable methods from gpkg to the ogr items class 2017-09-08 08:34:31 +02:00
Nyall Dawson
e9fd409552 Allow multiple primary key fields to be specified for processing tests
`
2017-09-08 16:33:55 +10:00
Alessandro Pasotti
ce54111607 Added add geopackage icon 2017-09-08 08:24:07 +02:00
Alessandro Pasotti
abb99e5fa7 Refactor of QgsGeoPackageConnection to a generic class 2017-09-08 08:23:19 +02:00