Replace reimplemented default methods by = default

Using clang-tidy modernize-use-equals-default

python/core/qgsdiagramrenderer.sip

@@ -11,7 +11,6 @@
 
 
 
-
 class QgsDiagramLayerSettings
 {
 %Docstring

python/core/qgspropertytransformer.sip

@@ -339,11 +339,6 @@ class QgsGenericNumericTransformer : QgsPropertyTransformer
  \param exponent optional exponential for non-linear scaling
 %End
 
-    QgsGenericNumericTransformer( const QgsGenericNumericTransformer &other );
-%Docstring
- Copy constructor.
-%End
-
     virtual Type transformerType() const;
     virtual QgsGenericNumericTransformer *clone() const /Factory/;
     virtual QVariant toVariant() const;
@@ -475,11 +470,6 @@ class QgsSizeScaleTransformer : QgsPropertyTransformer
  \param exponent exponent for Exponential scaling method
 %End
 
-    QgsSizeScaleTransformer( const QgsSizeScaleTransformer &other );
-%Docstring
- Copy constructor.
-%End
-
     virtual Type transformerType() const;
     virtual QgsSizeScaleTransformer *clone() const /Factory/;
     virtual QVariant toVariant() const;

python/core/symbology/qgscategorizedsymbolrenderer.sip

@@ -78,7 +78,6 @@ class QgsCategorizedSymbolRenderer : QgsFeatureRenderer
   public:
 
     QgsCategorizedSymbolRenderer( const QString &attrName = QString(), const QgsCategoryList &categories = QgsCategoryList() );
-    ~QgsCategorizedSymbolRenderer();
 
     virtual QgsSymbol *symbolForFeature( QgsFeature &feature, QgsRenderContext &context );
     virtual QgsSymbol *originalSymbolForFeature( QgsFeature &feature, QgsRenderContext &context );

python/core/symbology/qgssinglesymbolrenderer.sip

@@ -17,7 +17,6 @@ class QgsSingleSymbolRenderer : QgsFeatureRenderer
   public:
 
     QgsSingleSymbolRenderer( QgsSymbol *symbol /Transfer/ );
-    ~QgsSingleSymbolRenderer();
 
     virtual QgsSymbol *symbolForFeature( QgsFeature &feature, QgsRenderContext &context );
     virtual QgsSymbol *originalSymbolForFeature( QgsFeature &feature, QgsRenderContext &context );

python/gui/attributetable/qgsfeaturelistmodel.sip

@@ -34,7 +34,6 @@ class QgsFeatureListModel : QAbstractProxyModel, QgsFeatureModel
 
   public:
     explicit QgsFeatureListModel( QgsAttributeTableFilterModel *sourceModel, QObject *parent /TransferThis/ = 0 );
-    virtual ~QgsFeatureListModel();
 
     virtual void setSourceModel( QgsAttributeTableFilterModel *sourceModel );
     QgsVectorLayerCache *layerCache();

python/gui/attributetable/qgsfieldconditionalformatwidget.sip

@@ -28,8 +28,6 @@ class QgsFieldConditionalFormatWidget : QWidget
  \param parent parent widget
 %End
 
-    ~QgsFieldConditionalFormatWidget();
-
     void viewRules();
 %Docstring
  Switches the widget to the rules page.

python/gui/symbology/qgssvgselectorwidget.sip

@@ -75,7 +75,6 @@ class QgsSvgSelectorWidget : QWidget
 %End
   public:
     QgsSvgSelectorWidget( QWidget *parent /TransferThis/ = 0 );
-    ~QgsSvgSelectorWidget();
 
     QString currentSvgPath() const;
 %Docstring

src/analysis/network/qgsgraph.cpp

@@ -20,10 +20,6 @@
 
 #include "qgsgraph.h"
 
-QgsGraph::QgsGraph()
-{
-}
-
 int QgsGraph::addVertex( const QgsPointXY &pt )
 {
   mGraphVertexes.append( QgsGraphVertex( pt ) );

src/analysis/network/qgsgraph.h

@@ -131,7 +131,7 @@ class ANALYSIS_EXPORT QgsGraphVertex
 class ANALYSIS_EXPORT QgsGraph
 {
   public:
-    QgsGraph();
+    QgsGraph() = default;
 
     // Graph constructing methods
 

src/app/composer/qgsatlascompositionwidget.cpp

@@ -59,10 +59,6 @@ QgsAtlasCompositionWidget::QgsAtlasCompositionWidget( QWidget *parent, QgsCompos
   updateGuiElements();
 }
 
-QgsAtlasCompositionWidget::~QgsAtlasCompositionWidget()
-{
-}
-
 void QgsAtlasCompositionWidget::on_mUseAtlasCheckBox_stateChanged( int state )
 {
   QgsAtlasComposition *atlasMap = &mComposition->atlasComposition();

src/app/composer/qgsatlascompositionwidget.h

@@ -31,7 +31,6 @@ class QgsAtlasCompositionWidget:
     Q_OBJECT
   public:
     QgsAtlasCompositionWidget( QWidget *parent, QgsComposition *c );
-    ~QgsAtlasCompositionWidget();
 
   public slots:
     void on_mUseAtlasCheckBox_stateChanged( int state );

src/app/composer/qgscomposerarrowwidget.cpp

@@ -61,11 +61,6 @@ QgsComposerArrowWidget::QgsComposerArrowWidget( QgsComposerArrow *arrow ): QgsCo
   }
 }
 
-QgsComposerArrowWidget::~QgsComposerArrowWidget()
-{
-
-}
-
 void QgsComposerArrowWidget::on_mStrokeWidthSpinBox_valueChanged( double d )
 {
   if ( !mArrow )

src/app/composer/qgscomposerarrowwidget.h

@@ -28,7 +28,6 @@ class QgsComposerArrowWidget: public QgsComposerItemBaseWidget, private Ui::QgsC
     Q_OBJECT
   public:
     explicit QgsComposerArrowWidget( QgsComposerArrow *arrow );
-    ~QgsComposerArrowWidget();
 
   private:
     QgsComposerArrow *mArrow = nullptr;

src/app/composer/qgscomposerattributetablewidget.cpp

@@ -114,10 +114,6 @@ QgsComposerAttributeTableWidget::QgsComposerAttributeTableWidget( QgsComposerAtt
   connect( mContentFontToolButton, &QgsFontButton::changed, this, &QgsComposerAttributeTableWidget::contentFontChanged );
 }
 
-QgsComposerAttributeTableWidget::~QgsComposerAttributeTableWidget()
-{
-}
-
 void QgsComposerAttributeTableWidget::on_mRefreshPushButton_clicked()
 {
   if ( !mComposerTable )

src/app/composer/qgscomposerattributetablewidget.h

@@ -29,7 +29,6 @@ class QgsComposerAttributeTableWidget: public QgsComposerItemBaseWidget, private
     Q_OBJECT
   public:
     QgsComposerAttributeTableWidget( QgsComposerAttributeTableV2 *table, QgsComposerFrame *frame );
-    ~QgsComposerAttributeTableWidget();
 
   private:
     QgsComposerAttributeTableV2 *mComposerTable = nullptr;

src/app/composer/qgscomposerhtmlwidget.cpp

@@ -76,10 +76,6 @@ QgsComposerHtmlWidget::QgsComposerHtmlWidget()
 {
 }
 
-QgsComposerHtmlWidget::~QgsComposerHtmlWidget()
-{
-}
-
 void QgsComposerHtmlWidget::blockSignals( bool block )
 {
   mUrlLineEdit->blockSignals( block );

src/app/composer/qgscomposerhtmlwidget.h

@@ -28,7 +28,6 @@ class QgsComposerHtmlWidget: public QgsComposerItemBaseWidget, private Ui::QgsCo
     Q_OBJECT
   public:
     QgsComposerHtmlWidget( QgsComposerHtml *html, QgsComposerFrame *frame );
-    ~QgsComposerHtmlWidget();
 
   private slots:
     void on_mUrlLineEdit_editingFinished();

src/app/composer/qgscomposeritemwidget.cpp

@@ -40,10 +40,6 @@ QgsComposerConfigObject::QgsComposerConfigObject( QWidget *parent, QgsComposerOb
   connect( atlasComposition(), &QgsAtlasComposition::toggled, this, &QgsComposerConfigObject::updateDataDefinedButtons );
 }
 
-QgsComposerConfigObject::~QgsComposerConfigObject()
-{
-}
-
 void QgsComposerConfigObject::updateDataDefinedProperty()
 {
   //match data defined button to item's data defined property
@@ -183,11 +179,6 @@ QgsComposerItemWidget::QgsComposerItemWidget( QWidget *parent, QgsComposerItem *
     connect( mItem->composition(), &QgsComposition::variablesChanged, this, &QgsComposerItemWidget::updateVariables );
 }
 
-QgsComposerItemWidget::~QgsComposerItemWidget()
-{
-
-}
-
 void QgsComposerItemWidget::showBackgroundGroup( bool showGroup )
 {
   mBackgroundGroupBox->setVisible( showGroup );

src/app/composer/qgscomposeritemwidget.h

@@ -53,7 +53,6 @@ class QgsComposerConfigObject: public QObject
     Q_OBJECT
   public:
     QgsComposerConfigObject( QWidget *parent, QgsComposerObject *composerObject );
-    ~QgsComposerConfigObject();
 
     /** Registers a data defined button, setting up its initial value, connections and description.
      * \param button button to register
@@ -126,7 +125,6 @@ class QgsComposerItemWidget: public QWidget, private Ui::QgsComposerItemWidgetBa
     Q_OBJECT
   public:
     QgsComposerItemWidget( QWidget *parent, QgsComposerItem *item );
-    ~QgsComposerItemWidget();
 
     //! A combination of upper/middle/lower and left/middle/right
     QgsComposerItem::ItemPositionMode positionMode() const;

src/app/composer/qgscomposerlegendlayersdialog.cpp

@@ -29,14 +29,9 @@ QgsComposerLegendLayersDialog::QgsComposerLegendLayersDialog( QList<QgsMapLayer
   }
 }
 
-QgsComposerLegendLayersDialog::QgsComposerLegendLayersDialog(): QDialog( nullptr )
+QgsComposerLegendLayersDialog::QgsComposerLegendLayersDialog()
+  : QDialog( nullptr )
 {
-
-}
-
-QgsComposerLegendLayersDialog::~QgsComposerLegendLayersDialog()
-{
-
 }
 
 QgsMapLayer *QgsComposerLegendLayersDialog::selectedLayer()

src/app/composer/qgscomposerlegendlayersdialog.h

@@ -28,7 +28,7 @@ class QgsComposerLegendLayersDialog: public QDialog, private Ui::QgsComposerLege
 
   public:
     QgsComposerLegendLayersDialog( QList<QgsMapLayer *> layers, QWidget *parent = nullptr );
-    ~QgsComposerLegendLayersDialog();
+
     QgsMapLayer *selectedLayer();
 
   private:

src/app/composer/qgscomposerlegendwidget.cpp

@@ -124,11 +124,6 @@ QgsComposerLegendWidget::QgsComposerLegendWidget(): QgsComposerItemBaseWidget( n
   setupUi( this );
 }
 
-QgsComposerLegendWidget::~QgsComposerLegendWidget()
-{
-
-}
-
 void QgsComposerLegendWidget::setGuiElements()
 {
   if ( !mLegend )

src/app/composer/qgscomposerlegendwidget.h

@@ -35,7 +35,6 @@ class QgsComposerLegendWidget: public QgsComposerItemBaseWidget, private Ui::Qgs
 
   public:
     explicit QgsComposerLegendWidget( QgsComposerLegend *legend );
-    ~QgsComposerLegendWidget();
 
     //! Updates the legend layers and groups
     void updateLegend();

src/app/composer/qgscomposermapgridwidget.cpp

@@ -105,10 +105,6 @@ QgsComposerMapGridWidget::QgsComposerMapGridWidget( QgsComposerMapGrid *mapGrid,
   connect( mAnnotationFontButton, &QgsFontButton::changed, this, &QgsComposerMapGridWidget::annotationFontChanged );
 }
 
-QgsComposerMapGridWidget::~QgsComposerMapGridWidget()
-{
-}
-
 void QgsComposerMapGridWidget::populateDataDefinedButtons()
 {
   // none for now

src/app/composer/qgscomposermapgridwidget.h

@@ -31,7 +31,6 @@ class QgsComposerMapGridWidget: public QgsComposerItemBaseWidget, private Ui::Qg
 
   public:
     explicit QgsComposerMapGridWidget( QgsComposerMapGrid *mapGrid, QgsComposerMap *composerMap );
-    virtual ~QgsComposerMapGridWidget();
 
   public slots:
 

src/app/composer/qgscomposermapwidget.cpp

@@ -122,10 +122,6 @@ QgsComposerMapWidget::QgsComposerMapWidget( QgsComposerMap *composerMap )
   blockAllSignals( false );
 }
 
-QgsComposerMapWidget::~QgsComposerMapWidget()
-{
-}
-
 void QgsComposerMapWidget::populateDataDefinedButtons()
 {
   updateDataDefinedButton( mScaleDDBtn );

src/app/composer/qgscomposermapwidget.h

@@ -34,7 +34,6 @@ class QgsComposerMapWidget: public QgsComposerItemBaseWidget, private Ui::QgsCom
 
   public:
     explicit QgsComposerMapWidget( QgsComposerMap *composerMap );
-    virtual ~QgsComposerMapWidget();
 
   public slots:
     void on_mScaleLineEdit_editingFinished();

src/app/composer/qgscomposerpicturewidget.cpp

@@ -85,11 +85,6 @@ QgsComposerPictureWidget::QgsComposerPictureWidget( QgsComposerPicture *picture
   registerDataDefinedButton( mStrokeWidthDDBtn, QgsComposerObject::PictureSvgStrokeWidth );
 }
 
-QgsComposerPictureWidget::~QgsComposerPictureWidget()
-{
-
-}
-
 void QgsComposerPictureWidget::on_mPictureBrowseButton_clicked()
 {
   QgsSettings s;

src/app/composer/qgscomposerpicturewidget.h

@@ -32,7 +32,6 @@ class QgsComposerPictureWidget: public QgsComposerItemBaseWidget, private Ui::Qg
 
   public:
     explicit QgsComposerPictureWidget( QgsComposerPicture *picture );
-    ~QgsComposerPictureWidget();
 
     //! Add the icons of the standard directories to the preview
     void addStandardDirectoriesToPreview();

src/app/composer/qgscomposerpolygonwidget.cpp

@@ -45,10 +45,6 @@ QgsComposerPolygonWidget::QgsComposerPolygonWidget( QgsComposerPolygon *composer
   }
 }
 
-QgsComposerPolygonWidget::~QgsComposerPolygonWidget()
-{
-}
-
 void QgsComposerPolygonWidget::on_mPolygonStyleButton_clicked()
 {
   if ( !mComposerPolygon )

src/app/composer/qgscomposerpolygonwidget.h

@@ -31,7 +31,6 @@ class QgsComposerPolygonWidget: public QgsComposerItemBaseWidget, private Ui::Qg
     Q_OBJECT
   public:
     explicit QgsComposerPolygonWidget( QgsComposerPolygon *composerPolygon );
-    ~QgsComposerPolygonWidget();
 
   private:
     QgsComposerPolygon *mComposerPolygon = nullptr;

src/app/composer/qgscomposerpolylinewidget.cpp

@@ -42,10 +42,6 @@ QgsComposerPolylineWidget::QgsComposerPolylineWidget( QgsComposerPolyline *compo
     connect( mComposerPolyline, &QgsComposerObject::itemChanged, this, &QgsComposerPolylineWidget::setGuiElementValues );
 }
 
-QgsComposerPolylineWidget::~QgsComposerPolylineWidget()
-{
-}
-
 void QgsComposerPolylineWidget::on_mLineStyleButton_clicked()
 {
   if ( !mComposerPolyline )

src/app/composer/qgscomposerpolylinewidget.h

@@ -31,7 +31,6 @@ class QgsComposerPolylineWidget: public QgsComposerItemBaseWidget, private Ui::Q
     Q_OBJECT
   public:
     explicit QgsComposerPolylineWidget( QgsComposerPolyline *composerPolyline );
-    ~QgsComposerPolylineWidget();
 
   private:
     QgsComposerPolyline *mComposerPolyline = nullptr;

src/app/composer/qgscomposerscalebarwidget.cpp

@@ -104,11 +104,6 @@ QgsComposerScaleBarWidget::QgsComposerScaleBarWidget( QgsComposerScaleBar *scale
   connect( mFontButton, &QgsFontButton::changed, this, &QgsComposerScaleBarWidget::fontChanged );
 }
 
-QgsComposerScaleBarWidget::~QgsComposerScaleBarWidget()
-{
-
-}
-
 void QgsComposerScaleBarWidget::setGuiElements()
 {
   if ( !mComposerScaleBar )

src/app/composer/qgscomposerscalebarwidget.h

@@ -31,7 +31,6 @@ class QgsComposerScaleBarWidget: public QgsComposerItemBaseWidget, private Ui::Q
 
   public:
     explicit QgsComposerScaleBarWidget( QgsComposerScaleBar *scaleBar );
-    ~QgsComposerScaleBarWidget();
 
   public slots:
 

src/app/composer/qgscomposershapewidget.cpp

@@ -60,11 +60,6 @@ QgsComposerShapeWidget::QgsComposerShapeWidget( QgsComposerShape *composerShape
   mShapeStyleButton->setLayer( atlasCoverageLayer() );
 }
 
-QgsComposerShapeWidget::~QgsComposerShapeWidget()
-{
-
-}
-
 void QgsComposerShapeWidget::blockAllSignals( bool block )
 {
   mShapeComboBox->blockSignals( block );

src/app/composer/qgscomposershapewidget.h

@@ -29,7 +29,6 @@ class QgsComposerShapeWidget: public QgsComposerItemBaseWidget, private Ui::QgsC
     Q_OBJECT
   public:
     explicit QgsComposerShapeWidget( QgsComposerShape *composerShape );
-    ~QgsComposerShapeWidget();
 
   private:
     QgsComposerShape *mComposerShape = nullptr;

src/app/composer/qgscompositionwidget.cpp

@@ -130,11 +130,6 @@ QgsCompositionWidget::QgsCompositionWidget()
   setupUi( this );
 }
 
-QgsCompositionWidget::~QgsCompositionWidget()
-{
-
-}
-
 void QgsCompositionWidget::populateDataDefinedButtons()
 {
   if ( !mComposition )

src/app/composer/qgscompositionwidget.h

@@ -39,7 +39,6 @@ class QgsCompositionWidget: public QgsPanelWidget, private Ui::QgsCompositionWid
     Q_OBJECT
   public:
     QgsCompositionWidget( QWidget *parent, QgsComposition *c );
-    ~QgsCompositionWidget();
 
   public slots:
     void on_mPaperSizeComboBox_currentIndexChanged( const QString &text );

src/app/pluginmanager/qgsapppluginmanagerinterface.cpp

@@ -24,11 +24,6 @@ QgsAppPluginManagerInterface::QgsAppPluginManagerInterface( QgsPluginManager *pl
 {
 }
 
-
-QgsAppPluginManagerInterface::~QgsAppPluginManagerInterface()
-{
-}
-
 void QgsAppPluginManagerInterface::showPluginManager( int tabIndex )
 {
   mPluginManager->getCppPluginsMetadata();

src/app/pluginmanager/qgsapppluginmanagerinterface.h

@@ -34,8 +34,6 @@ class QgsAppPluginManagerInterface : public QgsPluginManagerInterface
     //! Constructor
     explicit QgsAppPluginManagerInterface( QgsPluginManager *pluginManager );
 
-    ~QgsAppPluginManagerInterface();
-
     //! remove Python plugins from the metadata registry (c++ plugins stay)
     void clearPythonPluginMetadata() override;
 

src/app/qgisappstylesheet.cpp

@@ -31,10 +31,6 @@ QgisAppStyleSheet::QgisAppStyleSheet( QObject *parent )
   setActiveValues();
 }
 
-QgisAppStyleSheet::~QgisAppStyleSheet()
-{
-}
-
 QMap<QString, QVariant> QgisAppStyleSheet::defaultOptions()
 {
   QMap<QString, QVariant> opts;

src/app/qgisappstylesheet.h

@@ -32,7 +32,6 @@ class APP_EXPORT QgisAppStyleSheet: public QObject
 
   public:
     QgisAppStyleSheet( QObject *parent = nullptr );
-    ~QgisAppStyleSheet();
 
     //! Return changeable options built from settings and/or defaults
     QMap<QString, QVariant> defaultOptions();

src/app/qgsabout.cpp

@@ -40,10 +40,6 @@ QgsAbout::QgsAbout( QWidget * parent )
   init();
 }
 
-QgsAbout::~QgsAbout()
-{
-}
-
 void QgsAbout::init()
 {
   setPluginInfo();

src/app/qgsabout.h

@@ -26,7 +26,7 @@ class APP_EXPORT QgsAbout : public QgsOptionsDialogBase, private Ui::QgsAbout
     Q_OBJECT
   public:
     QgsAbout( QWidget *parent );
-    ~QgsAbout();
+
     void setVersion( const QString &v );
     static QString fileSystemSafe( const QString &string );
 

src/app/qgsaddtaborgroup.cpp

@@ -56,10 +56,6 @@ QgsAddTabOrGroup::QgsAddTabOrGroup( QgsVectorLayer *lyr, const QList < TabPair >
   mColumnCountSpinBox->setValue( QgsSettings().value( QStringLiteral( "/qgis/attributeForm/defaultTabColumnCount" ), 1 ).toInt() );
 
   setWindowTitle( tr( "Add Tab or Group for %1" ).arg( mLayer->name() ) );
-} // QgsVectorLayerProperties ctor
-
-QgsAddTabOrGroup::~QgsAddTabOrGroup()
-{
 }
 
 QString QgsAddTabOrGroup::name()

src/app/qgsaddtaborgroup.h

@@ -36,7 +36,6 @@ class APP_EXPORT QgsAddTabOrGroup : public QDialog, private Ui::QgsAddTabOrGroup
 
   public:
     QgsAddTabOrGroup( QgsVectorLayer *lyr, const QList<TabPair> &tabList, QWidget *parent = nullptr );
-    ~QgsAddTabOrGroup();
 
     QString name();
 

src/app/qgsannotationwidget.cpp

@@ -74,10 +74,6 @@ QgsAnnotationWidget::QgsAnnotationWidget( QgsMapCanvasAnnotationItem *item, QWid
   mFrameStyleButton->setMapCanvas( QgisApp::instance()->mapCanvas() );
 }
 
-QgsAnnotationWidget::~QgsAnnotationWidget()
-{
-}
-
 void QgsAnnotationWidget::apply()
 {
   if ( mItem )

src/app/qgsannotationwidget.h

@@ -33,7 +33,6 @@ class APP_EXPORT QgsAnnotationWidget: public QWidget, private Ui::QgsAnnotationW
     Q_OBJECT
   public:
     QgsAnnotationWidget( QgsMapCanvasAnnotationItem *item, QWidget *parent = nullptr, Qt::WindowFlags f = 0 );
-    ~QgsAnnotationWidget();
 
     void apply();
 

src/app/qgsclipboard.cpp

@@ -48,10 +48,6 @@ QgsClipboard::QgsClipboard()
   connect( QApplication::clipboard(), &QClipboard::dataChanged, this, &QgsClipboard::systemClipboardChanged );
 }
 
-QgsClipboard::~QgsClipboard()
-{
-}
-
 void QgsClipboard::replaceWithCopyOf( QgsVectorLayer *src )
 {
   if ( !src )

src/app/qgsclipboard.h

@@ -69,8 +69,6 @@ class APP_EXPORT QgsClipboard : public QObject
      */
     QgsClipboard();
 
-    virtual ~QgsClipboard();
-
     /**
      *  Place a copy of the selected features from the specified layer on
      *  the internal clipboard, destroying the previous contents.

src/app/qgscustomization.cpp

@@ -644,10 +644,6 @@ QgsCustomization::QgsCustomization()
   mEnabled = settings.value( QStringLiteral( "UI/Customization/enabled" ), "false" ).toString() == QLatin1String( "true" );
 }
 
-QgsCustomization::~QgsCustomization()
-{
-}
-
 void QgsCustomization::updateMainWindow( QMenu *toolBarMenu )
 {
   // collect tree items even if the customization is disabled

src/app/qgscustomization.h

@@ -148,7 +148,7 @@ class APP_EXPORT QgsCustomization : public QObject
 
   protected:
     QgsCustomization();
-    ~QgsCustomization();
+    ~QgsCustomization() = default;
     QgsCustomizationDialog *pDialog = nullptr;
 
     bool mEnabled;

src/app/qgsdecorationitem.cpp

@@ -52,11 +52,6 @@ QgsDecorationItem::QgsDecorationItem( QObject *parent )
 {
 }
 
-QgsDecorationItem::~QgsDecorationItem()
-{
-
-}
-
 void QgsDecorationItem::update()
 {
   saveToProject();

src/app/qgsdecorationitem.h

@@ -46,8 +46,6 @@ class APP_EXPORT QgsDecorationItem : public QObject, public QgsMapDecoration
     //! Constructor
     QgsDecorationItem( QObject *parent = nullptr );
 
-    virtual ~ QgsDecorationItem();
-
     void setEnabled( bool enabled ) { mEnabled = enabled; }
     bool enabled() const { return mEnabled; }
 

src/app/qgsdecorationnortharrow.cpp

@@ -69,10 +69,6 @@ QgsDecorationNorthArrow::QgsDecorationNorthArrow( QObject *parent )
   projectRead();
 }
 
-QgsDecorationNorthArrow::~QgsDecorationNorthArrow()
-{
-}
-
 void QgsDecorationNorthArrow::projectRead()
 {
   QgsDecorationItem::projectRead();

src/app/qgsdecorationnortharrow.h

@@ -36,8 +36,6 @@ class APP_EXPORT QgsDecorationNorthArrow: public QgsDecorationItem
     //! Constructor
     QgsDecorationNorthArrow( QObject *parent = nullptr );
 
-    virtual ~QgsDecorationNorthArrow();
-
   public slots:
     //! set values on the gui when a project is read or the gui first loaded
     void projectRead() override;

src/app/qgsdecorationscalebar.cpp

@@ -65,11 +65,6 @@ QgsDecorationScaleBar::QgsDecorationScaleBar( QObject *parent )
   projectRead();
 }
 
-QgsDecorationScaleBar::~QgsDecorationScaleBar()
-{
-
-}
-
 void QgsDecorationScaleBar::projectRead()
 {
   QgsDecorationItem::projectRead();

src/app/qgsdecorationscalebar.h

@@ -36,8 +36,6 @@ class APP_EXPORT QgsDecorationScaleBar: public QgsDecorationItem
     //! Constructor
     QgsDecorationScaleBar( QObject *parent = nullptr );
 
-    virtual ~ QgsDecorationScaleBar();
-
   public slots:
     //! set values on the gui when a project is read or the gui first loaded
     void projectRead() override;

src/app/qgsdisplayangle.cpp

@@ -30,10 +30,6 @@ QgsDisplayAngle::QgsDisplayAngle( QgsMapToolMeasureAngle *tool, Qt::WindowFlags
   setupUi( this );
 }
 
-QgsDisplayAngle::~QgsDisplayAngle()
-{
-}
-
 void QgsDisplayAngle::setValueInRadians( double value )
 {
   mValue = value;

src/app/qgsdisplayangle.h

@@ -28,7 +28,6 @@ class APP_EXPORT QgsDisplayAngle: public QDialog, private Ui::QgsDisplayAngleBas
 
   public:
     QgsDisplayAngle( QgsMapToolMeasureAngle *tool = nullptr, Qt::WindowFlags f = 0 );
-    ~QgsDisplayAngle();
 
     /** Sets the measured angle value (in radians). The value is going to
       be converted to degrees / gon automatically if necessary*/

src/app/qgsdxfexportdialog.cpp

@@ -99,10 +99,6 @@ QgsVectorLayerAndAttributeModel::QgsVectorLayerAndAttributeModel( QgsLayerTree *
 {
 }
 
-QgsVectorLayerAndAttributeModel::~QgsVectorLayerAndAttributeModel()
-{
-}
-
 int QgsVectorLayerAndAttributeModel::columnCount( const QModelIndex &parent ) const
 {
   Q_UNUSED( parent );

src/app/qgsdxfexportdialog.h

@@ -47,7 +47,6 @@ class QgsVectorLayerAndAttributeModel : public QgsLayerTreeModel
     Q_OBJECT
   public:
     QgsVectorLayerAndAttributeModel( QgsLayerTree *rootNode, QObject *parent = nullptr );
-    ~QgsVectorLayerAndAttributeModel();
 
     int columnCount( const QModelIndex &parent = QModelIndex() ) const override;
     QVariant headerData( int section, Qt::Orientation orientation, int role = Qt::DisplayRole ) const override;

src/app/qgsformannotationdialog.cpp

@@ -46,11 +46,6 @@ QgsFormAnnotationDialog::QgsFormAnnotationDialog( QgsMapCanvasAnnotationItem *it
   mButtonBox->addButton( deleteButton, QDialogButtonBox::RejectRole );
 }
 
-QgsFormAnnotationDialog::~QgsFormAnnotationDialog()
-{
-
-}
-
 void QgsFormAnnotationDialog::applySettingsToItem()
 {
   //apply settings from embedded item widget

src/app/qgsformannotationdialog.h

@@ -26,7 +26,6 @@ class APP_EXPORT QgsFormAnnotationDialog: public QDialog, private Ui::QgsFormAnn
     Q_OBJECT
   public:
     QgsFormAnnotationDialog( QgsMapCanvasAnnotationItem *item, QWidget *parent = nullptr, Qt::WindowFlags f = 0 );
-    ~QgsFormAnnotationDialog();
 
   private:
     QgsMapCanvasAnnotationItem *mItem = nullptr;

src/app/qgshandlebadlayers.cpp

@@ -34,10 +34,6 @@
 #include <QMessageBox>
 #include <QUrl>
 
-QgsHandleBadLayersHandler::QgsHandleBadLayersHandler()
-{
-}
-
 void QgsHandleBadLayersHandler::handleBadLayers( const QList<QDomNode> &layers )
 {
   QApplication::setOverrideCursor( Qt::ArrowCursor );
@@ -151,10 +147,6 @@ QgsHandleBadLayers::QgsHandleBadLayers( const QList<QDomNode> &layers )
   // mLayerList->resizeColumnsToContents();
 }
 
-QgsHandleBadLayers::~QgsHandleBadLayers()
-{
-}
-
 void QgsHandleBadLayers::selectionChanged()
 {
 

src/app/qgshandlebadlayers.h

@@ -29,7 +29,7 @@ class APP_EXPORT QgsHandleBadLayersHandler
     Q_OBJECT
 
   public:
-    QgsHandleBadLayersHandler();
+    QgsHandleBadLayersHandler() = default;
 
     //! Implementation of the handler
     virtual void handleBadLayers( const QList<QDomNode> &layers ) override;
@@ -46,7 +46,6 @@ class APP_EXPORT QgsHandleBadLayers
 
   public:
     QgsHandleBadLayers( const QList<QDomNode> &layers );
-    ~QgsHandleBadLayers();
 
     int layerCount();
 

src/app/qgshtmlannotationdialog.cpp

@@ -47,11 +47,6 @@ QgsHtmlAnnotationDialog::QgsHtmlAnnotationDialog( QgsMapCanvasAnnotationItem *it
   mButtonBox->addButton( deleteButton, QDialogButtonBox::RejectRole );
 }
 
-QgsHtmlAnnotationDialog::~QgsHtmlAnnotationDialog()
-{
-
-}
-
 void QgsHtmlAnnotationDialog::applySettingsToItem()
 {
   //apply settings from embedded item widget

src/app/qgshtmlannotationdialog.h

@@ -26,7 +26,6 @@ class APP_EXPORT QgsHtmlAnnotationDialog: public QDialog, private Ui::QgsFormAnn
     Q_OBJECT
   public:
     QgsHtmlAnnotationDialog( QgsMapCanvasAnnotationItem *item, QWidget *parent = nullptr, Qt::WindowFlags f = 0 );
-    ~QgsHtmlAnnotationDialog();
 
   private:
     QgsMapCanvasAnnotationItem *mItem = nullptr;

src/app/qgsjoindialog.cpp

@@ -69,10 +69,6 @@ QgsJoinDialog::QgsJoinDialog( QgsVectorLayer *layer, QList<QgsMapLayer *> alread
   checkDefinitionValid();
 }
 
-QgsJoinDialog::~QgsJoinDialog()
-{
-}
-
 void QgsJoinDialog::setJoinInfo( const QgsVectorLayerJoinInfo &joinInfo )
 {
   mJoinLayerComboBox->setLayer( joinInfo.joinLayer() );

src/app/qgsjoindialog.h

@@ -29,7 +29,6 @@ class APP_EXPORT QgsJoinDialog: public QDialog, private Ui::QgsJoinDialogBase
     Q_OBJECT
   public:
     QgsJoinDialog( QgsVectorLayer *layer, QList<QgsMapLayer *> alreadyJoinedLayers, QWidget *parent = nullptr, Qt::WindowFlags f = 0 );
-    ~QgsJoinDialog();
 
     //! Configure the dialog for an existing join
     void setJoinInfo( const QgsVectorLayerJoinInfo &joinInfo );

src/app/qgsmaptooladdfeature.cpp

@@ -45,10 +45,6 @@ QgsMapToolAddFeature::QgsMapToolAddFeature( QgsMapCanvas *canvas, CaptureMode mo
   connect( QgisApp::instance(), &QgisApp::projectRead, this, &QgsMapToolAddFeature::stopCapturing );
 }
 
-QgsMapToolAddFeature::~QgsMapToolAddFeature()
-{
-}
-
 bool QgsMapToolAddFeature::addFeature( QgsVectorLayer *vlayer, QgsFeature *f, bool showModal )
 {
   QgsExpressionContextScope *scope = QgsExpressionContextUtils::mapToolCaptureScope( snappingMatches() );

src/app/qgsmaptooladdfeature.h

@@ -23,7 +23,7 @@ class APP_EXPORT QgsMapToolAddFeature : public QgsMapToolCapture
   public:
     //! \since QGIS 2.12
     QgsMapToolAddFeature( QgsMapCanvas *canvas, CaptureMode mode );
-    virtual ~QgsMapToolAddFeature();
+
     void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
 
     bool addFeature( QgsVectorLayer *vlayer, QgsFeature *f, bool showModal = true );

src/app/qgsmaptooladdpart.cpp

@@ -35,10 +35,6 @@ QgsMapToolAddPart::QgsMapToolAddPart( QgsMapCanvas *canvas )
   connect( QgisApp::instance(), &QgisApp::projectRead, this, &QgsMapToolAddPart::stopCapturing );
 }
 
-QgsMapToolAddPart::~QgsMapToolAddPart()
-{
-}
-
 void QgsMapToolAddPart::canvasReleaseEvent( QgsMapMouseEvent *e )
 {
   if ( checkSelection() )

src/app/qgsmaptooladdpart.h

@@ -22,7 +22,7 @@ class APP_EXPORT QgsMapToolAddPart : public QgsMapToolCapture
     Q_OBJECT
   public:
     QgsMapToolAddPart( QgsMapCanvas *canvas );
-    virtual ~QgsMapToolAddPart();
+
     void canvasReleaseEvent( QgsMapMouseEvent *e ) override;
     void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
 

src/app/qgsmaptooladdring.cpp

@@ -33,10 +33,6 @@ QgsMapToolAddRing::QgsMapToolAddRing( QgsMapCanvas *canvas )
   connect( QgisApp::instance(), &QgisApp::projectRead, this, &QgsMapToolAddRing::stopCapturing );
 }
 
-QgsMapToolAddRing::~QgsMapToolAddRing()
-{
-}
-
 void QgsMapToolAddRing::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
 {
 

src/app/qgsmaptooladdring.h

@@ -22,6 +22,5 @@ class APP_EXPORT QgsMapToolAddRing: public QgsMapToolCapture
     Q_OBJECT
   public:
     QgsMapToolAddRing( QgsMapCanvas *canvas );
-    virtual ~QgsMapToolAddRing();
     void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
 };

src/app/qgsmaptoolannotation.cpp

@@ -39,10 +39,6 @@ QgsMapToolAnnotation::QgsMapToolAnnotation( QgsMapCanvas *canvas )
   mCursor = QCursor( Qt::ArrowCursor );
 }
 
-QgsMapToolAnnotation::~QgsMapToolAnnotation()
-{
-}
-
 QDialog *QgsMapToolAnnotation::createItemEditor( QgsMapCanvasAnnotationItem *item )
 {
   if ( !item || !item->annotation() )

src/app/qgsmaptoolannotation.h

@@ -30,7 +30,6 @@ class APP_EXPORT QgsMapToolAnnotation: public QgsMapTool
 
   public:
     QgsMapToolAnnotation( QgsMapCanvas *canvas );
-    ~QgsMapToolAnnotation();
 
     void canvasPressEvent( QgsMapMouseEvent *e ) override;
     void canvasReleaseEvent( QgsMapMouseEvent *e ) override;

src/app/qgsmaptoolchangelabelproperties.cpp

@@ -25,10 +25,6 @@ QgsMapToolChangeLabelProperties::QgsMapToolChangeLabelProperties( QgsMapCanvas *
 {
 }
 
-QgsMapToolChangeLabelProperties::~QgsMapToolChangeLabelProperties()
-{
-}
-
 void QgsMapToolChangeLabelProperties::canvasPressEvent( QgsMapMouseEvent *e )
 {
   deleteRubberBands();

src/app/qgsmaptoolchangelabelproperties.h

@@ -27,7 +27,6 @@ class APP_EXPORT QgsMapToolChangeLabelProperties: public QgsMapToolLabel
 
   public:
     QgsMapToolChangeLabelProperties( QgsMapCanvas *canvas );
-    ~QgsMapToolChangeLabelProperties();
 
     virtual void canvasPressEvent( QgsMapMouseEvent *e ) override;
     virtual void canvasReleaseEvent( QgsMapMouseEvent *e ) override;

src/app/qgsmaptoolcircularstringcurvepoint.cpp

@@ -27,10 +27,6 @@ QgsMapToolCircularStringCurvePoint::QgsMapToolCircularStringCurvePoint( QgsMapTo
 
 }
 
-QgsMapToolCircularStringCurvePoint::~QgsMapToolCircularStringCurvePoint()
-{
-}
-
 void QgsMapToolCircularStringCurvePoint::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
 {
   QgsPoint mapPoint( e->mapPoint() );

src/app/qgsmaptoolcircularstringcurvepoint.h

@@ -25,7 +25,6 @@ class QgsMapToolCircularStringCurvePoint: public QgsMapToolAddCircularString
 
   public:
     QgsMapToolCircularStringCurvePoint( QgsMapToolCapture *parentTool, QgsMapCanvas *canvas, CaptureMode mode = CaptureLine );
-    ~QgsMapToolCircularStringCurvePoint();
 
     void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
     void cadCanvasMoveEvent( QgsMapMouseEvent *e ) override;

src/app/qgsmaptoolcircularstringradius.cpp

@@ -35,11 +35,6 @@ QgsMapToolCircularStringRadius::QgsMapToolCircularStringRadius( QgsMapToolCaptur
 
 }
 
-QgsMapToolCircularStringRadius::~QgsMapToolCircularStringRadius()
-{
-
-}
-
 void QgsMapToolCircularStringRadius::deactivate()
 {
   deleteRadiusSpinBox();

src/app/qgsmaptoolcircularstringradius.h

@@ -27,7 +27,6 @@ class QgsMapToolCircularStringRadius: public QgsMapToolAddCircularString
     Q_OBJECT
   public:
     QgsMapToolCircularStringRadius( QgsMapToolCapture *parentTool, QgsMapCanvas *canvas, CaptureMode mode = CaptureLine );
-    ~QgsMapToolCircularStringRadius();
 
     virtual void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
     virtual void cadCanvasMoveEvent( QgsMapMouseEvent *e ) override;

src/app/qgsmaptoolfeatureaction.cpp

@@ -43,10 +43,6 @@ QgsMapToolFeatureAction::QgsMapToolFeatureAction( QgsMapCanvas *canvas )
 {
 }
 
-QgsMapToolFeatureAction::~QgsMapToolFeatureAction()
-{
-}
-
 void QgsMapToolFeatureAction::canvasMoveEvent( QgsMapMouseEvent *e )
 {
   Q_UNUSED( e );

src/app/qgsmaptoolfeatureaction.h

@@ -35,8 +35,6 @@ class APP_EXPORT QgsMapToolFeatureAction : public QgsMapTool
   public:
     QgsMapToolFeatureAction( QgsMapCanvas *canvas );
 
-    ~QgsMapToolFeatureAction();
-
     virtual Flags flags() const override { return QgsMapTool::AllowZoomRect; }
 
     //! Overridden mouse move event

src/app/qgsmaptoolfillring.cpp

@@ -31,10 +31,6 @@ QgsMapToolFillRing::QgsMapToolFillRing( QgsMapCanvas *canvas )
 {
 }
 
-QgsMapToolFillRing::~QgsMapToolFillRing()
-{
-}
-
 void QgsMapToolFillRing::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
 {
   //check if we operate on a vector layer

src/app/qgsmaptoolfillring.h

@@ -25,7 +25,6 @@ class APP_EXPORT QgsMapToolFillRing: public QgsMapToolCapture
     Q_OBJECT
   public:
     QgsMapToolFillRing( QgsMapCanvas *canvas );
-    virtual ~QgsMapToolFillRing();
     void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
 
   private:

src/app/qgsmaptoolformannotation.cpp

@@ -27,11 +27,6 @@ QgsMapToolFormAnnotation::QgsMapToolFormAnnotation( QgsMapCanvas *canvas ): QgsM
 
 }
 
-QgsMapToolFormAnnotation::~QgsMapToolFormAnnotation()
-{
-
-}
-
 QgsAnnotation *QgsMapToolFormAnnotation::createItem() const
 {
   return new QgsFormAnnotation();

src/app/qgsmaptoolformannotation.h

@@ -27,7 +27,6 @@ class APP_EXPORT QgsMapToolFormAnnotation: public QgsMapToolAnnotation
 
   public:
     QgsMapToolFormAnnotation( QgsMapCanvas *canvas );
-    ~QgsMapToolFormAnnotation();
 
   protected:
     QgsAnnotation *createItem() const override;

src/app/qgsmaptoolhtmlannotation.cpp

@@ -27,11 +27,6 @@ QgsMapToolHtmlAnnotation::QgsMapToolHtmlAnnotation( QgsMapCanvas *canvas ): QgsM
 
 }
 
-QgsMapToolHtmlAnnotation::~QgsMapToolHtmlAnnotation()
-{
-
-}
-
 QgsAnnotation *QgsMapToolHtmlAnnotation::createItem() const
 {
   return new QgsHtmlAnnotation();

src/app/qgsmaptoolhtmlannotation.h

@@ -27,7 +27,6 @@ class APP_EXPORT QgsMapToolHtmlAnnotation: public QgsMapToolAnnotation
 
   public:
     QgsMapToolHtmlAnnotation( QgsMapCanvas *canvas );
-    ~QgsMapToolHtmlAnnotation();
 
   protected:
     QgsAnnotation *createItem() const override;

src/app/qgsmaptoolmovelabel.cpp

@@ -29,10 +29,6 @@ QgsMapToolMoveLabel::QgsMapToolMoveLabel( QgsMapCanvas *canvas )
   mToolName = tr( "Move label" );
 }
 
-QgsMapToolMoveLabel::~QgsMapToolMoveLabel()
-{
-}
-
 void QgsMapToolMoveLabel::canvasPressEvent( QgsMapMouseEvent *e )
 {
   deleteRubberBands();

src/app/qgsmaptoolmovelabel.h

@@ -28,7 +28,6 @@ class APP_EXPORT QgsMapToolMoveLabel: public QgsMapToolLabel
 
   public:
     QgsMapToolMoveLabel( QgsMapCanvas *canvas );
-    ~QgsMapToolMoveLabel();
 
     virtual void canvasPressEvent( QgsMapMouseEvent *e ) override;
 

src/app/qgsmaptoolreshape.cpp

@@ -29,10 +29,6 @@ QgsMapToolReshape::QgsMapToolReshape( QgsMapCanvas *canvas )
 {
 }
 
-QgsMapToolReshape::~QgsMapToolReshape()
-{
-}
-
 void QgsMapToolReshape::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
 {
   //check if we operate on a vector layer //todo: move this to a function in parent class to avoid duplication

src/app/qgsmaptoolreshape.h

@@ -26,7 +26,6 @@ class APP_EXPORT QgsMapToolReshape: public QgsMapToolCapture
 
   public:
     QgsMapToolReshape( QgsMapCanvas *canvas );
-    virtual ~QgsMapToolReshape();
     void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
 };
 

src/app/qgsmaptoolrotatefeature.cpp

@@ -78,10 +78,6 @@ QgsAngleMagnetWidget::QgsAngleMagnetWidget( const QString &label, QWidget *paren
   setFocusProxy( mAngleSpinBox );
 }
 
-QgsAngleMagnetWidget::~QgsAngleMagnetWidget()
-{
-}
-
 void QgsAngleMagnetWidget::setAngle( double angle )
 {
   const int magnet = mMagnetSpinBox->value();

src/app/qgsmaptoolrotatefeature.h

@@ -34,8 +34,6 @@ class APP_EXPORT QgsAngleMagnetWidget : public QWidget
 
     explicit QgsAngleMagnetWidget( const QString &label = QString(), QWidget *parent = nullptr );
 
-    ~QgsAngleMagnetWidget();
-
     void setAngle( double angle );
 
     double angle();

src/app/qgsmaptoolsplitfeatures.cpp

@@ -29,11 +29,6 @@ QgsMapToolSplitFeatures::QgsMapToolSplitFeatures( QgsMapCanvas *canvas )
   mToolName = tr( "Split features" );
 }
 
-QgsMapToolSplitFeatures::~QgsMapToolSplitFeatures()
-{
-
-}
-
 void QgsMapToolSplitFeatures::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
 {
   //check if we operate on a vector layer