45877 Commits

Author SHA1 Message Date
Juergen E. Fischer
aa8b629682 osgeo4w: remove explicit setting of QGISDEBUG 2018-02-15 08:54:43 +01:00
Nyall Dawson
46dc2f6e5b [processing] Avoid losing static, user-entered parameter values
in model child algorithms

Prior to this change if you edited an algorithm in a model and
tried to enter a preset string for certain parameter types, this
string would get silently discarded on closing the dialog. E.g.
with a dissolve algorithm it was not possible to have a fixed
field name within the model to dissolve by.

This was caused by WidgetWrapper.comboValue  returning the customData
for these manually entered values in the parameters combo box,
yet manually entered values never have custom data.

To work around this we only return the custom data if its
set for the selected item - otherwise we return the text unchanged.
In order to handle the "[not set]" options, a new static custom
data value of WidgetWrapper.NOT_SET_OPTION is added to that
comboValue can detect this and return the appropriate None value.
2018-02-15 17:45:19 +11:00
Nyall Dawson
12fcfac0d5 [processing] Ensure algorithms which add attributes to features
always add a consistent amount of attributes regardless of the
code paths taken

Some algorithms were adding features to data providers with
different number of attributes vs the layer's fields - this is
not supported and depending on the data provider will have
different (bad) results.
2018-02-15 17:45:00 +11:00
Nyall Dawson
a8110369a8 [processing] Don't throw an exception if an expression cannot
be prepared

There's cases where this happens without reflecting an invalid
expression. So we can try to prepare, but not abort if the
preparation fails.

Fixes #18103
2018-02-15 15:43:26 +11:00
nirvn
e0b1d37cac [ui] sort items in the view > panels sub-menu 2018-02-15 11:43:19 +07:00
nirvn
8697c79993 [needs-docs][ui] harmonize title of panels 2018-02-15 11:43:19 +07:00
Nyall Dawson
bc23f1d677 Ensure QgsMapLayer private QObject members are correctly parented
to the layer
2018-02-15 12:11:01 +11:00
Nyall Dawson
2defaff796 [processing] Much faster random points in polygon by using
prepared geometries
2018-02-15 09:14:01 +11:00
Nyall Dawson
81aa2f956e [processing] Misc fixes and improvements to Random Points in Polygons
- Fix missing format call for string when calculated number
of points is 0
- Fix incorrect progress reports which were spamming the dialog
and causing UI hangs, and slow algorithm execution
2018-02-15 09:14:01 +11:00
Nyall Dawson
e0cf578096 [processing] Add some missing sources to expression contexts 2018-02-15 09:14:01 +11:00
Nyall Dawson
8154a85f29 Fix Python exception in Random Points in Polygon alg
Fixes #18103
2018-02-15 09:14:01 +11:00
Juergen E. Fischer
792c19ba70 nightlies: also submit build errors to dash 2018-02-14 19:20:22 +01:00
Mathieu Pellerin
543e4f0dd1
[attribute table] fix long UI freeze when resizing columns for large filtered datasets (#6341) 2018-02-14 21:25:43 +07:00
mhugent
a817d0e8fb
Merge pull request #6334 from mhugent/dxf_mtext_escape_spaces
Escape blanks in MTEXT and add unit test
2018-02-14 11:05:46 +01:00
Alexander Bruy
b664f12ed6
Merge pull request #6340 from nyalldawson/batch_layer_name
[processing] In batch dialog, use layer names for input layers
2018-02-14 11:06:36 +02:00
Nyall Dawson
8ceb6fc007 [processing] In batch dialog, use layer names for input layers
if they are unique in the current project

Instead of always using the layer id, which is generally
gibberish and meaningless for users, instead prefer to use
the layer name as an input in the batch processing dialog. This
is done only if the name is unique within the current project's
loaded layers.

This change makes the dialog more user-friendly, but more importantly
it means that autofilling output values based on an input layer
parameter generates more meaningful automatic output file names.
2018-02-14 16:46:26 +10:00
Nyall Dawson
5cd452a64d Slightly shift default outline back toward black
Original commit shifted it a bit too light
2018-02-14 16:27:02 +11:00
Nyall Dawson
cd24adbf9e [needs-docs] Rework arrangement of buttons in categories tab in
metadata editor to make their operation more self-explanatory
for users.

Also add tooltips to the buttons describing their function, and
allow the buttons to operate on multiple selected rows at once.

Fixes #18090
2018-02-14 15:35:47 +11:00
nirvn
2d24bbf819 [needs-docs][processing] update raster calculator help to reflect updated logic 2018-02-14 07:43:05 +07:00
Salvatore Larosa
345088c863
Merge pull request #6192 from slarosa/fix_shortcut_macos
Fix displaying keyboard shortcut under macos
2018-02-13 18:09:22 +01:00
Salvatore Larosa
abeef2573c macOS: fix shortcut even for processing tool button 2018-02-13 16:51:04 +01:00
Salvatore Larosa
27cbfafdb5 shortcut config. dialog: display correctly keysequence on macOS 2018-02-13 16:46:42 +01:00
Salvatore Larosa
856dd08a10 display correctly keyboard shortcut in toolbar tooltip under macOS 2018-02-13 16:46:42 +01:00
Marco Hugentobler
256e4419b2 Escape blanks in MTEXT and add unit test 2018-02-13 15:50:42 +01:00
Denis Rouzaud
231dae3124 various fixes to rotation map tool
* do not go through the user input to do the rotation (avoid rounding in spin box, except when magnet is on)
* allow to escape the tool by pressing ESC even when user input lost focus
2018-02-13 10:11:31 -04:00
Denis Rouzaud
77f864b82f fix offset side for polygons 2018-02-13 04:19:48 -09:00
Denis Rouzaud
5d7eb19827 fix invalid value for offset_join_style in main options 2018-02-13 04:19:48 -09:00
Denis Rouzaud
79d224e349 add advanced config to offset map tool widget
fix #14750
2018-02-13 04:19:48 -09:00
Denis Rouzaud
e1d481faa7 various fixes to the offset map tool
code has been refactored, hopefully things are clearer now
fix #17367
fix #14751
2018-02-13 04:19:48 -09:00
nirvn
ca0cb9b868 [ui] resize statistical summary columns to content 2018-02-13 17:45:59 +07:00
mhugent
bf4ba08a40
Merge pull request #6331 from mhugent/dxf_label_layers_v3
Fix dxf export for label layers and add unit test
2018-02-13 10:46:54 +01:00
Harrissou Sant-anna
fc51b82f5c [save as vector] use the save/restore geomtry API 2018-02-13 16:40:07 +07:00
Nyall Dawson
ea40f1e82a More capitalization homogenization 2018-02-13 19:49:15 +11:00
Nyall Dawson
fa56aa5542 [dbmanager] Fix python error when scrolling postgis results
Fixes #17835
2018-02-13 19:49:15 +11:00
Nyall Dawson
ad849615a3 Fix python error when trying to export db manager table 2018-02-13 19:49:15 +11:00
Nyall Dawson
6b4e734d95 [dbmanager] Fix inconsistent capitalization, HIG violations,
and unprofessional strings
2018-02-13 19:49:15 +11:00
Nyall Dawson
c08e4c53a9 Fix invalid (deprecated) escape strings in db manager 2018-02-13 19:49:15 +11:00
Nyall Dawson
70644f1ddd Fix undo stack does not correctly roll back geometry edits
in a granular manner

Fixes #17658
2018-02-13 19:48:43 +11:00
mhugent
c996c61789
Merge branch 'master' into dxf_label_layers_v3 2018-02-13 09:23:05 +01:00
Marco Hugentobler
5c3a7554de Fix dxf export for label layers and add unit test 2018-02-13 08:55:26 +01:00
Nyall Dawson
66b9b435b6 [processing] Fix destination files are silently ignored when relaunching
algorithms from the history panel
2018-02-13 14:24:48 +10:00
nirvn
1994c44644 [processing] harmonize results viewer action behavior 2018-02-13 10:40:17 +07:00
Nyall Dawson
a1a45536a2
Merge pull request #6221 from nyalldawson/var_leak
Fix massive memory leak in PyQGIS, pt 1
2018-02-13 13:18:42 +11:00
Nyall Dawson
0c6f22386b Drop some legacy sip conversion code 2018-02-13 12:02:50 +11:00
Denis Rouzaud
59b17f251a
Merge pull request #6321 from 3nids/dxf_addlayers
[dxf] use a struct instead of QPair for layers
2018-02-12 06:54:19 -09:00
Denis Rouzaud
2a7aeafb75 doxygen, init in header 2018-02-12 11:29:41 -04:00
Alessandro Pasotti
94b644e94a
Merge pull request #6324 from qgis/revert-6320-try-to-fix-collapsible-crash-on-qt510
Revert "Try to fix QgsCollapsibleGroupBox crash on Qt 5.10"
2018-02-12 16:10:20 +01:00
Alessandro Pasotti
03e49f1f65
Revert "Try to fix QgsCollapsibleGroupBox crash on Qt 5.10" 2018-02-12 15:08:34 +01:00
Denis Rouzaud
53f4464b53 [dxf] followup 31e93aecae fix server 2018-02-12 09:48:50 -04:00
Denis Rouzaud
338a73b32e [sip] remove unused QPair conversion 2018-02-12 09:22:53 -04:00