54450 Commits

Author SHA1 Message Date
Martin Dobias
6f92e7cf4b [mssql] More sensible srid when adding CRS to MS SQL database
The spatial_ref_sys table has srid column with ID of CRS entries.
I believe the IDs can be arbitrary, however it has been a good habit
to use EPSG number for srid (at least in GDAL - and the same thing
happens in PostGIS - srid values are the same as EPSG numbers).

In QGIS import if we add a new row to spatial_ref_sys table, the code
was using srsid() as ID which is internal ID in QGIS srs.db and it has
nothing to do with other IDs. Some pieces of code (probably incorrectly)
expect that srid is actually the EPSG number, so let's use those
so that we are consistent with GDAL and fix these minor issues
(for example, tooltip of MS SQL layers in browser show srid - which
in case of layers loaded with QGIS were meaningless)
2019-03-20 20:58:15 +01:00
Rashad Kanavath
46da10a1e8 Revert "fixes #21374: ignore optional output parameters"
This reverts commit af2421541c78742a233b3c5a00cbbd6c11ceaaab.
2019-03-21 04:44:59 +10:00
Rashad Kanavath
91d430a0cb fix travis code_layout test 2019-03-21 04:44:59 +10:00
Rashad Kanavath
e94d9a596a [TEST] add more test on otb segmentation apps
Even though not all errors are caught by these new tests, it could
expose if otb is broken or if processing api is changed to adopt
optional status of parameters at run-time.

`alg.processAlgorithm()` is running and failing correctly.
But `parameter.checkValueIsAcceptable()` and `alg.checkParameterValues()`
aren't working as expected.
2019-03-21 04:44:59 +10:00
Rashad Kanavath
0b86110ccd report warnings as non fatal errors through Feedback 2019-03-21 04:44:59 +10:00
Rashad Kanavath
c763b9229b fix #21373 #21374: handle update optional status based on user-input
Parameters are marked required in descriptor file for certian
applications but they are only required if a parent parameter has a
"certain" value. So initial idea was to make all of those parameters
optional from OTB part. So that qgis can work correctly and was a easy
fix. But.. we (me and Antonie) decided not to take that route and
found a better fix.

`OtbParameterChoice` and its wrapper will update optional status of
all sub-parameters depending on the value of a choice parameter.

A test has been added to check this issue and will be available in
next commit.
2019-03-21 04:44:59 +10:00
Rashad Kanavath
f6ad4745bd fixes #21374: ignore optional output parameters 2019-03-21 04:44:59 +10:00
Rashad Kanavath
f1cc8aa108 bug: check for empty string in parameter values 2019-03-21 04:44:59 +10:00
Rashad Kanavath
d3a1c65368 Remove OtbSettings class and put constants for key names in OtbUtils 2019-03-21 04:44:59 +10:00
Rashad Kanavath
07d17a0f17 This commits fixes encoding issue on windows.
getWindowsCodePage is taken from Grass7Utils.py

Instead of writing a cli_file at startup, provider now pass all
required env_variables directly to subprocess.popen. This has known to
cause issues when handling with windows path names. subprocess.Popen
handles it correctly depending on platform

Logging of output from otbalgorithm and updating progress bar is
slightly updated.
Algoirthm is now launched directly using otbApplicationLauncherCommandLine
`encoding` (on windows) and env arguments passed to subprocess is
logged in QgsMessageLog
2019-03-21 04:44:59 +10:00
Martin Dobias
f85d494303
Merge pull request #9549 from wonder-sk/online-3d-terrain
[3d] Add option to use terrain data from online service
2019-03-20 13:48:27 +01:00
Matthias Kuhn
13a74ae962
Merge pull request #9320 from m-kuhn/geometry-validation-icons
Geometry validation icons
2019-03-20 11:58:28 +01:00
Martin Dobias
1010522877 Use user data in terrain combo boxes, fix max zoom level calc 2019-03-20 11:55:48 +01:00
rldhont
638650a5a2
Merge pull request #9525 from rldhont/fix-server-getprint-jpg
[Server] JPEG output for WMS GetPrint request has gone
2019-03-20 10:37:45 +01:00
Nyall Dawson
5653289085 Fix capitalization, clearer wording 2019-03-20 19:02:44 +10:00
Alessandro Pasotti
567da1bd79
Merge pull request #9563 from elpaso/bugfix-unreported-raster-crash-on-bad-layers
Fix crash when opening layer properties on a bad raster layer
2019-03-20 07:52:00 +01:00
Sandro Mani
ba416d2eef
Merge pull request #9527 from manisandro/master
Misc crash fixes
2019-03-20 00:05:53 +01:00
Juergen E. Fischer
ab340f2de4 fix windows build 2019-03-19 22:14:48 +01:00
Nyall Dawson
8cff94190d [processing] Fix QgsProcessingProvider::isSupportedOutputValue handling
of optional output parameters

Refs #21374
2019-03-20 06:01:15 +10:00
Nyall Dawson
a963eaad54 Fix crash when grass provider is not available
Fixes #21604
2019-03-20 06:00:54 +10:00
Nyall Dawson
7fadfbf2de Remove another use of deprecated QgsCoordinateTransform constructor
Sponsored by ICSM
2019-03-20 06:00:27 +10:00
Nyall Dawson
9182ca3d3d Use correct project transform context in transform expression function
Sponsored by ICSM
2019-03-20 06:00:27 +10:00
Juergen E. Fischer
a7a851727c mdal: fix typo 2019-03-19 20:48:24 +01:00
Juergen E. Fischer
e868d07f58 debian packaging: move qgis.core.additions to python3-qgis-common 2019-03-19 20:48:24 +01:00
Sandro Mani
0360b45743 [Bugfix] Return false from QgsVectorLayer::setDataProvider if provider is not valid 2019-03-19 16:22:18 +01:00
Sandro Mani
0996c93d09 [Bugfix] Ensure order by attribute indices are valid 2019-03-19 16:22:18 +01:00
Alessandro Pasotti
aeba867832 Fix crash when opening layer propertie on a bad raster layer
unreported

... and hit apply after changing the renderer or the
transparency.
2019-03-19 16:05:40 +01:00
Alessandro Pasotti
61b2f91155
Merge pull request #9550 from elpaso/bugfix-21387-bad-layers-keep-group-and-status
Keep group and checked state when handling bad layers
2019-03-19 15:55:07 +01:00
Martin Dobias
3032a65317 Add tests, fix issues from review, customizable terrain downloader 2019-03-19 15:29:55 +01:00
Juergen E. Fischer
3630fdc4a1 fix cmake warning 2019-03-19 14:47:25 +01:00
rldhont
547fd683d9 [Bugfix][Regression][Server] JPEG output for WMS GetPrint request has gone
In QGIS Server 2.* the WMS GetPrint request could genrate JPEG image. QGIS Server 3.4 has lost this capabilities.
```
<ServiceExceptionReport xmlns="http://www.opengis.net/ogc" version="1.3.0" capture-installed="true">
    <ServiceException code="InvalidFormat">
        Output format jpg is not supported by the GetPrint request
    </ServiceException>
</ServiceExceptionReport>
```
To fix this regression, it is necessary to accept JPEG output format.

And to avoid this regression to come back, the QGIS Server tests has been updated to accept jpg image test.
2019-03-19 10:18:49 +01:00
Blottiere Paul
1e8aec45a0
Merge pull request #9385 from pblottiere/server_external_clean
[server] Update external layer management
2019-03-19 08:59:00 +01:00
Harrissou Sant-anna
477ec2a79e Align Mesh property tab name with other data types
using "Symbology" instead of "Style"
2019-03-19 08:28:44 +01:00
Alessandro Pasotti
5bc2183d24 Keep group and checked state when handling bad layers
Fixes #21387 - Unavailable layers because of a moved folder
2019-03-19 08:22:34 +01:00
Matthias Kuhn
366d05ad1a
Merge pull request #9432 from tudorbarascu/constraint_description
always show constraints description, not only when they fail
2019-03-19 08:19:45 +01:00
Peter Petrik
de80192f53 upgrade MDAL to 0.3.0 2019-03-19 08:06:04 +01:00
Nyall Dawson
24a1e8ef53 Capitalization, tooltips 2019-03-19 13:32:13 +10:00
Nyall Dawson
c8d15d61ce Only enable edit datum transform button when a transform is selected
Sponsored by ICSM
2019-03-19 13:32:13 +10:00
Nyall Dawson
8a1ba51631 Fix warnings 2019-03-19 13:32:13 +10:00
Nyall Dawson
f0f825ac99 Fix datum transform dialog sometimes does not correct respond
to changes in the available transform table

Sponsored by ICSM
2019-03-19 13:32:13 +10:00
Nyall Dawson
eab08d006c Do not allow CRS changes in datum transform dialog when it has
been shown as a result of requiring the transform for a specific CRS pair

Sponsored by ICSM
2019-03-19 13:32:13 +10:00
Nyall Dawson
c534cc4839 Expose method for generating CRS widget text 2019-03-19 13:32:13 +10:00
Nyall Dawson
b42b348bf8 Datum transform table should not be editable 2019-03-19 13:32:13 +10:00
Nyall Dawson
df9db1fb3a Some code modernization 2019-03-19 13:32:13 +10:00
Nyall Dawson
593f55f338 Fix incorrect cursors shown in datum transform select dialog 2019-03-19 13:32:13 +10:00
Nyall Dawson
e10d13ff96 Dox 2019-03-19 13:32:13 +10:00
Nyall Dawson
5fb9802229 New utility class QgsTemporaryCursorRestoreOverride
This class temporarily removes ALL cursor overrides for the
QApplication for the lifetime of the object, and restores them
(in the same order) upon object destruction.
2019-03-19 13:32:13 +10:00
Nyall Dawson
6bb0723503 Capitalization, code style 2019-03-19 13:32:13 +10:00
Nyall Dawson
45ae2ed630 Fix a clazy warning 2019-03-19 13:32:13 +10:00
Nyall Dawson
9de67c8871 Highlight deprecated transformations in red
Another way to dissuade users from mistakenly choosing these
transformations

Sponsored by ICSM
2019-03-19 13:32:13 +10:00