59332 Commits

Author SHA1 Message Date
Nyall Dawson
4991a27ddb Use correct message box icons in custom projection alerts 2019-12-17 11:59:40 +10:00
Nyall Dawson
308eae9a33 Allow deleting multiple custom projections at once 2019-12-17 11:59:40 +10:00
Nyall Dawson
10e0910557 Update a test result for proj 6 2019-12-17 11:58:55 +10:00
Nyall Dawson
3efae69f10 Add test results for proj < 6 2019-12-17 11:58:55 +10:00
Nyall Dawson
4275e7d12f Refine logic relating to syncing project ellipsoid choice to CRS selections
in project properties dialog

Keep the existing logic which dictates that we should never overwrite
a user-set "NO ellipsoid" setting when the project CRS is changed, BUT
add a condition that if the project goes from NO CRS to A CRS, we
DO sync the ellipsoid choice for that first change only and overwrite
the default NO ellipsoid which is forced for projects with no crs.

Add unit tests to protect this logic, and hopefully see the last of
this crappy fragile dialog handling...

Fixes #33358
2019-12-17 11:58:55 +10:00
Nyall Dawson
5375fdf58c Fix loss of crs set for QgsProjectionSelectionWidget if widget is never
shown, fix missing signals and duplicate signals
2019-12-17 11:58:55 +10:00
Nyall Dawson
1dde86a70e Remove some unused/empty code 2019-12-17 11:58:55 +10:00
Nyall Dawson
c2441caa9b Ensure output of QgsCoordinateReferenceSystem::ellipsoidAcronym() matches
the acronyms and format user in QgsEllipsoidUtils

Refs #33358
2019-12-17 11:58:55 +10:00
Nyall Dawson
c7ee6e93a6 remove_temporary_files should also remove .temp files 2019-12-17 11:58:55 +10:00
Nyall Dawson
296f78f3b8 Update test results to reflect proj master 2019-12-17 11:58:55 +10:00
Nyall Dawson
a0280f7cb5 Update test result for proj 6 2019-12-17 11:58:55 +10:00
Nyall Dawson
24d773c8e0 Add unit tests that project ellipsoid survives the trip through the project properties dialog
(test needs adapting for proj 6)
2019-12-17 11:58:55 +10:00
Nyall Dawson
2cc64f9cc7 Fix initial selection in project ellipsoid list is reset whenever the dialog
is reopened

Refs #33358
2019-12-17 11:58:55 +10:00
Matthias Kuhn
78ad518e9a
Merge pull request #33427 from m-kuhn/fix_crash_with_invalid_raster_layer
Fix crash with invalid layer
2019-12-16 21:44:54 +01:00
Matthias Kuhn
8e791807e4 Fix crash with invalid layer 2019-12-16 16:36:08 +01:00
Matthias Kuhn
3a4b976a28
Merge pull request #33418 from m-kuhn/azure-mask-more-tests
Mask some more flaky tests
2019-12-16 15:22:57 +01:00
Matthias Kuhn
b42a31ec2f
Merge pull request #32472 from troopa81/feature_selectionwidget_in_featureselectiondialog
Selection widget in feature selection dialog
2019-12-16 11:32:25 +01:00
Julien Cabieces
a8f46ac655 update sip 2019-12-16 09:55:30 +01:00
Matthias Kuhn
ebb023662d Mask some more flaky tests 2019-12-16 09:38:44 +01:00
Matthias Kuhn
3b4437bcf8
Merge pull request #33333 from lbartoletti/expression-is_empty
Add expressions is_empty(geom)  is_empty_or_null(geom)
2019-12-16 08:06:58 +01:00
lbartoletti
c7fca820e5
Update resources/function_help/json/is_empty
Co-Authored-By: Matthias Kuhn <matthias@opengis.ch>
2019-12-16 06:32:23 +01:00
Harrissou Sant-anna
c235c4c195 [needs-docs] Add precision to rotate marker checkbox
and harmonize with hash line symbol layer dialog
2019-12-16 12:48:37 +10:00
Alessandro Pasotti
6df6bd10c4 Drop "by value" from select window title 2019-12-16 12:37:37 +10:00
Alessandro Pasotti
39747482e2 Select features by value: show layer name in window title
Fixes #33210
2019-12-16 12:37:37 +10:00
Nyall Dawson
235fee19ec Don't highlight whole polygon in red when using map label tools
For polygons, we don't want to fill the whole polygon itself with
the rubber band as that obscures too much of the map and prevents
users from getting a good view of the underlying map.

Instead, just use the boundary of the polygon for the rubber band.
That's enough to give a visual indicator of the feature associated
with the label without getting in the way.
2019-12-16 11:14:08 +10:00
Borys Jurgiel
dbdc397fd8 [DB Manager] Fix broken geometry type of GeoPackage based SQL Layers. Fixes #33232 2019-12-16 10:08:44 +10:00
Nyall Dawson
0d84e35839 Update test images 2019-12-15 10:18:47 +10:00
Nyall Dawson
2e3b57a360 [pal] Don't reuse spatial index for two different purposes
This forces many removals/additions to the existing index, which
we can avoid by just using a seperate index in the first place
2019-12-15 10:18:47 +10:00
Nyall Dawson
1929c53bf4 Avoid some unnecessary heap allocations 2019-12-15 10:18:47 +10:00
Nyall Dawson
c23565287a [pal] Only truncate the feature candidate list after we've pruned all hard conflicts
Avoids throwing away potentially good candidates too early
2019-12-15 10:18:47 +10:00
Nyall Dawson
da5cd52162 [pal] Bring back refined upstream version of superliminal rtree index
Turns out this index is MUCH (magnitudes) faster for use in pal. So
grab an updated version of the upstream library and place in external libs,
and use this for indices in pal.

(we should probably investigate whether this is faster for snapping and
other index use too!)
2019-12-15 10:18:47 +10:00
Alessandro Pasotti
7464290ae3
Merge pull request #33379 from elpaso/widget-dependencies-move-to-formatter
Move layerDependencies to formatter
2019-12-14 09:00:08 +01:00
Nyall Dawson
40b198cf90 Correctly skip ProcessingQgisAlgorithmsTestPt1 on azure builds 2019-12-14 08:21:20 +10:00
Nyall Dawson
db2ac240de Add some references hashes seen on azure builds 2019-12-14 08:20:15 +10:00
Alessandro Pasotti
33b1bec927
Merge pull request #33391 from elpaso/bugfix-gh33390-html-form-wodget-crash
Don't crash on QgsHtmlWidgetWrapper
2019-12-13 22:36:01 +01:00
Alexander Bruy
fba3ab99a0
Merge pull request #33368 from alexbruy/processing-updates
Processing updates
2019-12-13 21:59:08 +02:00
Nyall Dawson
cf95f1452e Fix another test under proj6 2019-12-14 05:33:59 +10:00
Nyall Dawson
da92b3fe8d Fix another test under proj 6 2019-12-14 05:33:59 +10:00
Nyall Dawson
526963efb2 Fix a test under proj 6 2019-12-14 05:33:59 +10:00
Nyall Dawson
05eaa65737 Fix transform differences vs proj < 6 when using custom CRS via proj definition
By being more selective about when we force convert to a single crs

Fixes #32928
2019-12-14 05:33:59 +10:00
Nyall Dawson
9be6b333d0 Fix build 2019-12-14 05:33:59 +10:00
Nyall Dawson
51046d98f6 Fix incorrect reverse coordinate transforms are created when using a
PROJ 6+ build and a project has manual coordinate operation pathways
set

Refs #33121
2019-12-14 05:33:59 +10:00
Nyall Dawson
a1ac77877f Add a method to determine if the coordinate operation string returned
by QgsCoordinateTransformContext.calculateCoordinateOperation corresponds
to the reverse of what's actually required.

Gross API, but it's the best we can do until proj has a method to
invert a coordinate operation so that we can return the proper
inverse operation proj string from calculateCoordinateOperation
(without resorting to fragile proj string parsing/mangling)
2019-12-14 05:33:59 +10:00
Nyall Dawson
ef19797997 Add method to retrieve the details of the coordinate operation which is
actually being used by a QgsCoordinateTransform object
2019-12-14 05:33:59 +10:00
Nyall Dawson
82a84ffd0d Don't try to normalize proj coordinate operations constructed directly
from the proj string via the transform context

This isn't possible -- only proj coordinate operations constructed
from a src/dest CRS pair can be normalized, not those constructed
from a proj string.

It was redundant in any case, since we always normalize the available
operations before giving users a choice of them.

So just add some big bold warnings to the dox in case anyone is
manually manipulating and adding custom operations, that these
also MUST be pre-normalized

Refs #33121, conversation in https://github.com/OSGeo/PROJ/issues/1794
2019-12-14 05:33:59 +10:00
Nyall Dawson
8994a4b994 Update test results for proj < 6 2019-12-14 05:32:55 +10:00
Nyall Dawson
8de83c5133 When saving and restoring CRS definitions to XML, save wkt
definition too, and prefer rebuilding the CRS from the WKT
definition whenever it's available

Proj strings are lossy, so prefer WKT
2019-12-14 05:32:55 +10:00
Peter Petrik
6e2ef1544f push MDAL 0.4.93 RC1 for 3.12 release with fixed bug in reading of reference time 2019-12-14 05:31:53 +10:00
Julien Cabieces
7dbf8c8ea0 Update src/core/qgsvectorlayerutils.h
improve comment message

Co-Authored-By: Matthias Kuhn <matthias@opengis.ch>
2019-12-13 18:03:17 +01:00
Julien Cabieces
0f20ddbf9d delete dialog on close 2019-12-13 18:00:29 +01:00