19 Commits

Author SHA1 Message Date
Zsolt Parragi
0a451edbcc Removing the pg_tde_global enum
As this causes issues with overload resolution, this commit instead
separates global and local key handling into differently named
functions. From now on, functions that deal with global keys have
"global" in the name.
2025-02-17 12:12:36 +00:00
Andreas Karlsson
747d93f039 Do not create extra database in configure-tde-server.sh
The postgres database is good enough for this use.
2025-02-17 11:46:29 +01:00
Andreas Karlsson
4e848ea9f4 Simplify logic for stopping the server in configure-tde-server.sh
I run multiple instances of PostgreSQL on my machine so I would rather
not have it rely on using pgrep to detect if the server is running.

To make this new code more reliable we add set -e so the script aborts
directly e.g. if the port is already in use.
2025-02-17 11:46:29 +01:00
Andreas Karlsson
c35778b45b Improve how we set GUCs in configure-tde-server.sh
To simplify the code we first use --set at initdb tine and then only
use ALTER SYSTEM for GUCs we need to set after initdb.
2025-02-17 11:46:29 +01:00
Andreas Karlsson
a3fde4e52d Quote shell variables in configure-tde-server.sh 2025-02-17 11:46:29 +01:00
Shahid Ullah
43f4804ba5
[PG-938] Bash script to verify backup/restore functionality using pg_basebackup (#63)
* [PG-938] - Add automated bash script to verify pg_tde backup/restore functionality using pg_basebackup
* [PG-1367] Create separate script for server and tde configuration
2025-02-13 19:23:49 +05:00
Andreas Karlsson
7266847592 Sync development dependecies in Github Actions with offical package
New dependencies have been added since we last updated this list, e.g.
zstd and icu. And additionally we just fix diffs where Ubuntu packages
have been renamed or the official package thinks we should install
some package.
2025-02-12 16:01:38 +01:00
Andreas Karlsson
5b55af8279 Do not install ninja-build directly
It is a dependency of meson so we only need to install meson.
2025-02-12 16:01:38 +01:00
Andreas Karlsson
71bac8ded6 Do not de-armor key used by apt
Apt does not require keys to be de-armored if they use the correct
extension. Additional put the key in the directory recommended by
Debian and Ubuntu.
2025-02-12 16:01:38 +01:00
Andreas Karlsson
0c410a6cb1 List Github worker dependencies in a nicer way
By not having everything on one line it is easier to see what we
actually install and why.
2025-02-12 16:01:38 +01:00
Andreas Karlsson
65ab529e6b Use apt instead of apt-get in Github scripts
The apt executable gives the following warning.

    WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
2025-02-12 16:01:38 +01:00
Andreas Karlsson
88eb65a4fa Do not install any CI packages from CPAN
Run::IPC is already installed via APT and Text::Trim does not seem
like it is even used. While at it we update the comment.
2025-02-05 22:11:14 +01:00
Andreas Karlsson
2c54d8213c Stop downloading duplicate KMIP policy files in CI
There is no reason to download two versions of the same KMIP policy
file for the CI tests. Either file should be good.
2025-02-05 22:11:14 +01:00
Andreas Karlsson
d60abd33ea Remove pointless trailing slashes in paths in CI scripts 2025-02-05 22:11:14 +01:00
Andreas Karlsson
2a3bd28fdd Add missing bash shebangs to CI scripts 2025-02-05 22:11:14 +01:00
Andreas Karlsson
7f464a5cbe Make whitespace of CI scripts consistent 2025-02-05 22:11:14 +01:00
Zsolt Parragi
f22350ce22
PG-1002: WAL encryption requires explicit configuration (#36)
Instead of automatically creating a default keyring, from now on
we require users to expicitly create a WAL key. Most of these
steps were required even without change anyway, as the default
configuration was highly unsecore.

This eliminates the possiblity of users forgetting to change the
unsecure default, ending up with an encryption that doesn't work
in practice.

The required steps are outlined in the new tap test, that tries
to enable wal encryption:

* Enable the extension in at least one database
* Create a global key provider
* Create a global principal key
* Create the WAL key using the new `pg_tde_create_wal_key()` function
* Set `pg_tde.wal_encrypt = 1` in the conf file or with `ALTER SYSTEM`
* Restart the server

Setting the GUC variable to ON without the previous steps results
in the startup failing with an error message explaining the requirements.
2025-02-03 16:45:05 +00:00
Zsolt Parragi
4842a99090 Added scripts and github CI action for formatting / format checking 2025-01-22 18:46:32 +00:00
Zsolt Parragi
5e3f82c785
Fixing issues with running installcheck-world with pg_tde (#31)
* The make CI action now also runs the entire installcheck-world
  with pg_tde setup for all tests
* The meson CI runner doesn't do this yet
* Tools that only worked with the heap am based on an OID check now
  also check for the tde_heap OID
* The get_tde_table_am_oid helper function is now moved inside the core,
  as it is required by other contrib modules, which do not have access
  to the tde code otherwise.
* A few tests that do a custom server setup was disabled based on the
  TDE_MODE environment variable. These tests would fail because they
  expect that after an initdb and start, the regression suite works,
  but that's not the case with tde_heap. These tests can be re-enabled
  again after we have options to do this with initdb
2025-01-22 17:32:24 +00:00