sharpetronics/zstd
1
0
Fork 0
mirror of https://github.com/facebook/zstd.git synced 2025-10-10 00:03:36 -04:00
Code Issues Projects Releases Wiki Activity

Removing implicit conversion from const void* to const BYTE* and added constant for threshold

Browse Source
This commit is contained in:
bimbashrestha 2019-08-26 08:51:34 -07:00
parent 0e3ba02cf1
commit ba46932492
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/compress/zstd_compress.c
View File

@ -2278,6 +2278,12 @@ static size_t ZSTD_compressBlock_internal(ZSTD_CCtx* zc,
void* dst, size_t dstCapacity, void* dst, size_t dstCapacity,
const void* src, size_t srcSize) const void* src, size_t srcSize)
{ {
/*
This the upper bound for the length of an rle block.
This isn't the actual upper bound. Finding the real threshold
needs further investigation.
*/
const int rleMaxLength = 25;
size_t cSize; size_t cSize;
const BYTE* ip = (const BYTE*)src; const BYTE* ip = (const BYTE*)src;
BYTE* op = (BYTE*)dst; BYTE* op = (BYTE*)dst;
@ -2299,7 +2305,7 @@ static size_t ZSTD_compressBlock_internal(ZSTD_CCtx* zc,
zc->entropyWorkspace, HUF_WORKSPACE_SIZE /* statically allocated in resetCCtx */, zc->entropyWorkspace, HUF_WORKSPACE_SIZE /* statically allocated in resetCCtx */,
zc->bmi2); zc->bmi2);
if (cSize < 10 && ZSTD_isRLE(ip, srcSize)) { if (cSize < rleMaxLength && ZSTD_isRLE(ip, srcSize)) {
cSize = 1; cSize = 1;
op[0] = ip[0]; op[0] = ip[0];
} }
@ -2311,7 +2317,7 @@ out:
zc->blockState.prevCBlock = zc->blockState.nextCBlock; zc->blockState.prevCBlock = zc->blockState.nextCBlock;
zc->blockState.nextCBlock = tmp; zc->blockState.nextCBlock = tmp;
assert(!ZSTD_isRLE(src, srcSize)); assert(!ZSTD_isRLE(ip, srcSize));
} }
/* We check that dictionaries have offset codes available for the first /* We check that dictionaries have offset codes available for the first
* block. After the first block, the offcode table might not have large * block. After the first block, the offcode table might not have large