removed unnecessary checks for null pointer on free

This commit is contained in:
Paul Cruz 2017-07-05 09:37:52 -07:00
parent a47ebb1607
commit 9a147d8671

View File

@ -98,8 +98,8 @@ static void freeCompressionJobs(adaptCCtx* ctx)
unsigned u; unsigned u;
for (u=0; u<ctx->numJobs; u++) { for (u=0; u<ctx->numJobs; u++) {
jobDescription job = ctx->jobs[u]; jobDescription job = ctx->jobs[u];
if (job.dst.start) free(job.dst.start); free(job.dst.start);
if (job.src.start) free(job.src.start); free(job.src.start);
} }
} }
@ -237,8 +237,8 @@ static int createCompressionJob(adaptCCtx* ctx, BYTE* data, size_t srcSize)
if (!job->src.start || !job->dst.start) { if (!job->src.start || !job->dst.start) {
/* problem occurred, free things then return */ /* problem occurred, free things then return */
DISPLAY("Error: problem occurred during job creation\n"); DISPLAY("Error: problem occurred during job creation\n");
if (job->src.start) free(job->src.start); free(job->src.start);
if (job->dst.start) free(job->dst.start); free(job->dst.start);
return 1; return 1;
} }
memcpy(job->src.start, data, srcSize); memcpy(job->src.start, data, srcSize);
@ -332,6 +332,6 @@ cleanup:
/* file compression completed */ /* file compression completed */
ret |= (srcFile != NULL) ? fclose(srcFile) : 0; ret |= (srcFile != NULL) ? fclose(srcFile) : 0;
ret |= (ctx != NULL) ? freeCCtx(ctx) : 0; ret |= (ctx != NULL) ? freeCCtx(ctx) : 0;
if (src != NULL) free(src); free(src);
return ret; return ret;
} }