From 54cc01c5be9fa9857454cda737980b1376c33797 Mon Sep 17 00:00:00 2001 From: Yann Collet Date: Fri, 18 Dec 2020 11:01:22 -0800 Subject: [PATCH 1/2] removed tests duplicated between TravisCI and Github Actions reduce load on TravisCI --- .github/workflows/generic-dev.yml | 10 +++- .travis.yml | 78 ------------------------------- 2 files changed, 9 insertions(+), 79 deletions(-) diff --git a/.github/workflows/generic-dev.yml b/.github/workflows/generic-dev.yml index 9abe98b73..8882fcc0b 100644 --- a/.github/workflows/generic-dev.yml +++ b/.github/workflows/generic-dev.yml @@ -58,6 +58,10 @@ jobs: LDFLAGS=-Wl,--no-undefined make -C lib libzstd-mt make -C tests zbufftest-dll + # candidate test (to check) : underlink test + # LDFLAGS=-Wl,--no-undefined : will make the linker fail if dll is underlinked + # zbufftest-dll : test that a user program can link to multi-threaded libzstd without specifying -pthread + gcc-8-asan-ubsan-testzstd: runs-on: ubuntu-16.04 # fails on 18.04 steps: @@ -92,6 +96,10 @@ jobs: sudo apt-get install clang-3.8 CC=clang-3.8 make clean msan-test-zstd HAVE_ZLIB=0 HAVE_LZ4=0 HAVE_LZMA=0 + # Note : external libraries must be turned off when using MSAN tests, + # because they are not msan-instrumented, + # so any data coming from these libraries is always considered "uninitialized" + cmake-build-and-test-check: runs-on: ubuntu-latest steps: @@ -155,7 +163,7 @@ jobs: make clean make c99build make clean - make travis-install + make travis-install # just ensures `make install` works mingw-cross-compilation: runs-on: ubuntu-latest diff --git a/.travis.yml b/.travis.yml index ee473733c..fd4b29e37 100644 --- a/.travis.yml +++ b/.travis.yml @@ -32,49 +32,11 @@ matrix: script: - make check - - name: make benchmarking - script: - - make benchmarking - - name: make test (complete) script: # DEVNULLRIGHTS : will request sudo rights to test permissions on /dev/null - DEVNULLRIGHTS=test make test - - name: gcc-6 + gcc-7 + libzstdmt compilation # ~ 6mn - script: - - make gcc6install gcc7install - - CC=gcc-6 CFLAGS=-Werror make -j all - - make clean - - CC=gcc-7 CFLAGS=-Werror make -j all - - make clean - - LDFLAGS=-Wl,--no-undefined make -C lib libzstd-mt - - make -C tests zbufftest-dll - # LDFLAGS=-Wl,--no-undefined : will make the linker fail if dll is underlinked - # zbufftest-dll : test that a user program can link to multi-threaded libzstd without specifying -pthread - - - name: gcc-8 + ASan + UBSan + Test Zstd # ~6.5mn - script: - - make gcc8install - - CC=gcc-8 CFLAGS="-Werror" make -j all - - make clean - - CC=gcc-8 make -j uasan-test-zstd Date: Fri, 18 Dec 2020 12:50:36 -0800 Subject: [PATCH 2/2] removed duplicated release-only tests from travisCI as they are already part of Github Actions --- .github/workflows/generic-release.yml | 1 + .travis.yml | 23 ----------------------- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/.github/workflows/generic-release.yml b/.github/workflows/generic-release.yml index a41f80f3e..167ba3848 100644 --- a/.github/workflows/generic-release.yml +++ b/.github/workflows/generic-release.yml @@ -44,6 +44,7 @@ jobs: sudo apt-get install clang-3.8 CC=clang-3.8 make tsan-test-zstream CC=clang-3.8 make tsan-fuzztest + zlib-wrapper: runs-on: ubuntu-16.04 steps: diff --git a/.travis.yml b/.travis.yml index fd4b29e37..4757c6b02 100644 --- a/.travis.yml +++ b/.travis.yml @@ -93,11 +93,6 @@ matrix: - make test - make -C lib all - - name: zbuff test - if: branch = release - script: - - make -C tests test-zbuff - - name: Versions Compatibility Test # 11.5mn if: branch = release script: @@ -132,24 +127,6 @@ matrix: - make arminstall - make aarch64fuzz - - name: zlib wrapper test # ~7.5mn - if: branch = release - script: - - make gpp6install valgrindinstall - - make -C zlibWrapper test - - make -C zlibWrapper valgrindTest - - - name: LZ4, thread pool, and partial libs tests # ~4mn - if: branch = release - script: - - make lz4install - - make -C tests test-lz4 - - make check < /dev/null | tee # mess with lz4 console detection - - make clean - - make -C tests test-pool - - make clean - - bash tests/libzstd_partial_builds.sh - # meson dedicated test - name: Xenial (Meson + clang) # ~15mn if: branch = release