sharpetronics/zstd
1
0
Fork 0
mirror of https://github.com/facebook/zstd.git synced 2025-10-09 00:05:28 -04:00
Code Issues Projects Releases Wiki Activity

Give Up on Searching End of Block

Browse Source 
Amusingly, it seems to be a non-trivial performance hit to add in final
searches or even hash table insertions during cleanup. So let's not. It seems
to not make any meaningful difference in compression ratio.
This commit is contained in:
W. Felix Handte 2021-08-18 16:02:01 -04:00
parent 35932ab2f1
commit 7c24c3e6ce
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/compress/zstd_fast.c
View File

@ -354,10 +354,9 @@ _start: /* Requires: ip0 */
} while (ip2 < ilimit); } while (ip2 < ilimit);
_cleanup: _cleanup:
/* Note that there are probably still a couple positions we could search.
/* Find matches at end of block. */ * However, it seems to be a meaningful performance hit to try to search
* them. So let's not. */
/* TODO */
/* save reps for next block */ /* save reps for next block */
rep[0] = rep_offset1 ? rep_offset1 : offsetSaved; rep[0] = rep_offset1 ? rep_offset1 : offsetSaved;