sharpetronics/zstd
1
0
Fork 0
mirror of https://github.com/facebook/zstd.git synced 2025-10-04 00:02:33 -04:00
Code Issues Projects Releases Wiki Activity

Added a final success message at end of tests

Browse Source 
so that a human reading the test log can determine everything was fine without consulting the shell error code.

Also: made `make check` slightly shorter by moving one longer test to `make test`
This commit is contained in:
Yann Collet 2025-01-17 19:30:55 -08:00
parent c8243b4724
commit 78275149ea
5 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/dev-short-tests.yml vendored
View File

@ -144,11 +144,11 @@ jobs:
- name: install valgrind - name: install valgrind
run: | run: |
sudo apt-get -qqq update sudo apt-get -qqq update
make valgrindinstall make valgrindinstall V=1
- name: zlib wrapper test - name: zlib wrapper test
run: make -C zlibWrapper test run: make -C zlibWrapper test V=1
- name: zlib wrapper test under valgrind - name: zlib wrapper test under valgrind
run: make -C zlibWrapper test-valgrind run: make -C zlibWrapper test-valgrind V=1
lz4-threadpool-libs: lz4-threadpool-libs:
runs-on: ubuntu-latest runs-on: ubuntu-latest

2
CONTRIBUTING.md
View File

@ -60,7 +60,7 @@ Our contribution process works in three main stages:
* Note: run local tests to ensure that your changes didn't break existing functionality * Note: run local tests to ensure that your changes didn't break existing functionality
* Quick check * Quick check
``` ```
make shortest make check
``` ```
* Longer check * Longer check
``` ```

8
Makefile
View File

@ -85,14 +85,10 @@ test:
$(MAKE) -C $(TESTDIR) $@ $(MAKE) -C $(TESTDIR) $@
ZSTD=../../programs/zstd $(MAKE) -C doc/educational_decoder $@ ZSTD=../../programs/zstd $(MAKE) -C doc/educational_decoder $@
## shortest: same as `make check`
.PHONY: shortest
shortest:
$(Q)$(MAKE) -C $(TESTDIR) $@
## check: run basic tests for `zstd` cli ## check: run basic tests for `zstd` cli
.PHONY: check .PHONY: check
check: shortest check:
$(Q)$(MAKE) -C $(TESTDIR) $@
.PHONY: automated_benchmarking .PHONY: automated_benchmarking
automated_benchmarking: automated_benchmarking:

13
tests/Makefile
View File

@ -312,12 +312,12 @@ endif
list: list:
@$(MAKE) -pRrq -f $(lastword $(MAKEFILE_LIST)) : 2>/dev/null | awk -v RS= -F: '/^# File/,/^# Finished Make data base/ {if ($$1 !~ "^[#.]") {print $$1}}' | sort | egrep -v -e '^[^[:alnum:]]' -e '^$@$$' | xargs @$(MAKE) -pRrq -f $(lastword $(MAKEFILE_LIST)) : 2>/dev/null | awk -v RS= -F: '/^# File/,/^# Finished Make data base/ {if ($$1 !~ "^[#.]") {print $$1}}' | sort | egrep -v -e '^[^[:alnum:]]' -e '^$@$$' | xargs
.PHONY: shortest
shortest: ZSTDRTTEST= # remove long tests
shortest: test-zstd
.PHONY: check .PHONY: check
check: shortest check: ZSTDRTTEST= # remove long tests
check: test-zstd
@echo "\n******************************"
@echo "All tests completed successfully"
@echo "******************************"
.PHONY: fuzztest .PHONY: fuzztest
fuzztest: test-fuzzer test-zstream test-decodecorpus fuzztest: test-fuzzer test-zstream test-decodecorpus
@ -327,6 +327,9 @@ test: test-zstd test-cli-tests test-fullbench test-fuzzer test-zstream test-inva
ifeq ($(QEMU_SYS),) ifeq ($(QEMU_SYS),)
test: test-pool test: test-pool
endif endif
@echo "\n******************************"
@echo "All tests completed successfully"
@echo "******************************"
.PHONY: test32 .PHONY: test32
test32: test-zstd32 test-fullbench32 test-fuzzer32 test-zstream32 test32: test-zstd32 test-fullbench32 test-fuzzer32 test-zstream32

3
tests/playTests.sh
View File

@ -1554,7 +1554,6 @@ then
roundTripTest -g4M "1 -T0 --auto-threads=physical" roundTripTest -g4M "1 -T0 --auto-threads=physical"
roundTripTest -g4M "1 -T0 --auto-threads=logical" roundTripTest -g4M "1 -T0 --auto-threads=logical"
roundTripTest -g8M "3 -T2" roundTripTest -g8M "3 -T2"
roundTripTest -g8M "19 --long"
roundTripTest -g8000K "2 --threads=2" roundTripTest -g8000K "2 --threads=2"
fileRoundTripTest -g4M "19 -T2 -B1M" fileRoundTripTest -g4M "19 -T2 -B1M"
@ -1850,6 +1849,8 @@ roundTripTest -g18000017 -P88 17
roundTripTest -g18000018 -P94 18 roundTripTest -g18000018 -P94 18
roundTripTest -g18000019 -P96 19 roundTripTest -g18000019 -P96 19
roundTripTest -g8M "19 --long"
roundTripTest -g5000000000 -P99 "1 --zstd=wlog=25" roundTripTest -g5000000000 -P99 "1 --zstd=wlog=25"
roundTripTest -g3700000000 -P0 "1 --zstd=strategy=6,wlog=25" # ensure btlazy2 can survive an overflow rescale roundTripTest -g3700000000 -P0 "1 --zstd=strategy=6,wlog=25" # ensure btlazy2 can survive an overflow rescale