From a4f92741072368ad5a5689a2e28b3c034f3da4c4 Mon Sep 17 00:00:00 2001 From: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Date: Tue, 14 Oct 2025 16:10:48 +0200 Subject: [PATCH] Fix indentation of sighup handler calling code (#19060) --- changelog.d/19060.bugfix | 1 + synapse/app/_base.py | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 changelog.d/19060.bugfix diff --git a/changelog.d/19060.bugfix b/changelog.d/19060.bugfix new file mode 100644 index 0000000000..81a6e54567 --- /dev/null +++ b/changelog.d/19060.bugfix @@ -0,0 +1 @@ +Fix a bug introduced in 1.136.0 that would prevent Synapse from being able to be `reload`-ed more than once when running under systemd. \ No newline at end of file diff --git a/synapse/app/_base.py b/synapse/app/_base.py index b416b66ac6..e30151dfb4 100644 --- a/synapse/app/_base.py +++ b/synapse/app/_base.py @@ -591,9 +591,9 @@ async def start(hs: "HomeServer", freeze: bool = True) -> None: # we're not using systemd. sdnotify(b"RELOADING=1") - for sighup_callbacks in _instance_id_to_sighup_callbacks_map.values(): - for func, args, kwargs in sighup_callbacks: - func(*args, **kwargs) + for sighup_callbacks in _instance_id_to_sighup_callbacks_map.values(): + for func, args, kwargs in sighup_callbacks: + func(*args, **kwargs) sdnotify(b"READY=1")