sharpetronics/strongswan
1
0
Fork 0
mirror of https://github.com/strongswan/strongswan.git synced 2025-10-06 00:00:47 -04:00
Code Issues Projects Releases Wiki Activity

chunk: Fix chunk_mac/hash tests on big-endian systems

Browse Source 
Our SipHash-2-4 implementation returns the result in host order, while
the test vectors are little-endian.  Use a custom comparison function to
account for this.

Fixes #478.
This commit is contained in:
Tobias Brunner 2014-01-06 17:31:07 +01:00
parent 13f2d3a2f6
commit d62a6ec3f9
1 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/libstrongswan/tests/suites/test_chunk.c
View File

@ -672,6 +672,31 @@ static const u_char sip_vectors[64][8] =
{ 0x72, 0x45, 0x06, 0xeb, 0x4c, 0x32, 0x8a, 0x95, }
};
/**
* Our SipHash-2-4 implementation returns the result in host order, which
* doesn't matter for practical purposes and even avoids a byte swap. But
* because the test vectors are in little-endian we have to account for this
* with this custom comparison function.
*/
static inline bool sipeq(const void *a, const void *b, size_t n)
{
u_char *ap = (u_char*)a, *bp = (u_char*)b;
int i;
for (i = 0; i < n; i++)
{
#ifdef WORDS_BIGENDIAN
if (ap[i] != bp[n - i - 1])
#else
if (ap[i] != bp[i])
#endif
{
return FALSE;
}
}
return TRUE;
}
START_TEST(test_chunk_mac)
{
chunk_t in;
@ -692,7 +717,7 @@ START_TEST(test_chunk_mac)
in.ptr[i] = i;
in.len = i;
out = chunk_mac(in, key);
fail_unless(memeq(&out, sip_vectors[i], 8),
fail_unless(sipeq(&out, sip_vectors[i], 8),
"test vector failed for %d bytes", i);
}
}
@ -739,7 +764,7 @@ START_TEST(test_chunk_hash_static)
in.len = i;
/* compared to chunk_mac() we only get half the value back */
out = chunk_hash_static(in);
fail_unless(memeq(&out, sip_vectors[i], 4),
fail_unless(sipeq(&out, sip_vectors[i], 4),
"test vector failed for %d bytes", i);
}
hash_a = chunk_hash_static_inc(in, out);