sharpetronics/strongswan
1
0
Fork 0
mirror of https://github.com/strongswan/strongswan.git synced 2025-10-06 00:00:47 -04:00
Code Issues Projects Releases Wiki Activity

tls-peer: Correctly handle classic ECDH key-share format

Browse Source 
Similar to TLS 1.2 but uses a 16-bit length header.
This commit is contained in:
Tobias Brunner 2020-08-26 16:08:26 +02:00
parent 8e35b1f1a5
commit d532d6c7bc
1 changed files with 29 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/libtls/tls_peer.c
View File

@ -252,7 +252,8 @@ static status_t process_server_hello(private_tls_peer_t *this,
case TLS_EXT_KEY_SHARE: case TLS_EXT_KEY_SHARE:
if (!extension->read_uint16(extension, &key_type) || if (!extension->read_uint16(extension, &key_type) ||
(!is_retry_request && (!is_retry_request &&
!extension->read_data16(extension, &key_share))) !(extension->read_data16(extension, &key_share) &&
key_share.len)))
{ {
DBG1(DBG_TLS, "invalid %N extension", tls_extension_names, DBG1(DBG_TLS, "invalid %N extension", tls_extension_names,
extension_type); extension_type);
@ -371,11 +372,25 @@ static status_t process_server_hello(private_tls_peer_t *this,
return NEED_MORE; return NEED_MORE;
} }
if (this->tls->get_version_max(this->tls) == TLS_1_3) if (this->tls->get_version_max(this->tls) >= TLS_1_3)
{ {
chunk_t shared_secret = chunk_empty; chunk_t shared_secret = chunk_empty;
if (!this->dh->set_other_public_value(this->dh, key_share) || if (key_share.len &&
key_type != TLS_CURVE25519 &&
key_type != TLS_CURVE448)
{ /* classic format (see RFC 8446, section 4.2.8.2) */
if (key_share.ptr[0] != TLS_ANSI_UNCOMPRESSED)
{
DBG1(DBG_TLS, "DH point format '%N' not supported",
tls_ansi_point_format_names, key_share.ptr[0]);
this->alert->add(this->alert, TLS_FATAL, TLS_INTERNAL_ERROR);
return NEED_MORE;
}
key_share = chunk_skip(key_share, 1);
}
if (!key_share.len ||
!this->dh->set_other_public_value(this->dh, key_share) ||
!this->dh->get_shared_secret(this->dh, &shared_secret) || !this->dh->get_shared_secret(this->dh, &shared_secret) ||
!this->crypto->derive_handshake_keys(this->crypto, shared_secret)) !this->crypto->derive_handshake_keys(this->crypto, shared_secret))
{ {
@ -1294,7 +1309,17 @@ static status_t send_client_hello(private_tls_peer_t *this,
extensions->write_uint16(extensions, TLS_EXT_KEY_SHARE); extensions->write_uint16(extensions, TLS_EXT_KEY_SHARE);
key_share = bio_writer_create(pub.len + 6); key_share = bio_writer_create(pub.len + 6);
key_share->write_uint16(key_share, selected_curve); key_share->write_uint16(key_share, selected_curve);
key_share->write_data16(key_share, pub); if (selected_curve == TLS_CURVE25519 ||
selected_curve == TLS_CURVE448)
{
key_share->write_data16(key_share, pub);
}
else
{ /* classic format (see RFC 8446, section 4.2.8.2) */
key_share->write_uint16(key_share, pub.len + 1);
key_share->write_uint8(key_share, TLS_ANSI_UNCOMPRESSED);
key_share->write_data(key_share, pub);
}
key_share->wrap16(key_share); key_share->wrap16(key_share);
extensions->write_data16(extensions, key_share->get_buf(key_share)); extensions->write_data16(extensions, key_share->get_buf(key_share));
key_share->destroy(key_share); key_share->destroy(key_share);