mirror of
https://github.com/stripe/stripe-ruby.git
synced 2025-06-01 00:00:30 -04:00
As detailed in issue #119, we've somewhat unfortunately been allowing object attributes to be passed in during a #save because we mix any arguments directly into the serialized hash (it seems that this was originally intended to be used more for meta parameters that go to the request). As also noted in #119, this use causes problems when certain types of parameters (like subobjects) are used. We're now left in the somewhat awkward position of either: 1. Removing this functionality on #save and breaking what may be behavior that people depend on. 2. Fully support this mass assignment. This patch takes the second path by extracting a new #update_attributes method and using it from #save. It's still far from a perfect approach because keys that have the same name as certain options (e.g. `req_url`) are not going to work, but it should capture the behavior that most people want. Fixes #119.
314 lines
8.6 KiB
Ruby
314 lines
8.6 KiB
Ruby
module Stripe
|
|
class StripeObject
|
|
include Enumerable
|
|
|
|
@@permanent_attributes = Set.new([:id])
|
|
|
|
# The default :id method is deprecated and isn't useful to us
|
|
if method_defined?(:id)
|
|
undef :id
|
|
end
|
|
|
|
def initialize(id=nil, opts={})
|
|
id, @retrieve_params = Util.normalize_id(id)
|
|
@opts = Util.normalize_opts(opts)
|
|
@values = {}
|
|
# This really belongs in APIResource, but not putting it there allows us
|
|
# to have a unified inspect method
|
|
@unsaved_values = Set.new
|
|
@transient_values = Set.new
|
|
@values[:id] = id if id
|
|
end
|
|
|
|
def self.construct_from(values, opts={})
|
|
values = Stripe::Util.symbolize_names(values)
|
|
self.new(values[:id]).refresh_from(values, opts)
|
|
end
|
|
|
|
def to_s(*args)
|
|
JSON.pretty_generate(@values)
|
|
end
|
|
|
|
def inspect
|
|
id_string = (self.respond_to?(:id) && !self.id.nil?) ? " id=#{self.id}" : ""
|
|
"#<#{self.class}:0x#{self.object_id.to_s(16)}#{id_string}> JSON: " + JSON.pretty_generate(@values)
|
|
end
|
|
|
|
def refresh_from(values, opts, partial=false)
|
|
@opts = Util.normalize_opts(opts)
|
|
@original_values = Marshal.load(Marshal.dump(values)) # deep copy
|
|
|
|
removed = partial ? Set.new : Set.new(@values.keys - values.keys)
|
|
added = Set.new(values.keys - @values.keys)
|
|
|
|
# Wipe old state before setting new. This is useful for e.g. updating a
|
|
# customer, where there is no persistent card parameter. Mark those values
|
|
# which don't persist as transient
|
|
|
|
instance_eval do
|
|
remove_accessors(removed)
|
|
add_accessors(added, values)
|
|
end
|
|
|
|
removed.each do |k|
|
|
@values.delete(k)
|
|
@transient_values.add(k)
|
|
@unsaved_values.delete(k)
|
|
end
|
|
|
|
update_attributes_with_options(values, opts: opts)
|
|
values.each do |k, _|
|
|
@transient_values.delete(k)
|
|
@unsaved_values.delete(k)
|
|
end
|
|
|
|
return self
|
|
end
|
|
|
|
# Mass assigns attributes on the model.
|
|
def update_attributes(values)
|
|
update_attributes_with_options(values, {})
|
|
end
|
|
|
|
# Mass assigns attributes on the model.
|
|
#
|
|
# This is a version of +update_attributes+ that takes some extra options
|
|
# for internal use.
|
|
#
|
|
# ==== Options
|
|
#
|
|
# * +:opts:+ Options for StripeObject like an API key.
|
|
# * +:raise_error:+ Set to false to suppress ArgumentErrors on keys that
|
|
# don't exist.
|
|
def update_attributes_with_options(values, options={})
|
|
# `opts` are StripeObject options
|
|
opts = options.fetch(:opts, {})
|
|
raise_error = options.fetch(:raise_error, true)
|
|
|
|
values.each do |k, v|
|
|
if !@@permanent_attributes.include?(k) && !self.respond_to?(:"#{k}=")
|
|
if raise_error
|
|
raise ArgumentError,
|
|
"#{k} is not an attribute that can be assigned on this object"
|
|
else
|
|
next
|
|
end
|
|
end
|
|
|
|
@values[k] = Util.convert_to_stripe_object(v, opts)
|
|
@unsaved_values.add(k)
|
|
end
|
|
self
|
|
end
|
|
|
|
def [](k)
|
|
@values[k.to_sym]
|
|
end
|
|
|
|
def []=(k, v)
|
|
send(:"#{k}=", v)
|
|
end
|
|
|
|
def keys
|
|
@values.keys
|
|
end
|
|
|
|
def values
|
|
@values.values
|
|
end
|
|
|
|
def to_json(*a)
|
|
JSON.generate(@values)
|
|
end
|
|
|
|
def as_json(*a)
|
|
@values.as_json(*a)
|
|
end
|
|
|
|
def to_hash
|
|
maybe_to_hash = lambda do |value|
|
|
value.respond_to?(:to_hash) ? value.to_hash : value
|
|
end
|
|
|
|
@values.inject({}) do |acc, (key, value)|
|
|
acc[key] = case value
|
|
when Array
|
|
value.map(&maybe_to_hash)
|
|
else
|
|
maybe_to_hash.call(value)
|
|
end
|
|
acc
|
|
end
|
|
end
|
|
|
|
def each(&blk)
|
|
@values.each(&blk)
|
|
end
|
|
|
|
def _dump(level)
|
|
Marshal.dump([@values, @opts])
|
|
end
|
|
|
|
def self._load(args)
|
|
values, opts = Marshal.load(args)
|
|
construct_from(values, opts)
|
|
end
|
|
|
|
if RUBY_VERSION < '1.9.2'
|
|
def respond_to?(symbol)
|
|
@values.has_key?(symbol) || super
|
|
end
|
|
end
|
|
|
|
def serialize_nested_object(key)
|
|
new_value = @values[key]
|
|
if new_value.is_a?(APIResource)
|
|
return {}
|
|
end
|
|
|
|
if @unsaved_values.include?(key)
|
|
# the object has been reassigned
|
|
# e.g. as object.key = {foo => bar}
|
|
update = new_value
|
|
new_keys = update.keys.map(&:to_sym)
|
|
|
|
# remove keys at the server, but not known locally
|
|
if @original_values[key]
|
|
keys_to_unset = @original_values[key].keys - new_keys
|
|
keys_to_unset.each {|key| update[key] = ''}
|
|
end
|
|
|
|
update
|
|
else
|
|
# can be serialized normally
|
|
self.class.serialize_params(new_value)
|
|
end
|
|
end
|
|
|
|
def self.serialize_params(obj, original_value=nil)
|
|
case obj
|
|
when nil
|
|
''
|
|
when StripeObject
|
|
unsaved_keys = obj.instance_variable_get(:@unsaved_values)
|
|
obj_values = obj.instance_variable_get(:@values)
|
|
update_hash = {}
|
|
|
|
unsaved_keys.each do |k|
|
|
update_hash[k] = serialize_params(obj_values[k])
|
|
end
|
|
|
|
obj_values.each do |k, v|
|
|
if v.is_a?(StripeObject) || v.is_a?(Hash)
|
|
update_hash[k] = obj.serialize_nested_object(k)
|
|
elsif v.is_a?(Array)
|
|
original_value = obj.instance_variable_get(:@original_values)[k]
|
|
if original_value && original_value.length > v.length
|
|
# url params provide no mechanism for deleting an item in an array,
|
|
# just overwriting the whole array or adding new items. So let's not
|
|
# allow deleting without a full overwrite until we have a solution.
|
|
raise ArgumentError.new(
|
|
"You cannot delete an item from an array, you must instead set a new array"
|
|
)
|
|
end
|
|
update_hash[k] = serialize_params(v, original_value)
|
|
end
|
|
end
|
|
|
|
update_hash
|
|
when Array
|
|
update_hash = {}
|
|
obj.each_with_index do |value, index|
|
|
update = serialize_params(value)
|
|
if update != {} && (!original_value || update != original_value[index])
|
|
update_hash[index] = update
|
|
end
|
|
end
|
|
|
|
if update_hash == {}
|
|
nil
|
|
else
|
|
update_hash
|
|
end
|
|
else
|
|
obj
|
|
end
|
|
end
|
|
|
|
protected
|
|
|
|
def metaclass
|
|
class << self; self; end
|
|
end
|
|
|
|
def remove_accessors(keys)
|
|
metaclass.instance_eval do
|
|
keys.each do |k|
|
|
next if @@permanent_attributes.include?(k)
|
|
k_eq = :"#{k}="
|
|
remove_method(k) if method_defined?(k)
|
|
remove_method(k_eq) if method_defined?(k_eq)
|
|
end
|
|
end
|
|
end
|
|
|
|
def add_accessors(keys, values)
|
|
metaclass.instance_eval do
|
|
keys.each do |k|
|
|
next if @@permanent_attributes.include?(k)
|
|
k_eq = :"#{k}="
|
|
define_method(k) { @values[k] }
|
|
define_method(k_eq) do |v|
|
|
if v == ""
|
|
raise ArgumentError.new(
|
|
"You cannot set #{k} to an empty string." \
|
|
"We interpret empty strings as nil in requests." \
|
|
"You may set #{self}.#{k} = nil to delete the property.")
|
|
end
|
|
@values[k] = v
|
|
@unsaved_values.add(k)
|
|
end
|
|
|
|
if [FalseClass, TrueClass].include?(values[k].class)
|
|
k_bool = :"#{k}?"
|
|
define_method(k_bool) { @values[k] }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def method_missing(name, *args)
|
|
# TODO: only allow setting in updateable classes.
|
|
if name.to_s.end_with?('=')
|
|
attr = name.to_s[0...-1].to_sym
|
|
|
|
# the second argument is only required when adding boolean accessors
|
|
add_accessors([attr], {})
|
|
|
|
begin
|
|
mth = method(name)
|
|
rescue NameError
|
|
raise NoMethodError.new("Cannot set #{attr} on this object. HINT: you can't set: #{@@permanent_attributes.to_a.join(', ')}")
|
|
end
|
|
return mth.call(args[0])
|
|
else
|
|
return @values[name] if @values.has_key?(name)
|
|
end
|
|
|
|
begin
|
|
super
|
|
rescue NoMethodError => e
|
|
if @transient_values.include?(name)
|
|
raise NoMethodError.new(e.message + ". HINT: The '#{name}' attribute was set in the past, however. It was then wiped when refreshing the object with the result returned by Stripe's API, probably as a result of a save(). The attributes currently available on this object are: #{@values.keys.join(', ')}")
|
|
else
|
|
raise
|
|
end
|
|
end
|
|
end
|
|
|
|
def respond_to_missing?(symbol, include_private = false)
|
|
@values && @values.has_key?(symbol) || super
|
|
end
|
|
end
|
|
end
|