mirror of
https://github.com/stripe/stripe-ruby.git
synced 2025-10-15 00:00:44 -04:00
I'm not sure exactly what changed here (did we change the `$VERBOSE` setting?), but I'm not seeing a whole lot of warnings when running the test suites locally and in CI. For example: ``` Started ........................................./home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ............../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ......../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized .../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ........./home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ... ..../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ....../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ..../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ......./home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ........./home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ........../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ................./home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized .../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ..../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ....../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized .......... ........./home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ....../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ......../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ......../home/travis/build/stripe/stripe-ruby/lib/stripe/api_operations/list.rb:6: warning: instance variable @opts not initialized ............./home/travis/build/stripe/stripe-ruby/lib/stripe/stripe_object.rb:35: warning: instance variable @values not initialized ./home/travis/build/stripe/stripe-ruby/lib/stripe/stripe_object.rb:35: warning: instance variable @values not initialized ...................../home/travis/build/stripe/stripe-ruby/lib/stripe/transfer.rb:8: warning: instance variable @api_key not initialized .............. .. Finished in 0.785621037 seconds. ``` Most of these are due to unused or uninitialized variables. This patch fixes all warnings by fixing offending code.
46 lines
1010 B
Ruby
46 lines
1010 B
Ruby
require 'stripe'
|
|
require 'test/unit'
|
|
require 'mocha/setup'
|
|
require 'stringio'
|
|
require 'shoulda'
|
|
require File.expand_path('../test_data', __FILE__)
|
|
|
|
# monkeypatch request methods
|
|
module Stripe
|
|
@mock_rest_client = nil
|
|
|
|
def self.mock_rest_client=(mock_client)
|
|
@mock_rest_client = mock_client
|
|
end
|
|
|
|
class << self
|
|
remove_method :execute_request
|
|
end
|
|
|
|
def self.execute_request(opts)
|
|
get_params = (opts[:headers] || {})[:params]
|
|
post_params = opts[:payload]
|
|
case opts[:method]
|
|
when :get then @mock_rest_client.get opts[:url], get_params, post_params
|
|
when :post then @mock_rest_client.post opts[:url], get_params, post_params
|
|
when :delete then @mock_rest_client.delete opts[:url], get_params, post_params
|
|
end
|
|
end
|
|
end
|
|
|
|
class Test::Unit::TestCase
|
|
include Stripe::TestData
|
|
include Mocha
|
|
|
|
setup do
|
|
@mock = mock
|
|
Stripe.mock_rest_client = @mock
|
|
Stripe.api_key = "foo"
|
|
end
|
|
|
|
teardown do
|
|
Stripe.mock_rest_client = nil
|
|
Stripe.api_key = nil
|
|
end
|
|
end
|