mirror of
https://github.com/stripe/stripe-ruby.git
synced 2025-10-15 00:00:44 -04:00
81b7cb3ca8
When uploading a file, we previously made a check on whether it supported both `#read` and `#path` before wrapping it in a `Faraday::UploadIO` and sending it off. The second check on `#path` isn't strictly necessary, and as reported in #761 can prevent objects created by `open-uri` from being compatible with file upload. Here we remove the check `#path` so that we just require that objects support `#read`, and in addition error when an object is passed that's not file-compatible and not a string. This should prevent users from seeing the very confusing "Invalid hash" error in these situations. Fixes #761.
98 lines
3.0 KiB
Ruby
98 lines
3.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require ::File.expand_path("../../test_helper", __FILE__)
|
|
|
|
module Stripe
|
|
class FileTest < Test::Unit::TestCase
|
|
should "be listable" do
|
|
files = Stripe::File.list
|
|
assert_requested :get, "#{Stripe.api_base}/v1/files"
|
|
assert files.data.is_a?(Array)
|
|
assert files.data[0].is_a?(Stripe::File)
|
|
end
|
|
|
|
should "be retrievable" do
|
|
file = Stripe::File.retrieve("file_123")
|
|
assert_requested :get, "#{Stripe.api_base}/v1/files/file_123"
|
|
assert file.is_a?(Stripe::File)
|
|
end
|
|
|
|
context ".create" do
|
|
setup do
|
|
# We don't point to the same host for the API and uploads in
|
|
# production, but `stripe-mock` supports both APIs.
|
|
Stripe.uploads_base = Stripe.api_base
|
|
|
|
# Set `api_base` to `nil` to ensure that these requests are _not_ sent
|
|
# to the default API hostname.
|
|
Stripe.api_base = nil
|
|
end
|
|
|
|
should "be creatable with a File" do
|
|
file = Stripe::File.create(
|
|
purpose: "dispute_evidence",
|
|
file: ::File.new(__FILE__),
|
|
file_link_data: { create: true }
|
|
)
|
|
assert_requested :post, "#{Stripe.uploads_base}/v1/files"
|
|
assert file.is_a?(Stripe::File)
|
|
end
|
|
|
|
should "be creatable with a Tempfile" do
|
|
tempfile = Tempfile.new("foo")
|
|
tempfile.write("Hello world")
|
|
tempfile.rewind
|
|
|
|
file = Stripe::File.create(
|
|
purpose: "dispute_evidence",
|
|
file: tempfile,
|
|
file_link_data: { create: true }
|
|
)
|
|
assert_requested :post, "#{Stripe.uploads_base}/v1/files"
|
|
assert file.is_a?(Stripe::File)
|
|
end
|
|
|
|
should "be creatable with Faraday::UploadIO" do
|
|
file = Stripe::File.create(
|
|
purpose: "dispute_evidence",
|
|
file: Faraday::UploadIO.new(::File.new(__FILE__), nil),
|
|
file_link_data: { create: true }
|
|
)
|
|
assert_requested :post, "#{Stripe.uploads_base}/v1/files"
|
|
assert file.is_a?(Stripe::File)
|
|
end
|
|
|
|
should "be creatable with a string" do
|
|
file = Stripe::File.create(
|
|
purpose: "dispute_evidence",
|
|
file: "my-file-contents",
|
|
file_link_data: { create: true }
|
|
)
|
|
assert_requested :post, "#{Stripe.uploads_base}/v1/files"
|
|
assert file.is_a?(Stripe::File)
|
|
end
|
|
|
|
should "raise given a file object that doesn't respond to #read" do
|
|
e = assert_raises(ArgumentError) do
|
|
Stripe::File.create(
|
|
purpose: "dispute_evidence",
|
|
file: Object.new,
|
|
file_link_data: { create: true }
|
|
)
|
|
end
|
|
assert_equal "file must respond to `#read`", e.message
|
|
end
|
|
end
|
|
|
|
should "be deserializable when `object=file`" do
|
|
file = Stripe::Util.convert_to_stripe_object({ object: "file" }, {})
|
|
assert file.is_a?(Stripe::File)
|
|
end
|
|
|
|
should "be deserializable when `object=file_upload`" do
|
|
file = Stripe::Util.convert_to_stripe_object({ object: "file_upload" }, {})
|
|
assert file.is_a?(Stripe::File)
|
|
end
|
|
end
|
|
end
|