From b4308aaa7eeaa82a3f94f9ed281e929b6d9bdf4d Mon Sep 17 00:00:00 2001 From: Slava Akhmechet Date: Wed, 12 Jul 2017 12:54:53 -0700 Subject: [PATCH] Moving tests closer to the core --- test/stripe/invoice_test.rb | 15 --------------- test/stripe/stripe_client_test.rb | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/test/stripe/invoice_test.rb b/test/stripe/invoice_test.rb index 073a437b..4c176f55 100644 --- a/test/stripe/invoice_test.rb +++ b/test/stripe/invoice_test.rb @@ -74,21 +74,6 @@ module Stripe } assert invoice.kind_of?(Stripe::Invoice) end - - should "convert nil params to empty string" do - invoice = Stripe::Invoice.upcoming( - customer: API_FIXTURES[:customer][:id], - subscription: API_FIXTURES[:subscription][:id], - coupon: nil - ) - assert_requested :get, "#{Stripe.api_base}/v1/invoices/upcoming", - query: { - customer: API_FIXTURES[:customer][:id], - subscription: API_FIXTURES[:subscription][:id], - coupon: '' - } - assert invoice.kind_of?(Stripe::Invoice) - end end end end diff --git a/test/stripe/stripe_client_test.rb b/test/stripe/stripe_client_test.rb index 5b30be15..19cfbf04 100644 --- a/test/stripe/stripe_client_test.rb +++ b/test/stripe/stripe_client_test.rb @@ -455,6 +455,20 @@ module Stripe client.execute_request(:post, '/v1/charges') end end + + context "params serialization" do + should 'convert nil params to empty string' do + client = StripeClient.new + client.execute_request(:get, '/v1/invoices/upcoming', + params: {customer: API_FIXTURES[:customer][:id], + subscription: API_FIXTURES[:subscription][:id], + coupon: nil}) + assert_requested(:get, "#{Stripe.api_base}/v1/invoices/upcoming?", + query: { "customer" => API_FIXTURES[:customer][:id], + "subscription" => API_FIXTURES[:subscription][:id], + "coupon" => "" }) + end + end end context "#request" do