sharpetronics/stripe-ruby
1
0
Fork 0
mirror of https://github.com/stripe/stripe-ruby.git synced 2025-12-12 00:02:33 -05:00
Code Issues Projects Releases Wiki Activity

Merge pull request #664 from jasonwebster/do_not_colorize_logger_logging

Browse Source 
Do not colorize output destined for configured logger
This commit is contained in:
Brandur 2018-07-19 09:55:30 -07:00 committed by GitHub
commit b3eb5d3e30
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/stripe/util.rb
View File

@ -396,7 +396,7 @@ module Stripe
def self.log_internal(message, data = {}, color: nil, level: nil, logger: nil, out: nil) def self.log_internal(message, data = {}, color: nil, level: nil, logger: nil, out: nil)
data_str = data.reject { |_k, v| v.nil? } data_str = data.reject { |_k, v| v.nil? }
.map do |(k, v)| .map do |(k, v)|
format("%s=%s", colorize(k, color, !out.nil? && out.isatty), wrap_logfmt_value(v)) format("%s=%s", colorize(k, color, logger.nil? && !out.nil? && out.isatty), wrap_logfmt_value(v))
end.join(" ") end.join(" ")
if !logger.nil? if !logger.nil?

2
test/stripe/util_test.rb
View File

@ -396,7 +396,7 @@ module Stripe
} }
Util.send(:log_internal, "message", { foo: "bar" }, Util.send(:log_internal, "message", { foo: "bar" },
color: :green, level: Stripe::LEVEL_DEBUG, logger: logger, out: nil) color: :green, level: Stripe::LEVEL_DEBUG, logger: logger, out: $stdout)
assert_equal "message=message foo=bar", assert_equal "message=message foo=bar",
out.string out.string
end end