From 88c8720712696097adb87b2ef66cedb0847be36e Mon Sep 17 00:00:00 2001
From: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com>
Date: Thu, 24 Apr 2025 08:08:17 -0700
Subject: [PATCH] Fix endpoints being hit since requests are stubbed (#1591)

* Fix endpoints being hit since requests are stubbed

* Use a fake endpoint
---
 test/stripe/api_requestor_test.rb | 33 ++++++++++++++-----------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/test/stripe/api_requestor_test.rb b/test/stripe/api_requestor_test.rb
index 7e0644f2..aa5a36bd 100644
--- a/test/stripe/api_requestor_test.rb
+++ b/test/stripe/api_requestor_test.rb
@@ -1197,16 +1197,15 @@ module Stripe
 
         context "params serialization" do
           should "allows empty strings in params" do
-            stub_request(:get, "#{Stripe::DEFAULT_API_BASE}/v1/invoices/upcoming?customer=cus_123&coupon=").to_return(body: "{}")
+            stub_request(:get, "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?customer=cus_123&coupon=").to_return(body: JSON.generate(object: "test_resource"))
             requestor = APIRequestor.new("sk_test_123")
-            requestor.config.api_base = "http://localhost:#{MOCK_PORT}"
-            requestor.send(request_method, :get, "/v1/invoices/upcoming", :api,
+            requestor.send(request_method, :get, "/v1/test_resource", :api,
                            params: { customer: "cus_123", coupon: "" },
                            &@read_body_chunk_block)
 
             assert_requested(
               :get,
-              "#{Stripe.api_base}/v1/invoices/upcoming?",
+              "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?",
               query: {
                 customer: "cus_123",
                 coupon: "",
@@ -1215,15 +1214,15 @@ module Stripe
           end
 
           should "filter nils in params" do
-            stub_request(:get, "#{Stripe::DEFAULT_API_BASE}/v1/invoices/upcoming?customer=cus_123").to_return(body: "{}")
+            stub_request(:get, "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?customer=cus_123")
+              .to_return(body: JSON.generate(object: "test_resource"))
             requestor = APIRequestor.new("sk_test_123")
-            requestor.config.api_base = "http://localhost:#{MOCK_PORT}"
-            requestor.send(request_method, :get, "/v1/invoices/upcoming", :api,
+            requestor.send(request_method, :get, "/v1/test_resource", :api,
                            params: { customer: "cus_123", coupon: nil },
                            &@read_body_chunk_block)
             assert_requested(
               :get,
-              "#{Stripe.api_base}/v1/invoices/upcoming?",
+              "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?",
               query: {
                 customer: "cus_123",
               }
@@ -1231,17 +1230,16 @@ module Stripe
           end
 
           should "merge query parameters in URL and params" do
-            stub_request(:get, "#{Stripe.api_base}/v1/invoices/upcoming?coupon=25OFF&customer=cus_123")
-              .to_return(body: JSON.generate(object: "invoice"))
+            stub_request(:get, "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?coupon=25OFF&customer=cus_123")
+              .to_return(body: JSON.generate(object: "account"))
 
             requestor = APIRequestor.new("sk_test_123")
-            requestor.config.api_base = "http://localhost:#{MOCK_PORT}"
-            requestor.send(request_method, :get, "/v1/invoices/upcoming?coupon=25OFF", :api,
+            requestor.send(request_method, :get, "/v1/test_resource?coupon=25OFF", :api,
                            params: { customer: "cus_123" },
                            &@read_body_chunk_block)
             assert_requested(
               :get,
-              "#{Stripe.api_base}/v1/invoices/upcoming?",
+              "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?",
               query: {
                 coupon: "25OFF",
                 customer: "cus_123",
@@ -1250,17 +1248,16 @@ module Stripe
           end
 
           should "prefer query parameters in params when specified in URL as well" do
-            stub_request(:get, "#{Stripe::DEFAULT_API_BASE}/v1/invoices/upcoming?customer=cus_param")
-              .to_return(body: JSON.generate(object: "invoice"))
+            stub_request(:get, "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?customer=cus_param")
+              .to_return(body: JSON.generate(object: "account"))
 
             requestor = APIRequestor.new("sk_test_123")
-            requestor.instance_variable_get(:@config).api_base = "http://localhost:#{MOCK_PORT}"
-            requestor.send(request_method, :get, "/v1/invoices/upcoming?customer=cus_query", :api,
+            requestor.send(request_method, :get, "/v1/test_resource?customer=cus_query", :api,
                            params: { customer: "cus_param" },
                            &@read_body_chunk_block)
             assert_requested(
               :get,
-              "#{Stripe.api_base}/v1/invoices/upcoming?",
+              "#{Stripe::DEFAULT_API_BASE}/v1/test_resource?",
               query: {
                 customer: "cus_param",
               }