Merge pull request #453 from stripe/brandur-stop-alphabetizing

Don't alphabetize encoded maps by key

lib/stripe/util.rb

@@ -135,7 +135,7 @@ module Stripe
 
       # do not sort the final output because arrays (and arrays of hashes
       # especially) can be order sensitive, but do sort incoming parameters
-      params.sort_by { |(k, _)| k.to_s }.each do |key, value|
+      params.each do |key, value|
         calculated_key = parent_key ? "#{parent_key}[#{key}]" : "#{key}"
         if value.is_a?(Hash)
           result += flatten_params(value, calculated_key)

test/stripe/account_test.rb

@@ -105,7 +105,7 @@ module Stripe
       }
       @mock.expects(:post).
         once.
-        with('https://api.stripe.com/v1/accounts/acct_foo', nil, 'legal_entity[address][line1]=2+Three+Four&legal_entity[first_name]=Bob').
+        with('https://api.stripe.com/v1/accounts/acct_foo', nil, 'legal_entity[first_name]=Bob&legal_entity[address][line1]=2+Three+Four').
         returns(make_response(resp))
 
       a = Stripe::Account.update('acct_foo', :legal_entity => {

test/stripe/util_test.rb

@@ -36,8 +36,8 @@ module Stripe
         [:d, { :a => "a", :b => "b" }],
         [:e, [0, 1]],
         [:f, [
-          { :bar => "1", :foo => "2" },
+          { :foo => "1", :ghi => "2" },
-          { :baz => "3", :foo => "4" },
+          { :foo => "3", :bar => "4" },
         ]],
       ]
       assert_equal([
@@ -52,10 +52,10 @@ module Stripe
         # *The key here is the order*. In order to be properly interpreted as
         # an array of hashes on the server, everything from a single hash must
         # come in at once. A duplicate key in an array triggers a new element.
-        ["f[][bar]", "1"],
+        ["f[][foo]", "1"],
-        ["f[][foo]", "2"],
+        ["f[][ghi]", "2"],
-        ["f[][baz]", "3"],
+        ["f[][foo]", "3"],
-        ["f[][foo]", "4"],
+        ["f[][bar]", "4"],
       ], Stripe::Util.flatten_params(params))
     end