sharpetronics/stripe-ruby
1
0
Fork 0
mirror of https://github.com/stripe/stripe-ruby.git synced 2025-11-29 00:01:18 -05:00
Code Issues Projects Releases Wiki Activity

Merge pull request #625 from stripe/ob-skip-to-hash-for-nil

Browse Source 
Skip calling to_hash for nil
This commit is contained in:
Olivier Bellone 2018-02-12 11:31:06 -08:00 committed by GitHub
commit 1abb8a574b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/stripe/stripe_object.rb
View File

@ -116,7 +116,7 @@ module Stripe
def to_hash
maybe_to_hash = lambda do |value|
value.respond_to?(:to_hash) ? value.to_hash : value
value && value.respond_to?(:to_hash) ? value.to_hash : value
end
@values.each_with_object({}) do |(key, value), acc|

47
test/stripe/stripe_object_test.rb
View File

@ -115,23 +115,40 @@ module Stripe
end
end
should "recursively call to_hash on its values" do
# deep nested hash (when contained in an array) or StripeObject
nested_hash = { id: 7, foo: "bar" }
nested = Stripe::StripeObject.construct_from(nested_hash)
context "#to_hash" do
should "skip calling to_hash on nil" do
module NilWithToHash
def to_hash
raise "Can't call to_hash on nil"
end
end
# include is private in Ruby 2.0
NilClass.send(:include, NilWithToHash)
obj = Stripe::StripeObject.construct_from(id: 1,
# simple hash that contains a StripeObject to help us test deep
# recursion
nested: { object: "list", data: [nested] },
list: [nested])
hash_with_nil = { id: 3, foo: nil }
obj = StripeObject.construct_from(hash_with_nil)
expected_hash = { id: 3, foo: nil }
assert_equal expected_hash, obj.to_hash
end
expected_hash = {
id: 1,
nested: { object: "list", data: [nested_hash] },
list: [nested_hash],
}
assert_equal expected_hash, obj.to_hash
should "recursively call to_hash on its values" do
# deep nested hash (when contained in an array) or StripeObject
nested_hash = { id: 7, foo: "bar" }
nested = Stripe::StripeObject.construct_from(nested_hash)
obj = Stripe::StripeObject.construct_from(id: 1,
# simple hash that contains a StripeObject to help us test deep
# recursion
nested: { object: "list", data: [nested] },
list: [nested])
expected_hash = {
id: 1,
nested: { object: "list", data: [nested_hash] },
list: [nested_hash],
}
assert_equal expected_hash, obj.to_hash
end
end
should "assign question mark accessors for booleans" do