Commit Graph

  • c40031d94a Fix CI (as it install Rubocop 1.45.1 and fails) Guilherme Carreiro 2023-02-13 08:51:07 +01:00
  • 4599e5459f
    Merge pull request #1684 from Shopify/fix-variable-lookup-parse-timeout Michael Go 2023-02-02 10:39:46 -04:00
  • 59c445f0e1
    Avoid a couple of duplicate assertions (#1675) Dylan Thacker-Smith 2023-02-02 09:31:01 -05:00
  • bd9c3802c8 add variable parser timeout unit tests #1684 fix-variable-lookup-parse-timeout Michael Go 2023-02-01 21:15:35 -04:00
  • 2b40850e4a fix variable lookup parse timing out with missing closing bracket Michael Go 2023-02-01 19:52:30 -04:00
  • 22ded5f304
    Merge pull request #1683 from Shopify/marco/raw-tag-whitespace-control Marco Concetto Rudilosso 2023-02-01 16:51:46 +00:00
  • ddc32b7bd8
    actually test whitespace stripping #1683 marco/raw-tag-whitespace-control Marco Concetto Rudilosso 2023-02-01 15:52:34 +00:00
  • 74e505f6fa
    Allow raw tag to be used with whitespace control Marco Concetto Rudilosso 2023-02-01 13:49:51 +00:00
  • 6a888d4564
    Merge pull request #1680 from Shopify/recursively-parse-brackets Michael Go 2023-01-31 16:29:54 -04:00
  • dd257b3d66 add an unit test for double nest variable lookup #1680 recursively-parse-brackets Michael Go 2023-01-30 20:36:14 -04:00
  • 1aaf6ed019 recursively parse brackets on variable lookup Michael Go 2023-01-30 18:32:23 -04:00
  • daf93a83c2
    Merge pull request #1676 from Shopify/tablerow-nil-params Michael Go 2023-01-18 11:08:04 -04:00
  • e889a9da0b use to_i to parse parameters of tablerow tag #1676 tablerow-nil-params Michael Go 2023-01-17 17:48:16 -04:00
  • 65899ee261 Revert "Instrument usage of bug with iteration of String with offset or 0 limit (#1667)" #1677 revert-1667-instrument-string-slice-bug-usage Dylan Thacker-Smith 2023-01-17 15:28:39 -05:00
  • 0f11c97623 raise invalid integer argument error from tablerow Michael Go 2023-01-16 18:51:34 -04:00
  • 5c88bcc763
    Avoid a couple of duplicate assertions #1675 Dylan Thacker-Smith 2023-01-16 11:25:58 -05:00
  • e804f36681
    Merge pull request #1674 from Shopify/better-test-to-liquid-value Dylan Thacker-Smith 2023-01-16 10:44:41 -05:00
  • 619ed3fcd7
    Add some additional to_liquid_value assertions #1674 Dylan Thacker-Smith 2023-01-13 15:46:12 -05:00
  • cdb5cb06b2
    Remove == method from drops from testing to_liquid_value Dylan Thacker-Smith 2023-01-13 15:37:27 -05:00
  • bc153159e6
    Merge pull request #1673 from Shopify/initialize-context Jean byroot Boussier 2023-01-12 22:19:28 +01:00
  • 128b4e35be
    Initialize context to nil on the Drop class #1673 Jemma Issroff 2023-01-12 15:35:22 -05:00
  • c743936a78
    Instrument usage of bug with iteration of String with offset or 0 limit (#1667) Dylan Thacker-Smith 2023-01-11 14:05:50 -05:00
  • bf711a0521
    Provide another assertion for to_liquid_value unless tag test (#1672) Dylan Thacker-Smith 2023-01-11 14:05:27 -05:00
  • 63b9d9f63c
    Provide another assertion for to_liquid_value unless tag test #1672 Dylan Thacker-Smith 2023-01-11 13:25:43 -05:00
  • e8731f27d9
    Merge pull request #1671 from ashmaroli/use-builtin-bundle-cache Dylan Thacker-Smith 2023-01-11 11:40:11 -05:00
  • 6a44c1ec77 Do not set ENV["BUNDLE_PATH"] #1671 Ashwin Maroli 2023-01-11 22:06:47 +05:30
  • ae3057e94b
    Backport flaky no object allocation test fix v4.0.4 shipit-deploy/rubygems-4-0-stable 4-0-stable Dylan Thacker-Smith 2023-01-11 10:42:36 -05:00
  • fe4961568f
    Use the released version of the liquid-c 4-0-stable branch Dylan Thacker-Smith 2023-01-11 10:32:01 -05:00
  • 1f8bafcb84
    Add allowed_push_host to gemspec to allow releases Dylan Thacker-Smith 2023-01-11 10:31:25 -05:00
  • 1beb87b446 Bump latest Ruby version in CI matrix Ashwin Maroli 2023-01-11 20:58:17 +05:30
  • b839deb3a8 Use cache built into ruby/setup-ruby action Ashwin Maroli 2023-01-11 20:50:44 +05:30
  • 30a656920d
    Merge pull request #1668 from Shopify/4-0-backports Dylan Thacker-Smith 2023-01-11 10:03:57 -05:00
  • 4af7e3db48 better test naming Dan Singerman 2023-01-11 14:04:52 +00:00
  • 9731b1d53f pass strict_variables and stricit_filters to render context Dan Singerman 2023-01-11 13:59:37 +00:00
  • 0317cf6101 whitespace #1669 Dan Singerman 2023-01-11 11:41:13 +00:00
  • 2810571e94 Add template name to exception when raised from render tag Dan Singerman 2023-01-11 11:39:15 +00:00
  • 25bc833b4d
    Instrument usage of bug with iteration of String with offset or 0 limit #1667 Dylan Thacker-Smith 2023-01-10 16:01:57 -05:00
  • a19320f8f8
    rubocop: Exclude vendored dependencies in CI #1668 Dylan Thacker-Smith 2023-01-10 15:34:56 -05:00
  • 8983fcb47e
    Update History.md Dylan Thacker-Smith 2023-01-10 15:26:12 -05:00
  • c1c9157e75
    Use 4-0-stable liquid-c branch to fix extension compilation in CI Dylan Thacker-Smith 2023-01-10 15:22:13 -05:00
  • f199ba0715
    Backport CI migration Dylan Thacker-Smith 2023-01-10 14:39:06 -05:00
  • dd70fcfec8
    Bump rake for ruby 3.2 compatibility Dylan Thacker-Smith 2023-01-10 14:00:38 -05:00
  • abfcec9a57
    Fix ParseTreeVisitorTest for ruby 3 compatibility Dylan Thacker-Smith 2020-03-31 10:19:25 -04:00
  • 0487badd03
    Use liquid-c 4.0.0 Dylan Thacker-Smith 2023-01-10 13:30:55 -05:00
  • 01d52d72d9
    Remove use of ruby taint API for ruby 3.2 compatibility Dylan Thacker-Smith 2023-01-10 13:11:18 -05:00
  • 0b826120c0
    Merge pull request #1665 from Shopify/update-description-divided_by-filter liamgriffin 2023-01-09 14:12:23 +00:00
  • 936f803a4e Removed trailing space #1665 liamgriffin 2023-01-06 11:36:20 +00:00
  • 5cd8a83fa6 Adding more content to divided_by filter liamgriffin 2023-01-06 11:19:13 +00:00
  • 5abae18645 Bring back Registers#each #1663 Šimon Lukašík 2022-12-26 11:52:59 +00:00
  • aca5a16912 Bring back Registers#values_at #1662 Šimon Lukašík 2022-12-25 21:37:46 +00:00
  • c6a1cb4aca
    Create temp #1661 BradyH4 2022-12-17 18:11:06 -06:00
  • 95bfac1d06 updates README #1660 Jibril Tapiador 2022-12-18 02:04:12 +06:00
  • a8fb7b01c6 updates README Jibril Tapiador 2022-12-18 02:03:06 +06:00
  • c2c6cb2b15
    Allow commas to separate for tag attributes (#1658) Dylan Thacker-Smith 2022-11-29 09:00:55 -05:00
  • 8978fd271a
    Allow commas to separate for tag attributes #1658 Dylan Thacker-Smith 2022-11-24 11:52:02 -05:00
  • e4e368b5f9
    Add migrate tests for for tag source-migrate Dylan Thacker-Smith 2022-11-24 11:46:21 -05:00
  • 0672ebfcbb
    Test migration parity using existing integration tests Dylan Thacker-Smith 2022-11-23 12:14:23 -05:00
  • 871336753e
    Add source migration support for all builtin tags Dylan Thacker-Smith 2022-11-22 15:14:25 -05:00
  • 12f11876dd
    Assert that result of migration can be strictly parsed Dylan Thacker-Smith 2022-11-17 09:53:11 -05:00
  • 106ca1bd69
    Quote non-strictly valid identifiers in variable lookups Dylan Thacker-Smith 2022-11-17 09:51:23 -05:00
  • 7d2a9da8bc
    Preserve separator at start of variable from QuotedFragment skipped chars Dylan Thacker-Smith 2022-11-17 09:50:12 -05:00
  • e20df18eca
    [WIP] Add support for migrating liquid code away from several lax parse quirks Dylan Thacker-Smith 2022-11-14 16:51:59 -05:00
  • 9ccbf64571
    Merge pull request #1656 from Shopify/sr-inline-comment shainaraskas 2022-11-14 10:38:55 -05:00
  • 7257e86d36
    Merge 35570d4ee092b7cf21f54939794329d0dc245b25 into 1cdd1f0834199900c504ef8c3b2b6bfaffb6c816 #1346 Peter Zhu 2022-11-13 17:02:28 +01:00
  • 8b1b9f649a remove separate inline comment tag for IA reasons #1656 sr-inline-comment Shaina Raskas 2022-11-11 16:21:18 -05:00
  • 474315c6bb edits Shaina Raskas 2022-11-11 16:03:52 -05:00
  • 667664bb22 clarify inline_comment Shaina Raskas 2022-11-11 15:34:35 -05:00
  • 1cdd1f0834
    refactor: Advance tokenizer array offset instead of using Array#shift (#1653) Dylan Thacker-Smith 2022-11-09 13:03:33 -05:00
  • 0bff26910d
    refactor: Advance tokenizer array offset instead of using Array#shift #1653 Dylan Thacker-Smith 2022-11-08 11:01:52 -05:00
  • 712949b59f
    Merge pull request #1638 from Shopify/gh-pages-sr shainaraskas 2022-11-02 10:38:36 -04:00
  • 1cd5ec54f0
    Merge pull request #1641 from Shopify/assert-template-result-static-env Dylan Thacker-Smith 2022-11-02 10:05:52 -04:00
  • cc6cd64065 Special case Hash#last in variable lookup #1651 hash-last Sam Doiron 2022-11-01 14:40:36 -03:00
  • 29732f4305
    Merge pull request #1345 from Shopify/pz-fix-tags-in-comment Peter Zhu 2022-11-01 13:07:03 -04:00
  • abed47547c Fix tags in comment #1345 Peter Zhu 2022-11-01 13:04:41 -04:00
  • ace3fe15ac
    Merge pull request #1648 from Shopify/fix-include-internal-error Dylan Thacker-Smith 2022-10-28 14:29:03 -04:00
  • db8e85ab31
    Prevent an internal error in include tag from non-string template_name #1648 Dylan Thacker-Smith 2022-10-28 13:57:17 -04:00
  • f484b868d0
    assert_template_result: Avoid using the BlankFileSystem Dylan Thacker-Smith 2022-10-28 13:55:33 -04:00
  • 3e8994c258
    Have subclasses of a tag inherit superclass's disabled tags (#1646) Dylan Thacker-Smith 2022-10-27 11:13:50 -04:00
  • 83603247a2
    Have subclasses of a tag inherit superclass's disabled tags #1646 Dylan Thacker-Smith 2022-10-26 17:23:48 -04:00
  • 7ccac29688
    Merge pull request #1635 from Shopify/update-doc-links Erin Morrissey 2022-10-26 11:07:46 -07:00
  • 96b5325f87
    Remove Usage.increment calls that have been shown to in fact be used (#1645) Dylan Thacker-Smith 2022-10-26 09:21:43 -04:00
  • 331f6ecb79
    Remove Usage.increment calls that have been shown to in fact be used #1645 Dylan Thacker-Smith 2022-10-25 17:34:00 -04:00
  • b8f05267a9 update link paths in docs markup #1635 Erin Morrissey 2022-10-25 11:53:27 -07:00
  • 6ce4ec1011
    tablerow: Avoid accidental special case for constant nil cols (#1644) Dylan Thacker-Smith 2022-10-25 10:21:03 -04:00
  • 769cf20fb9
    tablerow: Avoid accidental special case for constant nil cols #1644 Dylan Thacker-Smith 2022-10-24 12:49:33 -04:00
  • 105bc8be8a Add url_add_param and url_remove_param filters Anders Søgaard 2022-10-21 21:15:50 +02:00
  • a39422feac
    Use static environment assert_template_result input values #1641 Dylan Thacker-Smith 2022-10-21 11:45:29 -04:00
  • 2c2f5826d5
    Change increment/decrement tests to avoid relying on input Dylan Thacker-Smith 2022-10-21 11:43:58 -04:00
  • 8e5911d3ee document inline comments #1638 gh-pages-sr Shaina Raskas 2022-10-19 10:43:53 -04:00
  • 622b3b9a1d feedback Shaina Raskas 2022-10-19 09:14:57 -04:00
  • c52e75a9b5 grammar and language Shaina Raskas 2022-10-18 16:05:43 -04:00
  • 99a59e39d8 fix link formatting Shaina Raskas 2022-10-18 16:04:14 -04:00
  • 2f8dc74f95 use tables instead of headings Shaina Raskas 2022-10-18 16:01:41 -04:00
  • 57d41e535f draft Shaina Raskas 2022-10-18 15:38:24 -04:00
  • e98030c732 remove tainted object tests (no longer valid in ruby 2.7 or greater) #1637 Karl Smith 2022-10-13 16:11:10 -07:00
  • 3c32170ffe address minitest deprecations, and remove spy that results in frozen string error Karl Smith 2022-10-13 16:02:46 -07:00
  • 9d87da24cd set ruby version to allow ruby >= 2.6.0 Karl Smith 2022-10-13 16:01:46 -07:00
  • daf14bdb69 all things around tainted objects have been removed Karl Smith 2022-10-13 15:59:14 -07:00
  • 938819d61d add pin for correct version of liquid-c, add byebug Karl Smith 2022-10-13 15:56:53 -07:00
  • d7748a8637 fix BigDecimal.new -> BigDecimal() Karl Smith 2022-10-13 15:55:59 -07:00