From e5cbdb2b273b3ebb033cce10827381a1cc4c0147 Mon Sep 17 00:00:00 2001 From: Mark Crossfield Date: Sun, 8 Jan 2017 12:42:42 +0000 Subject: [PATCH 1/2] =?UTF-8?q?Clarifies=20spelling=20of=20for=E2=80=99s?= =?UTF-8?q?=20reversed=20flag=20to=20address=20#843?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It should now be harder to read the docs and miss the extra letter required for reversed compared to reverse, which causes a fairly generic syntax warning when trying to reverse sort a collection in a for loop. --- lib/liquid/tags/for.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/liquid/tags/for.rb b/lib/liquid/tags/for.rb index 55011b3a..22ed31a6 100644 --- a/lib/liquid/tags/for.rb +++ b/lib/liquid/tags/for.rb @@ -23,7 +23,7 @@ module Liquid # {{ item.name }} # {% end %} # - # To reverse the for loop simply use {% for item in collection reversed %} + # To reverse the for loop simply use {% for item in collection reversed %} (note that the flag’s spelling is different to the filter `reverse`) # # == Available variables: # From 8b751ddf4607984de502c5b13e0344a17e55f8ab Mon Sep 17 00:00:00 2001 From: Mark Crossfield Date: Mon, 9 Jan 2017 10:16:35 +0000 Subject: [PATCH 2/2] Removes a non ascii character from comment to appease Rubocop --- lib/liquid/tags/for.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/liquid/tags/for.rb b/lib/liquid/tags/for.rb index 22ed31a6..5d5691fd 100644 --- a/lib/liquid/tags/for.rb +++ b/lib/liquid/tags/for.rb @@ -23,7 +23,7 @@ module Liquid # {{ item.name }} # {% end %} # - # To reverse the for loop simply use {% for item in collection reversed %} (note that the flag’s spelling is different to the filter `reverse`) + # To reverse the for loop simply use {% for item in collection reversed %} (note that the flag's spelling is different to the filter `reverse`) # # == Available variables: #