sharpetronics/liquid
1
0
Fork 0
mirror of https://github.com/Shopify/liquid.git synced 2025-11-13 00:00:48 -05:00
Code Issues Projects Releases Wiki Activity

fix: Clear the strainer cache when a global filter is added (#826)

Browse Source
This commit is contained in:
Dylan Thacker-Smith 2016-11-24 10:32:11 -05:00 committed by GitHub
parent 86944fe7b7
commit b146b49f46
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/liquid/strainer.rb
View File

@ -39,6 +39,7 @@ module Liquid
end
def self.global_filter(filter)
@@strainer_class_cache.clear
@@global_strainer.add_filter(filter)
end

12
test/unit/strainer_unit_test.rb
View File

@ -133,4 +133,16 @@ class StrainerUnitTest < Minitest::Test
strainer.class.add_filter(PublicMethodOverrideFilter)
assert strainer.class.filter_methods.include?('public_filter')
end
module LateAddedFilter
def late_added_filter(input)
"filtered"
end
end
def test_global_filter_clears_cache
assert_equal 'input', Strainer.create(nil).invoke('late_added_filter', 'input')
Strainer.global_filter(LateAddedFilter)
assert_equal 'filtered', Strainer.create(nil).invoke('late_added_filter', 'input')
end
end # StrainerTest