mirror of
https://github.com/open-quantum-safe/liboqs.git
synced 2025-10-04 00:02:01 -04:00
7c0aa19e8c
* Upgraded picnic to v3.0.2. * Fix explicit_bzero function. * Fixed redefinition of AddByte on little endian platforms (picnic's and oqs's namespacing) * Update picnic to v3.0.3 * Fixing some picnic functions namespacing * Added namespacing for picnic function on little endian system. * More picnic namespacing fixes * More picnic namespacing fixes, round 2 * Added more namespacing prefix * More picnic namespacing * Explicit namespacing for KeccakP1600times4_StaticInitialize function
58 lines
1.9 KiB
Python
58 lines
1.9 KiB
Python
# SPDX-License-Identifier: MIT
|
|
|
|
import helpers
|
|
import pytest
|
|
import sys
|
|
import glob
|
|
|
|
# Check if liboqs contains any non-namespaced global symbols
|
|
# See https://github.com/open-quantum-safe/liboqs/wiki/Coding-conventions for function naming conventions
|
|
|
|
@helpers.filtered_test
|
|
@pytest.mark.skipif(sys.platform.startswith("win"), reason="Not needed on Windows")
|
|
def test_namespace():
|
|
liboqs = glob.glob('build/lib/liboqs.*')[0]
|
|
if liboqs == 'build/lib/liboqs.dylib':
|
|
out = helpers.run_subprocess(
|
|
['nm', '-g', liboqs]
|
|
)
|
|
elif liboqs == 'build/lib/liboqs.so':
|
|
out = helpers.run_subprocess(
|
|
['nm', '-D', liboqs]
|
|
)
|
|
else:
|
|
out = helpers.run_subprocess(
|
|
['nm', '-g', liboqs]
|
|
)
|
|
|
|
lines = out.strip().split("\n")
|
|
symbols = []
|
|
for line in lines:
|
|
if ' T ' in line or ' D ' in line or ' S ' in line:
|
|
symbols.append(line)
|
|
|
|
# ideally this would be just ['oqs', 'pqclean'], but contains exceptions (e.g., providing compat implementations of unavailable platform functions)
|
|
namespaces = ['oqs', 'pqclean', 'keccak', 'pqcrystals', 'aligned_alloc', 'aligned_free', 'explicit_bzero', 'timingsafe_bcmp', 'init', 'fini', 'seedexpander']
|
|
non_namespaced = []
|
|
|
|
for symbolstr in symbols:
|
|
*_, symtype, symbol = symbolstr.split()
|
|
if symtype in 'TR':
|
|
is_namespaced = False
|
|
for namespace in namespaces:
|
|
if symbol.lower().startswith(namespace) or symbol.lower().startswith('_' + namespace):
|
|
is_namespaced = True
|
|
if not(is_namespaced):
|
|
non_namespaced.append(symbol)
|
|
|
|
if len(non_namespaced) > 0:
|
|
for symbol in non_namespaced:
|
|
print("Non-namespaced symbol: {}".format(symbol))
|
|
|
|
assert(len(non_namespaced) == 0)
|
|
|
|
if __name__ == "__main__":
|
|
import sys
|
|
pytest.main(sys.argv)
|
|
|