liboqs/tests/test_helpers.c
Marco Gianvecchio 8ee6039c74
Add bitflip test for trivial SUF-CMA forgeries (#2090)
* add bitflip test to test_sig.c
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* format code
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* - add sig->suf_cma
- add command-line argument to test_sig.c (the number of bitflips)
- update CROSS upstream to SUF-CMA
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* %d to %ld for size_t bitflips

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* cast argument bitflips to size_t
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* replace atoi() with strtol()
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* cast bit_index to %llu

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* update bitflip tests:
- revert CROSS to EUF-CMA
- add test_bitflip_message
- exclude stateful signatures for now
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* remove bitflips_as_str in printf
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* test_bitflip as a single function, add support for stateful signatures
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* add OQS_TEST_CT_DECLASSIFY after test_bitflip_stfl
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* [extended tests]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* more OQS_TEST_CT_DECLASSIFY [extended tests]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* patch dilithium to add suf-cma
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* run copy_from_upstream.py
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* SUF-CMA in dilithium docs, run copy_from_upstream.py
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* correct sizeof in OQS_randombytes call (thank you @SWilson4!)
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* factor bitflip testing functions out into test_helpers.c
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* --allow-multiple-definition for Windows .dll in test_kem_mem
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* --allow-multiple-definition for Windows .dll in test_sig and test_sig_stfl
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

---------

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>
2025-03-14 11:53:05 -04:00

254 lines
9.3 KiB
C

// SPDX-License-Identifier: MIT
#include <stddef.h>
#include <stdio.h>
#include <string.h>
#include <oqs/oqs.h>
#include <oqs/rand_nist.h> // Internal NIST DRBG API
#include <oqs/sha3.h> // Internal SHA3 API
#include "test_helpers.h"
/* HQC PRNG implementation */
// State for HQC PRNG. Analogue of DRBG_ctx in rand/rand_nist.c
static OQS_SHA3_shake256_inc_ctx hqc_prng_state = { NULL };
// Allocate the state.
static void hqc_prng_new(void) {
OQS_SHA3_shake256_inc_init(&hqc_prng_state);
}
// entropy_input must have length 48.
// If personalization_string is non-null, its length must also be 48.
static void hqc_prng_seed(const uint8_t *entropy_input, const uint8_t *personalization_string) {
uint8_t domain = 1;
// reset state
OQS_SHA3_shake256_inc_ctx_reset(&hqc_prng_state);
OQS_SHA3_shake256_inc_absorb(&hqc_prng_state, entropy_input, 48);
if (personalization_string != NULL) {
OQS_SHA3_shake256_inc_absorb(&hqc_prng_state, personalization_string, 48);
}
OQS_SHA3_shake256_inc_absorb(&hqc_prng_state, &domain, 1);
OQS_SHA3_shake256_inc_finalize(&hqc_prng_state);
}
// random_array must have length bytes_to_read.
static void hqc_prng_randombytes(uint8_t *random_array, size_t bytes_to_read) {
OQS_SHA3_shake256_inc_squeeze(random_array, bytes_to_read, &hqc_prng_state);
}
static void hqc_prng_get_state(void *out) {
OQS_SHA3_shake256_inc_ctx_clone((OQS_SHA3_shake256_inc_ctx *)out, &hqc_prng_state);
}
static void hqc_prng_set_state(const void *in) {
OQS_SHA3_shake256_inc_ctx_clone(&hqc_prng_state, (const OQS_SHA3_shake256_inc_ctx *)in);
}
static void hqc_prng_free(OQS_KAT_PRNG_state *saved_state) {
if (saved_state != NULL) {
OQS_SHA3_shake256_inc_ctx_release(&saved_state->hqc_state);
}
if (hqc_prng_state.ctx != NULL) {
OQS_SHA3_shake256_inc_ctx_release(&hqc_prng_state);
hqc_prng_state.ctx = NULL;
}
}
/* Helpers for identifying algorithms */
static int is_mceliece(const char *method_name) {
return ( !strcmp(method_name, OQS_KEM_alg_classic_mceliece_348864)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_348864f)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_460896)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_460896f)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_6688128)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_6688128f)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_6960119)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_6960119f)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_8192128)
|| !strcmp(method_name, OQS_KEM_alg_classic_mceliece_8192128f) );
}
static int is_hqc(const char *method_name) {
return (0 == strcmp(method_name, OQS_KEM_alg_hqc_128))
|| (0 == strcmp(method_name, OQS_KEM_alg_hqc_192))
|| (0 == strcmp(method_name, OQS_KEM_alg_hqc_256));
}
/* OQS_KAT_PRNG interface implementation */
OQS_KAT_PRNG *OQS_KAT_PRNG_new(const char *method_name) {
OQS_KAT_PRNG *prng = OQS_MEM_malloc(sizeof(OQS_KAT_PRNG));
if (prng != NULL) {
prng->max_kats = is_mceliece(method_name) ? 10 : 100;
if (is_hqc(method_name)) {
// set randombytes function
OQS_randombytes_custom_algorithm(&hqc_prng_randombytes);
// reset the PRNG
hqc_prng_new();
// initialize saved state
OQS_SHA3_shake256_inc_init(&prng->saved_state.hqc_state);
prng->seed = &hqc_prng_seed;
prng->get_state = &hqc_prng_get_state;
prng->set_state = &hqc_prng_set_state;
prng->free = &hqc_prng_free;
} else {
// set randombytes function
OQS_randombytes_custom_algorithm(&OQS_randombytes_nist_kat);
prng->seed = &OQS_randombytes_nist_kat_init_256bit;
prng->get_state = &OQS_randombytes_nist_kat_get_state;
prng->set_state = &OQS_randombytes_nist_kat_set_state;
prng->free = NULL;
}
}
return prng;
}
// entropy_input must have length 48.
// If personalization_string is non-null, its length must also be 48.
void OQS_KAT_PRNG_seed(OQS_KAT_PRNG *prng, const uint8_t *entropy_input, const uint8_t *personalization_string) {
if (prng != NULL) {
prng->seed(entropy_input, personalization_string);
}
}
void OQS_KAT_PRNG_save_state(OQS_KAT_PRNG *prng) {
if (prng != NULL) {
prng->get_state(&prng->saved_state);
}
}
void OQS_KAT_PRNG_restore_state(OQS_KAT_PRNG *prng) {
if (prng != NULL) {
prng->set_state(&prng->saved_state);
}
}
void OQS_KAT_PRNG_free(OQS_KAT_PRNG *prng) {
if (prng != NULL) {
// saved_state needs to be handled dynamically
if (prng->free != NULL) {
prng->free(&prng->saved_state);
}
}
OQS_MEM_insecure_free(prng);
}
/* Displays hexadecimal strings */
void OQS_print_hex_string(const char *label, const uint8_t *str, size_t len) {
printf("%-20s (%4zu bytes): ", label, len);
for (size_t i = 0; i < (len); i++) {
printf("%02X", str[i]);
}
printf("\n");
}
void OQS_fprintBstr(FILE *fp, const char *S, const uint8_t *A, size_t L) {
size_t i;
fprintf(fp, "%s", S);
for (i = 0; i < L; i++) {
fprintf(fp, "%02X", A[i]);
}
if (L == 0) {
fprintf(fp, "00");
}
fprintf(fp, "\n");
}
OQS_STATUS flip_bit(uint8_t *array, uint64_t array_length, uint64_t bit_position) {
uint64_t byte_index = bit_position / 8;
uint8_t bit_index = bit_position % 8;
if (byte_index >= array_length) {
fprintf(stderr, "ERROR: flip_bit index is out of bounds!\n");
return OQS_ERROR;
}
array[byte_index] ^= (1 << bit_index);
return OQS_SUCCESS;
}
/* flip bits of the message (or signature) one at a time, and check that the verification fails */
OQS_STATUS test_sig_bitflip(OQS_SIG *sig, uint8_t *message, size_t message_len, uint8_t *signature, size_t signature_len, uint8_t *public_key, bool bitflips_all[2], size_t bitflips[2], bool use_ctx, uint8_t *ctx, size_t ctx_i) {
OQS_STATUS rc;
/* the first test (EUF-CMA) flips bits of the message
the second test (SUF-CMA) flips bits of the signature */
int num_tests = sig->suf_cma ? 2 : 1;
for (int test = 0; test < num_tests; test++) {
/* select the array to tamper with (message or signature) */
uint8_t *tampered_array = (test == 1) ? signature : message;
size_t tampered_array_len = (test == 1) ? signature_len : message_len;
/* select the number of bitflips */
uint64_t bitflips_selected = bitflips_all[test] ? tampered_array_len * 8 : bitflips[test];
for (uint64_t i = 0; i < bitflips_selected; i ++) {
uint64_t random_bit_index;
OQS_randombytes((uint8_t *)&random_bit_index, sizeof(random_bit_index));
OQS_TEST_CT_DECLASSIFY(&random_bit_index, sizeof(random_bit_index));
random_bit_index = random_bit_index % (tampered_array_len * 8);
uint64_t bit_index = bitflips_all[test] ? i : random_bit_index;
/* flip the bit */
rc = flip_bit(tampered_array, tampered_array_len, bit_index);
if (rc != OQS_SUCCESS) {
return OQS_ERROR;
}
/* check that the verification fails */
if (use_ctx) {
rc = OQS_SIG_verify_with_ctx_str(sig, message, message_len, signature, signature_len, ctx, ctx_i, public_key);
} else {
rc = OQS_SIG_verify(sig, message, message_len, signature, signature_len, public_key);
}
OQS_TEST_CT_DECLASSIFY(&rc, sizeof rc);
if (rc != OQS_ERROR) {
fprintf(stderr, "ERROR: OQS_SIG_verify should have failed after flipping bit %llu of the %s!\n", (unsigned long long)bit_index, (test == 0) ? "message" : "signature");
return OQS_ERROR;
}
/* flip back the bit */
rc = flip_bit(tampered_array, tampered_array_len, bit_index);
if (rc != OQS_SUCCESS) {
return OQS_ERROR;
}
}
}
return OQS_SUCCESS;
}
/* flip bits of the message (or signature) one at a time, and check that the verification fails */
OQS_STATUS test_sig_stfl_bitflip(OQS_SIG_STFL *sig, uint8_t *message, size_t message_len, uint8_t *signature, size_t signature_len, uint8_t *public_key, bool bitflips_all[2], size_t bitflips[2]) {
OQS_STATUS rc;
/* the first test (EUF-CMA) flips bits of the message
the second test (SUF-CMA) flips bits of the signature */
int num_tests = sig->suf_cma ? 2 : 1;
for (int test = 0; test < num_tests; test++) {
/* select the array to tamper with (message or signature) */
uint8_t *tampered_array = (test == 1) ? signature : message;
size_t tampered_array_len = (test == 1) ? signature_len : message_len;
/* select the number of bitflips */
uint64_t bitflips_selected = bitflips_all[test] ? tampered_array_len * 8 : bitflips[test];
for (uint64_t i = 0; i < bitflips_selected; i ++) {
uint64_t random_bit_index;
OQS_randombytes((uint8_t *)&random_bit_index, sizeof(random_bit_index));
OQS_TEST_CT_DECLASSIFY(&random_bit_index, sizeof(random_bit_index));
random_bit_index = random_bit_index % (tampered_array_len * 8);
uint64_t bit_index = bitflips_all[test] ? i : random_bit_index;
/* flip the bit */
rc = flip_bit(tampered_array, tampered_array_len, bit_index);
if (rc != OQS_SUCCESS) {
return OQS_ERROR;
}
/* check that the verification fails */
rc = OQS_SIG_STFL_verify(sig, message, message_len, signature, signature_len, public_key);
OQS_TEST_CT_DECLASSIFY(&rc, sizeof rc);
if (rc != OQS_ERROR) {
fprintf(stderr, "ERROR: OQS_SIG_STFL_verify should have failed after flipping bit %llu of the %s!\n", (unsigned long long)bit_index, (test == 0) ? "message" : "signature");
return OQS_ERROR;
}
/* flip back the bit */
rc = flip_bit(tampered_array, tampered_array_len, bit_index);
if (rc != OQS_SUCCESS) {
return OQS_ERROR;
}
}
}
return OQS_SUCCESS;
}