* Removed upstream `name: pqcrystals-dilithium` and signature `name: dilithium` from `copy_from_upstream.yml`.
Removed everything under `src/sig/dilithium`
Re-run `copy_from_upstream.py -d copy`, which produced downstream changes to various build files.
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* remove Dilithium entries from kats.json
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* remove Dilithium entries from constant_time tests
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Removed dilithium.yml and dilithium.md. Re-run copy_from_upstream.py, which also updated README.md and cbom.json
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Removed Dilithium from FUZZING.md
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* removed license information about pqclean Dilithium and pqcrystals-dilithium from README.md. README.md still mentions Dilithium but only to say that it has been excluded
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Upgraded CONFIGURE.md minimal build example to ML-KEM-768 and ML-DSA-44
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Upgraded C++ sig linking test to ML-DSA-44; also added option to make the test fail hard if the algorithm is not enabled
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* remove Dilithium from GitHub action workflows
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* removed Dilithium from zephyr configuration and examples
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Removed scripts/copy_from_upstream/patches/pqclean-dilithium-arm-randomized-signing.patch
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Removed dilithium from upstream.name==pqclean.ignore
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Removed orphaned patches
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
---------
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Moved continuous benchmarking to weekly tests
Signed-off-by: Pablo Gutiérrez <pablogf@uma.es>
* Update CI.md
Signed-off-by: Pablo Gutiérrez <pablogf@uma.es>
* Cleaned CI.md
Signed-off-by: Pablo Gutiérrez <pablogf@uma.es>
---------
Signed-off-by: Pablo Gutiérrez <pablogf@uma.es>
* Add guidance / questions on generative AI use
Addresses https://github.com/orgs/open-quantum-safe/discussions/2253
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
* Suggestions from Basil
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
* Fix typo [skip ci]
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
* Wording suggestions from Norm [skip ci]
Co-authored-by: Norman Ashley <nashley@cisco.com>
Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com>
* Add link to OpenSSF AI guidelines. [skip ci]
Suggested by @AdityaKoranga in https://github.com/orgs/open-quantum-safe/discussions/2253#discussioncomment-14427125
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
---------
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com>
Co-authored-by: Norman Ashley <nashley@cisco.com>
This commit includes following changes:
* Revert "Removed NTRU. (#1335)"
* Replace the uses of malloc with OQS_MEM_malloc
* Add a derandomized keypair function
* Add "all" entries of NTRU algorithms to the KATs file
* Fix reflecting the removal of NTRU from PQClean
* Update NTRU documents with the latest manners
* Change the CODEOWNERS of NTRU KEM
Signed-off-by: Saito Masataka <saitomst@intellilink.co.jp>
* Fix permissions for poutine_analysis job
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
* supplychain job permissions in commit-to-main
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
---------
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
* Move actionlint to a standard runner
Restructure basic checks
* Move actionlint to a standard runner
Signed-off-by: Aiden Fox Ivey <aiden@aidenfoxivey.com>
* Added Custom Timeout to CI
Signed-off-by: Konstantinos <konstantinos.kitsios@uzh.ch>
* remove unnecessary comment
Signed-off-by: Konstantinos <konstantinos.kitsios@uzh.ch>
* Use correct syntax for timeout in jobs that span multiple files
Signed-off-by: Konstantinos <konstantinos.kitsios@uzh.ch>
---------
Signed-off-by: Konstantinos <konstantinos.kitsios@uzh.ch>
* Skip failing CI test
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
* Fix typo
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
---------
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
* Run scorecard workflow with models:read
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Remove all permissions for scorecard workflow
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Add security-events and id-token perms
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Clean up comments
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Update commit-to-main and weekly calls
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
---------
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
As a follow-up of commit 64bceb37fafa9b90cf228965079de9ebd77a83b9,
this checks that the library artifacts don't contain any unresolved
symbols from libcrypto.so when it is dynamically loaded.
Signed-off-by: Daiki Ueno <dueno@redhat.com>
* #1830 update scorecard to v5 (gh action 2.4.0)
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
* Pin action version in unix.yml
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
* Schedule only, no PR. Minor updates to scorecard
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
---------
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
* Trigger liboqs-java CI on commits to main
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Trigger liboqs-rust CI on commits to main
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
---------
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Remove hardcoded build paths
This fixes#2018 using `helpers.get_current_build_dir_name()`
Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
* Use a random build path in the basic build test
Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
---------
Signed-off-by: Iyán Méndez Veiga <me@iyanmv.com>
* Pull ML-DSA from pq-crystals upstream.
* Removes ML-DSA-ipd
* Adds support for context strings to OQS SIG API.
* Adding _with_ctx_str APIs, templating
* Adds ACVP tests for ML-DSA
* export symbols for acvp tests (dynamic linking)
* remove IPD intermediate values
* adds flag for ctx support
* Update constant-time passes after line nubmer and function name changes
* Update KATs
* API with checks for signatures without ctx support
* Additional test for signatures with ctx
* Change alg_version to FIPS204
* Update ML-DSA security claim to SUF-CMA, according to FIPS204
* Update src/sig/sig.h
* Fix test_alg_info
---------
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Add a --delete option to copy_from_upstream to remove unwanted implementation subdirectories.
* Enable the --delete option in CI to detect files included by mistake
* Switch to git status --porcelain in CI for script stability
* Remove unused SPHINCS+ aarch64 implementation using the --delete option
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
* Revert to latest Zephyr SDK container
* Fix for Zephyr build (missing include for ptrdiff_t)
* Zephyr CI tests are now using Zepyhr V3.4 (minimal supported version)
and Zephyr V3.7 (current LTS release)
Signed-off-by: Tobias Frauenschläger <t.frauenschlaeger@me.com>
* Check workflows for issues during CI
This PR adds an Actionlint workflow to validate GH actions as per #1866
This is an updated version of PR #1880, taking into account the discussion on that contribution.
Signed-off-by: JP Lomas <jp@theqrl.org>
* CONTRIBUTING.md update
Documents actionlint use as part of CI basic workflow including instructions of running locally.
Signed-off-by: JP Lomas <jp@theqrl.org>
* Update .github/workflows/basic.yml
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
Signed-off-by: JP Lomas <jp.lomas@gmail.com>
---------
Signed-off-by: JP Lomas <jp@theqrl.org>
Signed-off-by: JP Lomas <jp.lomas@gmail.com>
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
