sharpetronics/liboqs
1
0
Fork 0
mirror of https://github.com/open-quantum-safe/liboqs.git synced 2025-10-05 00:05:12 -04:00
Code Issues Projects Releases Wiki Activity
1,645 Commits 20 Branches 43 Tags
Commit Graph

60 Commits

Author SHA1 Message Date
Basil Hess
21add4acef
Fixes for Weekly Test Failures (#2285) 
* Avoid extended tests in time-critical runs [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Avoid extended tests in time-critical runs [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Fix incorrect addrnd (n) bytes in SLH-DSA, leading to heap overflows, Shorten long CI runs by skipping some SLH-DSA variants [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Update SLH-DSA template to fix addrnd sizes [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Fix long runtimes in emulated arm [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Adapt timeouts [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Change constant-time tests from auto to haswell optimization, to avoid valgrind incompatibility with AVX512 [full tests] [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* chore: move CI to large runner for Zephyr [full tests] [extended tests]

Signed-off-by: Ry Jones <ry@linux.com>

Update actionlint.yaml with allowed runners [full tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Remove macos-13 CI runs because of deprecation [full tests] [extended tests]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

---------

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Co-authored-by: Ry Jones <ry@linux.com>
 2025-10-02 18:33:36 +02:00
Bruce
f629296e28
Remove Dilithium (#2275) 
* Removed upstream `name: pqcrystals-dilithium` and signature `name: dilithium` from `copy_from_upstream.yml`.
Removed everything under `src/sig/dilithium`
Re-run `copy_from_upstream.py -d copy`, which produced downstream changes to various build files.

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* remove Dilithium entries from kats.json

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* remove Dilithium entries from constant_time tests

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Removed dilithium.yml and dilithium.md. Re-run copy_from_upstream.py, which also updated README.md and cbom.json

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Removed Dilithium from FUZZING.md

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* removed license information about pqclean Dilithium and pqcrystals-dilithium from README.md. README.md still mentions Dilithium but only to say that it has been excluded

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Upgraded CONFIGURE.md minimal build example to ML-KEM-768 and ML-DSA-44

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Upgraded C++ sig linking test to ML-DSA-44; also added option to make the test fail hard if the algorithm is not enabled

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* remove Dilithium from GitHub action workflows

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* removed Dilithium from zephyr configuration and examples

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Removed scripts/copy_from_upstream/patches/pqclean-dilithium-arm-randomized-signing.patch

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Removed dilithium from upstream.name==pqclean.ignore

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Removed orphaned patches

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

---------

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
 2025-09-22 20:52:14 -04:00
Saito Masataka
59bf831b47
Add NTRU back (#2176) 
This commit includes following changes:
* Revert "Removed NTRU. (#1335)"
* Replace the uses of malloc with OQS_MEM_malloc
* Add a derandomized keypair function
* Add "all" entries of NTRU algorithms to the KATs file
* Fix reflecting the removal of NTRU from PQClean
* Update NTRU documents with the latest manners
* Change the CODEOWNERS of NTRU KEM

Signed-off-by: Saito Masataka <saitomst@intellilink.co.jp>
 2025-09-09 17:10:28 -04:00
Matthias J. Kannwischer
708b1052d5
Adjust constan-time test exception for mlkem-native [extended tests] (#2162) 
The constant-time tests have been failing for mlkem-native as check_sk changed it's name and is no no longer recognized as an exception.
This function processes exclusively public data in the secret key and it's, hence, okay to branch both inside the function and depending on the return value.

This commit renames the function in the constant_time exceptions file.

Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
 2025-06-10 08:49:19 -04:00
Jan Adriaan Leegwater
429c98ee7e
Integrate SNOVA into liboqs (#2109) 
* Integrate SNOVA into liboqs

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Remove SNOVA_66_15_3

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Add ARM NEON

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Update, tighter constant_time passes and issues [full tests] [extended tests]

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Update remote commit

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Review comments SWilson4 [full tests] [extended tests]

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Fix newline at end of file [full tests] [extended tests]

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Restrict zephyr algorithms to the low stack ones. [full tests] [extended tests]

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Disable SNOVA_24_5_5 in zephyr test [full tests] [extended tests]

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Fix typos in KAT [full tests] [extended tests]

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

* Use Constant Time version for sign [full tests] [extended tests]

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>

---------

Signed-off-by: Jan Adriaan Leegwater <info@vacuas.nl>
 2025-05-01 11:41:57 -04:00
Basil Hess
fa5f792906
Update MAYO to NIST round 2 (#2095) 
* Update MAYO to NIST round 2 [full tests] [extended tests] [trigger downstream]

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

* Update mayo yml with neon

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>

---------

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
 2025-03-07 18:31:41 +01:00
Marco Gianvecchio
77917043c4
Update CROSS to version 2.0 (#2078) 
* Update CROSS to version 2.0
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* implementations-switch-on-runtime-cpu-features: false in CROSS [skip ci]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* update KAT "all" for CROSS [extended tests]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* update cross.md [extended tests]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* correct call stack in the suppression file for CROSS [extended tests]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

---------

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>
 2025-02-20 07:51:12 +01:00
Basil Hess
a554b36dd3
Import ML-KEM from mlkem-native/PQ code package (#2041) 
* Integrate ML-KEM from mlkem-native [full tests] [extended tests]

---------

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
 2025-02-04 16:26:27 +01:00
Basil Hess
d9c214cc64
Add ML-DSA / FIPS 204 final (#1919) 
* Pull ML-DSA from pq-crystals upstream.
* Removes ML-DSA-ipd
* Adds support for context strings to OQS SIG API.
* Adding _with_ctx_str APIs, templating
* Adds ACVP tests for ML-DSA
* export symbols for acvp tests (dynamic linking)
* remove IPD intermediate values
* adds flag for ctx support
* Update constant-time passes after line nubmer and function name changes
* Update KATs
* API with checks for signatures without ctx support
* Additional test for signatures with ctx
* Change alg_version to FIPS204
* Update ML-DSA security claim to SUF-CMA, according to FIPS204
* Update src/sig/sig.h
* Fix test_alg_info

---------
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
 2024-11-26 13:45:10 +01:00
Spencer Wilson
b37c937a64
Refactor liboqs CI and update Ubuntu images (#1909) 
* Refactor liboqs CI to utilize reusable workflows
* Add CI.md documentation file
* Update all Focal jobs to Noble (the latest Ubuntu LTS)
* Minor fixes to address issues related to the update (CT files / syntax / static analysis)

Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
 2024-09-09 10:43:59 -04:00
Marco Gianvecchio
d93a431aaf
Add CROSS (#1881) 
* add CROSS upstream

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* add KATs

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* add docs

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* add Zephyr config

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* run copy_from_upstream.py

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* fix: counter i in generate_merkle_proof shadows previous declaration

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* "claimed-security" is BUFF (instead of EUF-CMA)

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* add CROSS to NIST_SIG_ONRAMP

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* "claimed-security" is set to EUF-CMA by liboqs

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* don't use threads for CROSS variants with large stack usage

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* int defines in api.h don't need to be "L"

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* added auxiliary-submitters

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* fixed indentation
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* disabled variants with large stack usage in zephyr

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* added contributors
[trigger downstream]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* updated codeowners and contributors
[trigger downstream]
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

* moved test from ubuntu-focal-clang15 to ubuntu-jammy-clang14
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>

---------

Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>
Signed-off-by: Pravek Sharma <sharmapravek@gmail.com>
Co-authored-by: Pravek Sharma <sharmapravek@gmail.com>
 2024-09-03 15:45:37 -04:00
Basil Hess
dc4deaa4e1
Add ML-KEM / FIPS203 final (#1899) 
* Add ML-KEM
* Add ACVP vectors for ML-KEM
* Removes ML-KEM-ipd

---------
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
 2024-08-27 18:57:04 +02:00
Basil Hess
0f837591c7
Fix passes.json entries for MAYO (#1852) 
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
 2024-07-22 16:58:29 +02:00
Basil Hess
4cc88845e8
Add MAYO signature scheme from NIST onramp (#1707) 
Add MAYO signature scheme from NIST onramp, C and AVX2 versions
Add AES128CTR to common code

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
 2024-07-13 21:38:01 +02:00
Spencer Wilson
565ab5c5f1
Fix SPHINCS+ naming in CT json file [skip ci] (#1720) 2024-03-07 10:48:54 -05:00
Spencer Wilson
7e5dbaf2e8
Support Falcon PADDED format (#1710) 
Additionally:
- re-enable Falcon-1024 in weekly KAT tests
- Update Falcon licence documentation
- Update deprecated CircleCI image
 2024-03-06 12:02:43 -05:00
Basil Hess
60adf53107
Add ML-DSA-ipd and ML-KEM-ipd & NIST supplied test vectors (#1626) 
Pulls ML-DSA-ipd and ML-KEM-ipd
Adds test cases with NIST supplied test vectors for ML-DSA/ML-KEM
Adds aliases (ML-<name> are aliases of ML-<name>-ipd)
[trigger downstream]
 2024-02-19 10:28:28 +01:00
Spencer Wilson
da3dab860d
Update SPHINCS+ "clean" suppression files (#1683) 2024-02-07 13:30:32 -05:00
Spencer Wilson
dea517016c
Update McEliece suppression files for generic config (#1677) 2024-02-07 13:27:07 -05:00
cothan
b19697422f Update tests/constant_time/sig/passes/falcon_keygen 
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
 2024-01-02 12:28:13 -05:00
cothan
f123fdc73a fix space 2024-01-02 12:28:13 -05:00
cothan
985336718f fix avx2 constant time 2024-01-02 12:28:13 -05:00
cothan
acc915dfdf fix falcon generic 2024-01-02 12:28:13 -05:00
Spencer Wilson
acac4e998a
Fix BIKE constant-time errors (#1632) 
* Document BIKE CT issues

* Document / fix BIKE constant-time errors

* Revert "< 64" comparison change

* Add and use secure_cmpeq64_mask function

* Remove unnecessary static_assert
 2024-01-02 09:40:34 -05:00
Spencer Wilson
aeac3a441d
Pull new HQC implementation from upstream (#1585) 
* Update Sphincs+ PQClean patch

* Don't apply PQClean Dilithium and Kyber patches

* Run copy_from_upstream; don't apply Dilithium and Kyber changes

* Run HQC KATs with custom PRNG

* Satisfy astyle

* Add licence for common code

* Fix CI build errors

* Update HQC version, OQS version, and SOVERSION

* Move HQC PRNG into test file

* Satisfy astyle

* Fix SHA3 link error

* Reset HQC issues/passes

* fixup! Fix SHA3 link error

* fix kat_kem linkage to make HQC PR pass CI (#1601)

* fix kat_kem linkage

* remove armhf CI support

* Revert "remove armhf CI support"

This reverts commit af759bbf743bb3ecc2e7315cf10c1785e93bcc05.

---------

Co-authored-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
 2023-11-06 16:40:50 -05:00
Pravek Sharma
cdc8a971c6
Update Classic McEliece supression files (#1568) 2023-09-28 16:30:11 -04:00
Pravek Sharma
e6c650c2ef
Document Falcon constant time errors (#1552) 
* Document Falcon constant time errors.

* Update McEliece docs.

* Update Falcon YML to include aarch64 implementation

* Correct Falcon docs.

---------

Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
 2023-09-18 13:04:41 -04:00
Pravek Sharma
7ef422a6f5
Update Classic McEliece suppression files (#1541) 
* Update McEliece supression files.

* Update McEliece advisories.

* Update weekly constant time test workflow.

* Update weekly constant time test workflow. Update McEliece supression files.

* Update BIKE advisories.

* Restored BIKE advisories. Deleted unused BIKE supressions.
 2023-09-13 08:46:45 -04:00
Pravek Sharma
348ab36bbe
Update Classic McEliece supression files (#1527) 
* Update constant suppression supression files for Round 4 Classic McEliece.

* Update constant suppression supression files for Round 4 Classic McEliece.
 2023-08-15 10:48:54 -04:00
Basil Hess
be678118a5
kyber/dilithium aarch64 pull from pqclean + patches (#1512) 
* fix compiler warning/error in aes256_armv8.c

* pull pqclean+paches

* pull pqclean+paches

* remove old patches & update algorithm md/yml

* add new patches

* add patch with fixes for arm/kyber768+kyber1024

* update licenses in yamls and mds

* update kyber/dil suppression files

* removes superfluous pqclean Makefiles & updates copy_from_upstream script to handle this case

* update license infos
 2023-08-04 16:52:49 -04:00
Douglas Stebila
b2ad3f97c3
Fix SPHINCS+ constant-time suppression files (#1480) 
* Update SPHINCS+ AVX2 suppression files

* FIx names of SPHINCS+ algs in constant_time passes

* More SPHINCS+ suppressiosn

* SPHINCS SHAKE suppressions.

* Changed suppression annotations.

* Uncommented file name annotations.

---------

Co-authored-by: xvzcf <xvzcf@users.noreply.github.com>
 2023-06-06 20:21:25 -04:00
Goutam Tamvada
4d10a58abc
Renamed sphincs-sha256-X to sphincs-sha2-X and sphincs-shake256-X to sphincs-shake-X. (#1467) 
Co-authored-by: Douglas Stebila <dstebila@uwaterloo.ca>
 2023-05-17 13:12:03 -04:00
Douglas Stebila
35b1bf2704
Remove remaining references to SPHINCS+-Haraka, Kyber 90s, Dilithium-AES (#1465) 
* Delete Haraka references

* Delete Kyber90s and Dilithium-AES source code and references

* Delete more references to Dilithium-AES
 2023-05-16 12:27:12 -04:00
dkostic
8b24019ba0
Make BIKE decode function void to avoid ct issues (#1400) 
* Make decode function void to avoid ct issues

* Update test documentation

* add suppression files

* forgot to add the file

* typo fix

* Compute threshold without floating point operations

* Replace division by a constant with mul+shift

---------

Co-authored-by: dkostic <dkostic@amazon.com>
 2023-04-14 14:46:14 -04:00
Douglas Stebila
d61d81c526
Add constant time suppression for Falcon AVX2 (#1415) 2023-03-09 10:43:07 -05:00
Thom Wiggers
ec5c3be1ca
Update Falcon implementation (#1395) 
* Update Falcon implementation

* Update license and upstream documentation

* Update Falcon constant-time suppressions

* Whitespace tweak from linter [skip ci]

* Update Falcon spec version [skip ci]

---------

Co-authored-by: Douglas Stebila <dstebila@uwaterloo.ca>
 2023-03-01 11:03:38 -05:00
Jeevesh Rishi Dindyal (Sarvesh)
2e42595804
Add ntruprime (#1328) 
* Add back sntrup761
 2022-12-22 07:37:44 +01:00
Goutam Tamvada
a7e1b8a32f
Removed NTRU. (#1335) 2022-12-15 12:19:29 -05:00
Goutam Tamvada
f5d96cab5c
Removed SABER. (#1326) 2022-12-01 14:04:08 -05:00
Goutam Tamvada
c50d38e5a8
Removed NTRU-Prime. (#1325) 2022-11-29 07:31:53 +01:00
Goutam Tamvada
fac5a818ed
Removed the Picnic signature scheme. (#1323) 2022-11-28 15:29:10 -05:00
Goutam Tamvada
203c9c269b
Removed the rainbow signature scheme (#1321). 2022-11-28 11:34:59 -05:00
Sebastian Ramacher
542b2d0b6b
Cover SHA3/SHAKE-implementation specific code paths in Picnic suppression files (#1286) 2022-08-10 10:06:31 -04:00
Sebastian Ramacher
0511af68d7
Update to Picnic 3.0.17 (#1280) 
* Update to Picnic 3.0.17

* Added valgrind constant time execptions for picnic

Co-authored-by: Christian Paquin <cpaquin@microsoft.com>
 2022-08-08 17:02:00 +02:00
Michael Baentsch
84fde26ed2
Fixup dilithium-avx2 valgrind test file (#1283) 2022-08-06 17:43:24 -04:00
Douglas Stebila
1e47e14556
Remove SIDH and SIKE (#1272) 
Due to https://eprint.iacr.org/2022/975.

Fixes #1268.
 2022-08-03 10:19:28 -04:00
Douglas Stebila
478ccba970
Remove Rainbow level 1 (#1263) 
Fixes #1260
 2022-07-27 15:12:16 -04:00
Ted Eaton
feea2f3864
Issues and passes for aarch64 const time checks (#1214) 2022-05-25 10:47:34 -04:00
Douglas Stebila
bcc94dad5e
Suppress constant time check for public matrix generation on Kyber AVX2 (#1189) 
* Suppress constant time check for public matrix generation on Kyber AVX2

* Update tests/constant_time/kem/passes/kyber-90s

Co-authored-by: Basil Hess <basil.hess@gmail.com>

* Remove temporary CI job [skip ci]

Co-authored-by: Basil Hess <basil.hess@gmail.com>
 2022-02-16 20:19:19 -05:00
Christian Paquin
2af8ad71e2
Updated constant_time suppression files after picnic update (#1174) 2022-01-04 14:54:02 -05:00