Added comments of Windows compile warning ignores, and kept qtesla warnings (to be addressed in different pr)

This commit is contained in:
Christian Paquin 2020-03-17 17:56:15 -04:00
parent ee9680eaac
commit 9783c4d7d0
4 changed files with 4 additions and 4 deletions

View File

@ -19,6 +19,7 @@ if(CMAKE_C_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-missing-braces)
endif()
if(WIN32)
# ignore warning about cast from int to OQS_STATUS
add_compile_options(/wd4133)
endif()

View File

@ -10,6 +10,7 @@ if(CMAKE_C_COMPILER_ID MATCHES "Clang")
endif()
endif()
if(WIN32)
# ignore some warnings. picnic team confirmed these are safe to ignore; will be fixed eventually
add_compile_options(/wd4244 /wd4267 /wd4334)
endif()

View File

@ -29,9 +29,6 @@ if(CMAKE_HOST_SYSTEM_NAME STREQUAL "Linux"
else()
set(CPP_DEFS ${CPP_DEFS} portable)
endif()
if(WIN32)
add_compile_options(/wd4244)
endif()
add_library(qtesla OBJECT ${SRCS})
target_include_directories(qtesla PRIVATE external)

View File

@ -13,7 +13,8 @@ if (MINGW OR MSYS OR CYGWIN)
add_compile_options(-Wno-unused-parameter)
endif()
if(WIN32)
add_compile_options(/wd4244 /wd4996)
# ignore warning for test apps
add_compile_options(/wd4996 /wd4244)
endif()
if(NOT WIN32)