sharpetronics/liboqs
1
0
Fork 0
mirror of https://github.com/open-quantum-safe/liboqs.git synced 2025-10-04 00:02:01 -04:00
Code Issues Projects Releases Wiki Activity

Set the picnic sig_len value before calling the low-level signing API, and removed this setting from the corresponding unit test.

Browse Source
This commit is contained in:
Christian Paquin 2019-07-19 14:15:41 -04:00
parent 826ab71597
commit 1069667951
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/sig/picnic/sig_picnic.c
View File

@ -31,6 +31,18 @@ static size_t PUB_KEY_LEN[] = {
PICNIC_PUBLIC_KEY_SIZE(Picnic2_L3_FS),
PICNIC_PUBLIC_KEY_SIZE(Picnic2_L5_FS),
};
static size_t SIG_LEN[] = {
0,
PICNIC_SIGNATURE_SIZE(Picnic_L1_FS),
PICNIC_SIGNATURE_SIZE(Picnic_L1_UR),
PICNIC_SIGNATURE_SIZE(Picnic_L3_FS),
PICNIC_SIGNATURE_SIZE(Picnic_L3_UR),
PICNIC_SIGNATURE_SIZE(Picnic_L5_FS),
PICNIC_SIGNATURE_SIZE(Picnic_L5_UR),
PICNIC_SIGNATURE_SIZE(Picnic2_L1_FS),
PICNIC_SIGNATURE_SIZE(Picnic2_L3_FS),
PICNIC_SIGNATURE_SIZE(Picnic2_L5_FS),
};
static OQS_STATUS common_picnic_keypair(picnic_params_t parameters, uint8_t *priv, uint8_t *pub) {
if (priv == NULL || pub == NULL) {
@ -63,6 +75,9 @@ static OQS_STATUS common_picnic_sign(picnic_params_t parameters, const uint8_t *
return OQS_ERROR;
}
picnic_privatekey_t sk;
// picnic2's signature code checks that the sig_len value is large enough, but the OQS
// API treats this as an output parameters, so we set it here
*sig_len = SIG_LEN[parameters];
// deserialize the private key
if (picnic_read_private_key(&sk, priv, PRIV_KEY_LEN[parameters]) != 0) {
return OQS_ERROR;

1
tests/test_sig.c
View File

@ -32,7 +32,6 @@ static OQS_STATUS sig_test_correctness(const char *method_name) {
secret_key = malloc(sig->length_secret_key);
message = malloc(message_len);
signature = malloc(sig->length_signature);
signature_len = sig->length_signature;
if ((public_key == NULL) || (secret_key == NULL) || (message == NULL) || (signature == NULL)) {
fprintf(stderr, "ERROR: malloc failed\n");