Fix rubocop issues

This commit is contained in:
Andriy Byalyk 2020-10-04 15:32:33 +03:00
parent 32039e4858
commit eced6e13e2
2 changed files with 10 additions and 9 deletions

View File

@ -21,15 +21,16 @@ end
class ActorSerializer < UserSerializer class ActorSerializer < UserSerializer
set_type :actor set_type :actor
attribute :email, if: ->(_object, params) { params[:if_conditionals_off].nil? }, attribute :email,
unless: -> (_object, params) { params[:unless_conditionals_off].present? } if: ->(_, params) { params[:if_conditionals_off].nil? },
unless: ->(_, params) { params[:unless_conditionals_off].present? }
has_many( has_many(
:played_movies, :played_movies,
serializer: :movie, serializer: :movie,
links: :movie_urls, links: :movie_urls,
if: ->(_object, params) { params[:if_conditionals_off].nil? }, if: ->(_object, params) { params[:if_conditionals_off].nil? },
unless: -> (_object, params) { params[:unless_conditionals_off].present? } unless: ->(_object, params) { params[:unless_conditionals_off].present? }
) do |object| ) do |object|
object.movies object.movies
end end

View File

@ -104,18 +104,18 @@ RSpec.describe JSONAPI::Serializer do
context 'with `unless` conditions' do context 'with `unless` conditions' do
let(:params) do let(:params) do
{ {
include: ['actors'], include: ['actors'],
params: { unless_conditionals_off: 'yes' } params: { unless_conditionals_off: 'yes' }
} }
end end
it do it do
movie.actors.each do |actor| movie.actors.each do |actor|
expect(serialized['included']).not_to include( expect(serialized['included']).not_to include(
have_type('actor') have_type('actor')
.and(have_id(actor.uid)) .and(have_id(actor.uid))
.and(have_relationship('played_movies')) .and(have_relationship('played_movies'))
) )
end end
end end
end end