From 1b3b533b4064e74f28397ce9178bbff67cf4d3b0 Mon Sep 17 00:00:00 2001 From: Dillon Welch Date: Wed, 25 Apr 2018 23:34:36 -0700 Subject: [PATCH] Don't allocate variables if we're not going to use them --- lib/fast_jsonapi/serialization_core.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/fast_jsonapi/serialization_core.rb b/lib/fast_jsonapi/serialization_core.rb index 9682439..b82ab6e 100644 --- a/lib/fast_jsonapi/serialization_core.rb +++ b/lib/fast_jsonapi/serialization_core.rb @@ -113,12 +113,14 @@ module FastJsonapi def get_included_records(record, includes_list, known_included_objects) includes_list.each_with_object([]) do |item, included_records| - object_method_name = @relationships_to_serialize[item][:object_method_name] + included_objects = record.send( + @relationships_to_serialize[item][:object_method_name] + ) + next if included_objects.blank? + record_type = @relationships_to_serialize[item][:record_type] serializer = @relationships_to_serialize[item][:serializer].to_s.constantize relationship_type = @relationships_to_serialize[item][:relationship_type] - included_objects = record.send(object_method_name) - next if included_objects.blank? included_objects = [included_objects] unless relationship_type == :has_many included_objects.each do |inc_obj| code = "#{record_type}_#{inc_obj.id}"