fixed test match

Revert "dns errors: raise error immediately on nxdomain error"

Closes #233

See merge request os85/httpx!250

doc/release_notes/0_23_1.md

@@ -0,0 +1,5 @@
+# 0.23.1
+
+## Bugfixes
+
+* fixed regression causing dns candidate names not being tried after first one fails.

integration_tests/sentry_test.rb

@@ -100,7 +100,7 @@ if RUBY_VERSION >= "2.4.0"
       verify_spans(transaction, response, verb: "GET")
       crumb = Sentry.get_current_scope.breadcrumbs.peek
       assert crumb.category == "httpx"
-      assert crumb.data == { error: "name or service not known (unexisting)", method: "GET", url: uri.to_s }
+      assert crumb.data == { error: "name or service not known", method: "GET", url: uri.to_s }
     end
 
     private

lib/httpx/resolver/native.rb

@@ -244,10 +244,14 @@ module HTTPX
       when :no_domain_found
         # Indicates no such domain was found.
         hostname, connection = @queries.first
-        reset_hostname(hostname)
+        reset_hostname(hostname, reset_candidates: false)
 
-        @connections.delete(connection)
+        unless @queries.value?(connection)
-        raise NativeResolveError.new(connection, connection.origin.host, "name or service not known (#{hostname})")
+          @connections.delete(connection)
+          raise NativeResolveError.new(connection, connection.origin.host, "name or service not known")
+        end
+
+        resolve
       when :message_truncated
         # TODO: what to do if it's already tcp??
         return if @socket_type == :tcp

lib/httpx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTPX
-  VERSION = "0.23.0"
+  VERSION = "0.23.1"
 end