Compare commits

..

No commits in common. "1765ddf0f8fdfd658579518f09b72706e80c96f7" and "9582e17370c5a0cbdc197de4676582ba9ad72b62" have entirely different histories.

4 changed files with 5 additions and 14 deletions

View File

@ -1,5 +0,0 @@
# 0.23.1
## Bugfixes
* fixed regression causing dns candidate names not being tried after first one fails.

View File

@ -100,7 +100,7 @@ if RUBY_VERSION >= "2.4.0"
verify_spans(transaction, response, verb: "GET")
crumb = Sentry.get_current_scope.breadcrumbs.peek
assert crumb.category == "httpx"
assert crumb.data == { error: "name or service not known", method: "GET", url: uri.to_s }
assert crumb.data == { error: "name or service not known (unexisting)", method: "GET", url: uri.to_s }
end
private

View File

@ -244,14 +244,10 @@ module HTTPX
when :no_domain_found
# Indicates no such domain was found.
hostname, connection = @queries.first
reset_hostname(hostname, reset_candidates: false)
reset_hostname(hostname)
unless @queries.value?(connection)
@connections.delete(connection)
raise NativeResolveError.new(connection, connection.origin.host, "name or service not known")
end
resolve
@connections.delete(connection)
raise NativeResolveError.new(connection, connection.origin.host, "name or service not known (#{hostname})")
when :message_truncated
# TODO: what to do if it's already tcp??
return if @socket_type == :tcp

View File

@ -1,5 +1,5 @@
# frozen_string_literal: true
module HTTPX
VERSION = "0.23.1"
VERSION = "0.23.0"
end