sharpetronics/httpx
1
0
Fork 0
mirror of https://github.com/HoneyryderChuck/httpx.git synced 2025-10-09 00:02:50 -04:00
Code Issues Projects Releases Wiki Activity

removing internal with_cookies usage

Browse Source
This commit is contained in:
HoneyryderChuck 2021-07-15 10:48:43 +01:00
parent 2ea8b2ec2d
commit f9f13abb81
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/support/requests/plugins/cookies.rb
View File

@ -12,7 +12,7 @@ module Requests
assert body.key?("cookies") assert body.key?("cookies")
assert body["cookies"].empty? assert body["cookies"].empty?
session_response = session.with_cookies("abc" => "def").get(cookies_uri) session_response = session.with(cookies: { "abc" => "def" }).get(cookies_uri)
body = json_body(session_response) body = json_body(session_response)
assert body.key?("cookies") assert body.key?("cookies")
assert body["cookies"]["abc"] == "def", "abc wasn't properly set" assert body["cookies"]["abc"] == "def", "abc wasn't properly set"
@ -20,7 +20,7 @@ module Requests
def test_plugin_cookies_get_with_hash def test_plugin_cookies_get_with_hash
session = HTTPX.plugin(:cookies) session = HTTPX.plugin(:cookies)
session_response = session.with_cookies([{ "name" => "abc", "value" => "def" }]).get(cookies_uri) session_response = session.with(cookies: [{ "name" => "abc", "value" => "def" }]).get(cookies_uri)
body = json_body(session_response) body = json_body(session_response)
assert body.key?("cookies") assert body.key?("cookies")
assert body["cookies"]["abc"] == "def", "abc wasn't properly set" assert body["cookies"]["abc"] == "def", "abc wasn't properly set"
@ -28,7 +28,7 @@ module Requests
def test_plugin_cookies_get_with_cookie def test_plugin_cookies_get_with_cookie
session = HTTPX.plugin(:cookies) session = HTTPX.plugin(:cookies)
session_response = session.with_cookies([HTTPX::Plugins::Cookies::Cookie.new("abc", "def")]).get(cookies_uri) session_response = session.with(cookies: [HTTPX::Plugins::Cookies::Cookie.new("abc", "def")]).get(cookies_uri)
body = json_body(session_response) body = json_body(session_response)
assert body.key?("cookies") assert body.key?("cookies")
assert body["cookies"]["abc"] == "def", "abc wasn't properly set" assert body["cookies"]["abc"] == "def", "abc wasn't properly set"
@ -49,19 +49,19 @@ module Requests
verify_cookies(body["cookies"], session_cookies) verify_cookies(body["cookies"], session_cookies)
# second request reuses the session # second request reuses the session
extra_cookie_response = session.with_cookies("e" => "f").get(cookies_uri) extra_cookie_response = session.with(cookies: { "e" => "f" }).get(cookies_uri)
body = json_body(extra_cookie_response) body = json_body(extra_cookie_response)
assert body.key?("cookies") assert body.key?("cookies")
verify_cookies(body["cookies"], session_cookies.merge("e" => "f")) verify_cookies(body["cookies"], session_cookies.merge("e" => "f"))
# redirect to a different origin only uses the option cookies # redirect to a different origin only uses the option cookies
other_origin_response = session.with_cookies("e" => "f").get(redirect_uri(origin("google.com"))) other_origin_response = session.with(cookies: { "e" => "f" }).get(redirect_uri(origin("google.com")))
verify_status(other_origin_response, 302) verify_status(other_origin_response, 302)
assert !other_origin_response.headers.key?("set-cookie"), "cookies should not transition to next origin" assert !other_origin_response.headers.key?("set-cookie"), "cookies should not transition to next origin"
end end
def test_cookies_wrap def test_cookies_wrap
session = HTTPX.plugin(:cookies).with_cookies("abc" => "def") session = HTTPX.plugin(:cookies).with(cookies: { "abc" => "def" })
session.wrap do |_http| session.wrap do |_http|
set_cookie_uri = cookies_set_uri("123" => "456") set_cookie_uri = cookies_set_uri("123" => "456")