sharpetronics/httpx
1
0
Fork 0
mirror of https://github.com/HoneyryderChuck/httpx.git synced 2025-12-07 00:00:31 -05:00
Code Issues Projects Releases Wiki Activity

using callbacks_for? on happy eyeballs error detection path

Browse Source
This commit is contained in:
HoneyryderChuck 2023-03-28 01:39:41 +01:00
parent 73f0d609b0
commit 707e653883
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/httpx/callbacks.rb
View File

@ -22,12 +22,12 @@ module HTTPX
callbacks(type).delete_if { |pr| :delete == pr.call(*args) } # rubocop:disable Style/YodaCondition callbacks(type).delete_if { |pr| :delete == pr.call(*args) } # rubocop:disable Style/YodaCondition
end end
protected
def callbacks_for?(type) def callbacks_for?(type)
@callbacks.key?(type) && !@callbacks[type].empty? @callbacks.key?(type) && @callbacks[type].any?
end end
protected
def callbacks(type = nil) def callbacks(type = nil)
return @callbacks unless type return @callbacks unless type

2
lib/httpx/connection.rb
View File

@ -538,7 +538,7 @@ module HTTPX
# connect errors, exit gracefully # connect errors, exit gracefully
error = ConnectionError.new(e.message) error = ConnectionError.new(e.message)
error.set_backtrace(e.backtrace) error.set_backtrace(e.backtrace)
connecting? && callbacks(:connect_error).any? ? emit(:connect_error, error) : handle_error(error) connecting? && callbacks_for?(:connect_error) ? emit(:connect_error, error) : handle_error(error)
@state = :closed @state = :closed
emit(:close) emit(:close)
rescue TLSError => e rescue TLSError => e