sharpetronics/httpx
1
0
Fork 0
mirror of https://github.com/HoneyryderChuck/httpx.git synced 2025-10-04 00:00:37 -04:00
Code Issues Projects Releases Wiki Activity

Merge branch 'gh-98' into 'master'

Browse Source 
pool fix: when connection is acquired after waiting on it, return it...

See merge request os85/httpx!402
This commit is contained in:
HoneyryderChuck 2025-09-01 09:16:07 +00:00
commit 1c880127d7
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/httpx/pool.rb
View File

@ -51,18 +51,21 @@ module HTTPX
# this takes precedence over per-origin
@max_connections_cond.wait(@connection_mtx, @pool_timeout)
acquire_connection(uri, options) || begin
if @connections_counter == @max_connections
# if no matching usable connection was found, the pool will make room and drop a closed connection. if none is found,
# this means that all of them are persistent or being used, so raise a timeout error.
conn = @connections.find { |c| c.state == :closed }
raise PoolTimeoutError.new(@pool_timeout,
"Timed out after #{@pool_timeout} seconds while waiting for a connection") unless conn
drop_connection(conn)
end
if (conn = acquire_connection(uri, options))
return conn
end
if @connections_counter == @max_connections
# if no matching usable connection was found, the pool will make room and drop a closed connection. if none is found,
# this means that all of them are persistent or being used, so raise a timeout error.
conn = @connections.find { |c| c.state == :closed }
raise PoolTimeoutError.new(@pool_timeout,
"Timed out after #{@pool_timeout} seconds while waiting for a connection") unless conn
drop_connection(conn)
end
end
if @origin_counters[uri.origin] == @max_connections_per_origin