sharpetronics/httpx
1
0
Fork 0
mirror of https://github.com/HoneyryderChuck/httpx.git synced 2025-10-08 00:02:42 -04:00
Code Issues Projects Releases Wiki Activity

adding :close_handshake_timeout timeout option

Browse Source 
used to monitor readiness of connection to write the last goaway frame from HTTP/2
This commit is contained in:
HoneyryderChuck 2023-11-09 13:21:29 +00:00
parent 7345c19d5d
commit 100394b29c
4 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/httpx/connection/http2.rb
View File

@ -73,8 +73,11 @@ module HTTPX
end end
def close def close
@connection.goaway unless @connection.state == :closed
emit(:close) emit(:close)
unless @connection.state == :closed
@connection.goaway
emit(:timeout, @options.timeout[:close_handshake_timeout])
end
end end
def empty? def empty?

2
lib/httpx/options.rb
View File

@ -11,6 +11,7 @@ module HTTPX
MAX_BODY_THRESHOLD_SIZE = (1 << 10) * 112 # 112K MAX_BODY_THRESHOLD_SIZE = (1 << 10) * 112 # 112K
KEEP_ALIVE_TIMEOUT = 20 KEEP_ALIVE_TIMEOUT = 20
SETTINGS_TIMEOUT = 10 SETTINGS_TIMEOUT = 10
CLOSE_HANDSHAKE_TIMEOUT = 10
CONNECT_TIMEOUT = READ_TIMEOUT = WRITE_TIMEOUT = 60 CONNECT_TIMEOUT = READ_TIMEOUT = WRITE_TIMEOUT = 60
REQUEST_TIMEOUT = OPERATION_TIMEOUT = nil REQUEST_TIMEOUT = OPERATION_TIMEOUT = nil
@ -39,6 +40,7 @@ module HTTPX
:timeout => { :timeout => {
connect_timeout: CONNECT_TIMEOUT, connect_timeout: CONNECT_TIMEOUT,
settings_timeout: SETTINGS_TIMEOUT, settings_timeout: SETTINGS_TIMEOUT,
close_handshake_timeout: CLOSE_HANDSHAKE_TIMEOUT,
operation_timeout: OPERATION_TIMEOUT, operation_timeout: OPERATION_TIMEOUT,
keep_alive_timeout: KEEP_ALIVE_TIMEOUT, keep_alive_timeout: KEEP_ALIVE_TIMEOUT,
read_timeout: READ_TIMEOUT, read_timeout: READ_TIMEOUT,

3
sig/options.rbs
View File

@ -9,9 +9,10 @@ module HTTPX
OPERATION_TIMEOUT: Integer OPERATION_TIMEOUT: Integer
KEEP_ALIVE_TIMEOUT: Integer KEEP_ALIVE_TIMEOUT: Integer
SETTINGS_TIMEOUT: Integer SETTINGS_TIMEOUT: Integer
CLOSE_HANDSHAKE_TIMEOUT: Integer
DEFAULT_OPTIONS: Hash[Symbol, untyped] DEFAULT_OPTIONS: Hash[Symbol, untyped]
type timeout_type = :connect_timeout | :settings_timeout | :operation_timeout | :keep_alive_timeout | :read_timeout | :write_timeout | :request_timeout type timeout_type = :connect_timeout | :settings_timeout | :close_handshake_timeout | :operation_timeout | :keep_alive_timeout | :read_timeout | :write_timeout | :request_timeout
type timeout = Hash[timeout_type, Numeric?] type timeout = Hash[timeout_type, Numeric?]
def self.new: (?options) -> instance def self.new: (?options) -> instance

1
test/options_test.rb
View File

@ -80,6 +80,7 @@ class OptionsTest < Minitest::Test
:timeout => { :timeout => {
connect_timeout: 60, connect_timeout: 60,
settings_timeout: 10, settings_timeout: 10,
close_handshake_timeout: 10,
operation_timeout: nil, operation_timeout: nil,
keep_alive_timeout: 20, keep_alive_timeout: 20,
read_timeout: 60, read_timeout: 60,