mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 00:02:59 -04:00 
			
		
		
		
	Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			180 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			180 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2018 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package integrations
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"net/http"
 | |
| 	"strings"
 | |
| 	"testing"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models"
 | |
| 	"code.gitea.io/gitea/modules/git"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func createNewReleaseUsingAPI(t *testing.T, session *TestSession, token string, owner *models.User, repo *models.Repository, name, target, title, desc string) *api.Release {
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases?token=%s",
 | |
| 		owner.Name, repo.Name, token)
 | |
| 	req := NewRequestWithJSON(t, "POST", urlStr, &api.CreateReleaseOption{
 | |
| 		TagName:      name,
 | |
| 		Title:        title,
 | |
| 		Note:         desc,
 | |
| 		IsDraft:      false,
 | |
| 		IsPrerelease: false,
 | |
| 		Target:       target,
 | |
| 	})
 | |
| 	resp := session.MakeRequest(t, req, http.StatusCreated)
 | |
| 
 | |
| 	var newRelease api.Release
 | |
| 	DecodeJSON(t, resp, &newRelease)
 | |
| 	models.AssertExistsAndLoadBean(t, &models.Release{
 | |
| 		ID:      newRelease.ID,
 | |
| 		TagName: newRelease.TagName,
 | |
| 		Title:   newRelease.Title,
 | |
| 		Note:    newRelease.Note,
 | |
| 	})
 | |
| 
 | |
| 	return &newRelease
 | |
| }
 | |
| 
 | |
| func TestAPICreateAndUpdateRelease(t *testing.T) {
 | |
| 	defer prepareTestEnv(t)()
 | |
| 
 | |
| 	repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 1}).(*models.Repository)
 | |
| 	owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User)
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session)
 | |
| 
 | |
| 	gitRepo, err := git.OpenRepository(repo.RepoPath())
 | |
| 	assert.NoError(t, err)
 | |
| 	defer gitRepo.Close()
 | |
| 
 | |
| 	err = gitRepo.CreateTag("v0.0.1", "master")
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	target, err := gitRepo.GetTagCommitID("v0.0.1")
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	newRelease := createNewReleaseUsingAPI(t, session, token, owner, repo, "v0.0.1", target, "v0.0.1", "test")
 | |
| 
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases/%d?token=%s",
 | |
| 		owner.Name, repo.Name, newRelease.ID, token)
 | |
| 	req := NewRequest(t, "GET", urlStr)
 | |
| 	resp := session.MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	var release api.Release
 | |
| 	DecodeJSON(t, resp, &release)
 | |
| 
 | |
| 	assert.Equal(t, newRelease.TagName, release.TagName)
 | |
| 	assert.Equal(t, newRelease.Title, release.Title)
 | |
| 	assert.Equal(t, newRelease.Note, release.Note)
 | |
| 
 | |
| 	req = NewRequestWithJSON(t, "PATCH", urlStr, &api.EditReleaseOption{
 | |
| 		TagName:      release.TagName,
 | |
| 		Title:        release.Title,
 | |
| 		Note:         "updated",
 | |
| 		IsDraft:      &release.IsDraft,
 | |
| 		IsPrerelease: &release.IsPrerelease,
 | |
| 		Target:       release.Target,
 | |
| 	})
 | |
| 	resp = session.MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	DecodeJSON(t, resp, &newRelease)
 | |
| 	models.AssertExistsAndLoadBean(t, &models.Release{
 | |
| 		ID:      newRelease.ID,
 | |
| 		TagName: newRelease.TagName,
 | |
| 		Title:   newRelease.Title,
 | |
| 		Note:    newRelease.Note,
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func TestAPICreateReleaseToDefaultBranch(t *testing.T) {
 | |
| 	defer prepareTestEnv(t)()
 | |
| 
 | |
| 	repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 1}).(*models.Repository)
 | |
| 	owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User)
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session)
 | |
| 
 | |
| 	createNewReleaseUsingAPI(t, session, token, owner, repo, "v0.0.1", "", "v0.0.1", "test")
 | |
| }
 | |
| 
 | |
| func TestAPICreateReleaseToDefaultBranchOnExistingTag(t *testing.T) {
 | |
| 	defer prepareTestEnv(t)()
 | |
| 
 | |
| 	repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 1}).(*models.Repository)
 | |
| 	owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User)
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session)
 | |
| 
 | |
| 	gitRepo, err := git.OpenRepository(repo.RepoPath())
 | |
| 	assert.NoError(t, err)
 | |
| 	defer gitRepo.Close()
 | |
| 
 | |
| 	err = gitRepo.CreateTag("v0.0.1", "master")
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	createNewReleaseUsingAPI(t, session, token, owner, repo, "v0.0.1", "", "v0.0.1", "test")
 | |
| }
 | |
| 
 | |
| func TestAPIGetReleaseByTag(t *testing.T) {
 | |
| 	defer prepareTestEnv(t)()
 | |
| 
 | |
| 	repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 1}).(*models.Repository)
 | |
| 	owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User)
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 
 | |
| 	tag := "v1.1"
 | |
| 
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/%s",
 | |
| 		owner.Name, repo.Name, tag)
 | |
| 
 | |
| 	req := NewRequestf(t, "GET", urlStr)
 | |
| 	resp := session.MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	var release *api.Release
 | |
| 	DecodeJSON(t, resp, &release)
 | |
| 
 | |
| 	assert.Equal(t, "testing-release", release.Title)
 | |
| 
 | |
| 	nonexistingtag := "nonexistingtag"
 | |
| 
 | |
| 	urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/%s",
 | |
| 		owner.Name, repo.Name, nonexistingtag)
 | |
| 
 | |
| 	req = NewRequestf(t, "GET", urlStr)
 | |
| 	resp = session.MakeRequest(t, req, http.StatusNotFound)
 | |
| 
 | |
| 	var err *api.APIError
 | |
| 	DecodeJSON(t, resp, &err)
 | |
| 	assert.True(t, strings.HasPrefix(err.Message, "release tag does not exist"))
 | |
| }
 | |
| 
 | |
| func TestAPIDeleteTagByName(t *testing.T) {
 | |
| 	defer prepareTestEnv(t)()
 | |
| 
 | |
| 	repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 1}).(*models.Repository)
 | |
| 	owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User)
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session)
 | |
| 
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/delete-tag?token=%s",
 | |
| 		owner.Name, repo.Name, token)
 | |
| 
 | |
| 	req := NewRequestf(t, http.MethodDelete, urlStr)
 | |
| 	_ = session.MakeRequest(t, req, http.StatusNoContent)
 | |
| 
 | |
| 	// Make sure that actual releases can't be deleted outright
 | |
| 	createNewReleaseUsingAPI(t, session, token, owner, repo, "release-tag", "", "Release Tag", "test")
 | |
| 	urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/release-tag?token=%s",
 | |
| 		owner.Name, repo.Name, token)
 | |
| 
 | |
| 	req = NewRequestf(t, http.MethodDelete, urlStr)
 | |
| 	_ = session.MakeRequest(t, req, http.StatusConflict)
 | |
| }
 |