Merge a65f0f697040b6ec09f17713c7ab9239d725abd7 into b907b9fb1a1a792b9bc25112fa3eb3f8d2fb4397

allow comments on non-diff lines (#32257 )
Signed-off-by: abhishek818 <abhishekguptaatweb17@gmail.com>
2025-10-03 00:02:14 -04:00 · 2025-10-01 09:50:18 +02:00 · 2024-10-15 00:10:03 +05:30
2 changed files with 2 additions and 2 deletions
--- a/services/gitdiff/gitdiff.go
+++ b/services/gitdiff/gitdiff.go
@ -133,7 +133,7 @@ func (d *DiffLine) GetHTMLDiffLineType() string {

 // CanComment returns whether a line can get commented
 func (d *DiffLine) CanComment() bool {
-	return len(d.Comments) == 0 && d.Type != DiffLineSection
+	return len(d.Comments) == 0
 }

 // GetCommentSide returns the comment side of the first comment, if not set returns empty string
--- a/services/gitdiff/gitdiff_test.go
+++ b/services/gitdiff/gitdiff_test.go
@ -586,7 +586,7 @@ func TestDiff_LoadCommentsWithOutdated(t *testing.T) {
 }

 func TestDiffLine_CanComment(t *testing.T) {
-	assert.False(t, (&DiffLine{Type: DiffLineSection}).CanComment())
+	assert.True(t, (&DiffLine{Type: DiffLineSection}).CanComment())
 	assert.False(t, (&DiffLine{Type: DiffLineAdd, Comments: []*issues_model.Comment{{Content: "bla"}}}).CanComment())
 	assert.True(t, (&DiffLine{Type: DiffLineAdd}).CanComment())
 	assert.True(t, (&DiffLine{Type: DiffLineDel}).CanComment())
Author	SHA1	Message	Date
Abhishek Kumar Gupta	d4134b8050	Merge a65f0f697040b6ec09f17713c7ab9239d725abd7 into b907b9fb1a1a792b9bc25112fa3eb3f8d2fb4397	2025-10-01 09:50:18 +02:00
abhishek818	a65f0f6970	allow comments on non-diff lines (#32257 ) Signed-off-by: abhishek818 <abhishekguptaatweb17@gmail.com>	2024-10-15 00:10:03 +05:30