models/db/engine_test.go

@@ -12,8 +12,6 @@ import (
 	"code.gitea.io/gitea/models/unittest"
 	"code.gitea.io/gitea/modules/setting"
 
-	_ "code.gitea.io/gitea/cmd" // for TestPrimaryKeys
-
 	"github.com/stretchr/testify/assert"
 )
 
@@ -53,34 +51,3 @@ func TestDeleteOrphanedObjects(t *testing.T) {
 	assert.NoError(t, err)
 	assert.EqualValues(t, countBefore, countAfter)
 }
-
-func TestPrimaryKeys(t *testing.T) {
-	// Some dbs require that all tables have primary keys, see
-	//   https://github.com/go-gitea/gitea/issues/21086
-	//   https://github.com/go-gitea/gitea/issues/16802
-	// To avoid creating tables without primary key again, this test will check them.
-	// Import "code.gitea.io/gitea/cmd" to make sure each db.RegisterModel in init functions has been called.
-
-	beans, err := db.NamesToBean()
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	whitelist := map[string]string{
-		"the_table_name_to_skip_checking": "Write a note here to explain why",
-	}
-
-	for _, bean := range beans {
-		table, err := db.TableInfo(bean)
-		if err != nil {
-			t.Fatal(err)
-		}
-		if why, ok := whitelist[table.Name]; ok {
-			t.Logf("ignore %q because %q", table.Name, why)
-			continue
-		}
-		if len(table.PrimaryKeys) == 0 {
-			t.Errorf("table %q has no primary key", table.Name)
-		}
-	}
-}

models/fixtures/foreign_reference.yml

@@ -0,0 +1 @@
+[] # empty

models/foreignreference/error.go

@@ -0,0 +1,52 @@
+// Copyright 2022 Gitea. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package foreignreference
+
+import (
+	"fmt"
+
+	"code.gitea.io/gitea/modules/util"
+)
+
+// ErrLocalIndexNotExist represents a "LocalIndexNotExist" kind of error.
+type ErrLocalIndexNotExist struct {
+	RepoID       int64
+	ForeignIndex int64
+	Type         string
+}
+
+// ErrLocalIndexNotExist checks if an error is a ErrLocalIndexNotExist.
+func IsErrLocalIndexNotExist(err error) bool {
+	_, ok := err.(ErrLocalIndexNotExist)
+	return ok
+}
+
+func (err ErrLocalIndexNotExist) Error() string {
+	return fmt.Sprintf("repository %d has no LocalIndex for ForeignIndex %d of type %s", err.RepoID, err.ForeignIndex, err.Type)
+}
+
+func (err ErrLocalIndexNotExist) Unwrap() error {
+	return util.ErrNotExist
+}
+
+// ErrForeignIndexNotExist represents a "ForeignIndexNotExist" kind of error.
+type ErrForeignIndexNotExist struct {
+	RepoID     int64
+	LocalIndex int64
+	Type       string
+}
+
+// ErrForeignIndexNotExist checks if an error is a ErrForeignIndexNotExist.
+func IsErrForeignIndexNotExist(err error) bool {
+	_, ok := err.(ErrForeignIndexNotExist)
+	return ok
+}
+
+func (err ErrForeignIndexNotExist) Error() string {
+	return fmt.Sprintf("repository %d has no ForeignIndex for LocalIndex %d of type %s", err.RepoID, err.LocalIndex, err.Type)
+}
+
+func (err ErrForeignIndexNotExist) Unwrap() error {
+	return util.ErrNotExist
+}

models/foreignreference/foreignreference.go

@@ -0,0 +1,31 @@
+// Copyright 2022 Gitea. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package foreignreference
+
+import (
+	"code.gitea.io/gitea/models/db"
+)
+
+// Type* are valid values for the Type field of ForeignReference
+const (
+	TypeIssue         = "issue"
+	TypePullRequest   = "pull_request"
+	TypeComment       = "comment"
+	TypeReview        = "review"
+	TypeReviewComment = "review_comment"
+	TypeRelease       = "release"
+)
+
+// ForeignReference represents external references
+type ForeignReference struct {
+	// RepoID is the first column in all indices. now we only need 2 indices: (repo, local) and (repo, foreign, type)
+	RepoID       int64  `xorm:"UNIQUE(repo_foreign_type) INDEX(repo_local)" `
+	LocalIndex   int64  `xorm:"INDEX(repo_local)"` // the resource key inside Gitea, it can be IssueIndex, or some model ID.
+	ForeignIndex string `xorm:"INDEX UNIQUE(repo_foreign_type)"`
+	Type         string `xorm:"VARCHAR(16) INDEX UNIQUE(repo_foreign_type)"`
+}
+
+func init() {
+	db.RegisterModel(new(ForeignReference))
+}

models/issues/issue.go

@@ -9,9 +9,11 @@ import (
 	"fmt"
 	"regexp"
 	"sort"
+	"strconv"
 	"strings"
 
 	"code.gitea.io/gitea/models/db"
+	"code.gitea.io/gitea/models/foreignreference"
 	"code.gitea.io/gitea/models/organization"
 	"code.gitea.io/gitea/models/perm"
 	access_model "code.gitea.io/gitea/models/perm/access"
@@ -134,11 +136,12 @@ type Issue struct {
 	UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
 	ClosedUnix  timeutil.TimeStamp `xorm:"INDEX"`
 
-	Attachments      []*repo_model.Attachment `xorm:"-"`
+	Attachments      []*repo_model.Attachment           `xorm:"-"`
-	Comments         []*Comment               `xorm:"-"`
+	Comments         []*Comment                         `xorm:"-"`
-	Reactions        ReactionList             `xorm:"-"`
+	Reactions        ReactionList                       `xorm:"-"`
-	TotalTrackedTime int64                    `xorm:"-"`
+	TotalTrackedTime int64                              `xorm:"-"`
-	Assignees        []*user_model.User       `xorm:"-"`
+	Assignees        []*user_model.User                 `xorm:"-"`
+	ForeignReference *foreignreference.ForeignReference `xorm:"-"`
 
 	// IsLocked limits commenting abilities to users on an issue
 	// with write access
@@ -318,6 +321,29 @@ func (issue *Issue) loadReactions(ctx context.Context) (err error) {
 	return nil
 }
 
+func (issue *Issue) loadForeignReference(ctx context.Context) (err error) {
+	if issue.ForeignReference != nil {
+		return nil
+	}
+	reference := &foreignreference.ForeignReference{
+		RepoID:     issue.RepoID,
+		LocalIndex: issue.Index,
+		Type:       foreignreference.TypeIssue,
+	}
+	has, err := db.GetEngine(ctx).Get(reference)
+	if err != nil {
+		return err
+	} else if !has {
+		return foreignreference.ErrForeignIndexNotExist{
+			RepoID:     issue.RepoID,
+			LocalIndex: issue.Index,
+			Type:       foreignreference.TypeIssue,
+		}
+	}
+	issue.ForeignReference = reference
+	return nil
+}
+
 // LoadMilestone load milestone of this issue.
 func (issue *Issue) LoadMilestone(ctx context.Context) (err error) {
 	if (issue.Milestone == nil || issue.Milestone.ID != issue.MilestoneID) && issue.MilestoneID > 0 {
@@ -380,6 +406,10 @@ func (issue *Issue) LoadAttributes(ctx context.Context) (err error) {
 		}
 	}
 
+	if err = issue.loadForeignReference(ctx); err != nil && !foreignreference.IsErrForeignIndexNotExist(err) {
+		return err
+	}
+
 	return issue.loadReactions(ctx)
 }
 
@@ -1067,6 +1097,26 @@ func GetIssueByIndex(repoID, index int64) (*Issue, error) {
 	return issue, nil
 }
 
+// GetIssueByForeignIndex returns raw issue by foreign ID
+func GetIssueByForeignIndex(ctx context.Context, repoID, foreignIndex int64) (*Issue, error) {
+	reference := &foreignreference.ForeignReference{
+		RepoID:       repoID,
+		ForeignIndex: strconv.FormatInt(foreignIndex, 10),
+		Type:         foreignreference.TypeIssue,
+	}
+	has, err := db.GetEngine(ctx).Get(reference)
+	if err != nil {
+		return nil, err
+	} else if !has {
+		return nil, foreignreference.ErrLocalIndexNotExist{
+			RepoID:       repoID,
+			ForeignIndex: foreignIndex,
+			Type:         foreignreference.TypeIssue,
+		}
+	}
+	return GetIssueByIndex(repoID, reference.LocalIndex)
+}
+
 // GetIssueWithAttrsByIndex returns issue by index in a repository.
 func GetIssueWithAttrsByIndex(repoID, index int64) (*Issue, error) {
 	issue, err := GetIssueByIndex(repoID, index)

models/issues/issue_test.go

@@ -7,11 +7,13 @@ import (
 	"context"
 	"fmt"
 	"sort"
+	"strconv"
 	"sync"
 	"testing"
 	"time"
 
 	"code.gitea.io/gitea/models/db"
+	"code.gitea.io/gitea/models/foreignreference"
 	issues_model "code.gitea.io/gitea/models/issues"
 	"code.gitea.io/gitea/models/organization"
 	repo_model "code.gitea.io/gitea/models/repo"
@@ -499,6 +501,38 @@ func TestCorrectIssueStats(t *testing.T) {
 	assert.EqualValues(t, issueStats.OpenCount, issueAmount)
 }
 
+func TestIssueForeignReference(t *testing.T) {
+	assert.NoError(t, unittest.PrepareTestDatabase())
+	issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 4})
+	assert.NotEqualValues(t, issue.Index, issue.ID) // make sure they are different to avoid false positive
+
+	// it is fine for an issue to not have a foreign reference
+	err := issue.LoadAttributes(db.DefaultContext)
+	assert.NoError(t, err)
+	assert.Nil(t, issue.ForeignReference)
+
+	var foreignIndex int64 = 12345
+	_, err = issues_model.GetIssueByForeignIndex(context.Background(), issue.RepoID, foreignIndex)
+	assert.True(t, foreignreference.IsErrLocalIndexNotExist(err))
+
+	err = db.Insert(db.DefaultContext, &foreignreference.ForeignReference{
+		LocalIndex:   issue.Index,
+		ForeignIndex: strconv.FormatInt(foreignIndex, 10),
+		RepoID:       issue.RepoID,
+		Type:         foreignreference.TypeIssue,
+	})
+	assert.NoError(t, err)
+
+	err = issue.LoadAttributes(db.DefaultContext)
+	assert.NoError(t, err)
+
+	assert.EqualValues(t, issue.ForeignReference.ForeignIndex, strconv.FormatInt(foreignIndex, 10))
+
+	found, err := issues_model.GetIssueByForeignIndex(context.Background(), issue.RepoID, foreignIndex)
+	assert.NoError(t, err)
+	assert.EqualValues(t, found.Index, issue.Index)
+}
+
 func TestMilestoneList_LoadTotalTrackedTimes(t *testing.T) {
 	assert.NoError(t, unittest.PrepareTestDatabase())
 	miles := issues_model.MilestoneList{

models/migrate.go

@@ -83,6 +83,13 @@ func insertIssue(ctx context.Context, issue *issues_model.Issue) error {
 		}
 	}
 
+	if issue.ForeignReference != nil {
+		issue.ForeignReference.LocalIndex = issue.Index
+		if _, err := sess.Insert(issue.ForeignReference); err != nil {
+			return err
+		}
+	}
+
 	return nil
 }
 

models/migrate_test.go

@@ -4,9 +4,11 @@
 package models
 
 import (
+	"strconv"
 	"testing"
 
 	"code.gitea.io/gitea/models/db"
+	"code.gitea.io/gitea/models/foreignreference"
 	issues_model "code.gitea.io/gitea/models/issues"
 	repo_model "code.gitea.io/gitea/models/repo"
 	"code.gitea.io/gitea/models/unittest"
@@ -46,6 +48,7 @@ func assertCreateIssues(t *testing.T, isPull bool) {
 		UserID: owner.ID,
 	}
 
+	foreignIndex := int64(12345)
 	title := "issuetitle1"
 	is := &issues_model.Issue{
 		RepoID:      repo.ID,
@@ -59,11 +62,20 @@ func assertCreateIssues(t *testing.T, isPull bool) {
 		IsClosed:    true,
 		Labels:      []*issues_model.Label{label},
 		Reactions:   []*issues_model.Reaction{reaction},
+		ForeignReference: &foreignreference.ForeignReference{
+			ForeignIndex: strconv.FormatInt(foreignIndex, 10),
+			RepoID:       repo.ID,
+			Type:         foreignreference.TypeIssue,
+		},
 	}
 	err := InsertIssues(is)
 	assert.NoError(t, err)
 
 	i := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{Title: title})
+	assert.Nil(t, i.ForeignReference)
+	err = i.LoadAttributes(db.DefaultContext)
+	assert.NoError(t, err)
+	assert.EqualValues(t, strconv.FormatInt(foreignIndex, 10), i.ForeignReference.ForeignIndex)
 	unittest.AssertExistsAndLoadBean(t, &issues_model.Reaction{Type: "heart", UserID: owner.ID, IssueID: i.ID})
 }
 

models/migrations/migrations.go

@@ -444,8 +444,6 @@ var migrations = []Migration{
 	NewMigration("Add index for access_token", v1_19.AddIndexForAccessToken),
 	// v236 -> v237
 	NewMigration("Create secrets table", v1_19.CreateSecretsTable),
-	// v237 -> v238
-	NewMigration("Drop ForeignReference table", v1_19.DropForeignReferenceTable),
 }
 
 // GetCurrentDBVersion returns the current db version

models/migrations/v1_19/v237.go

@@ -1,15 +0,0 @@
-// Copyright 2022 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package v1_19 //nolint
-
-import (
-	"xorm.io/xorm"
-)
-
-func DropForeignReferenceTable(x *xorm.Engine) error {
-	// Drop the table introduced in `v211`, it's considered badly designed and doesn't look like to be used.
-	// See: https://github.com/go-gitea/gitea/issues/21086#issuecomment-1318217453
-	type ForeignReference struct{}
-	return x.DropTables(new(ForeignReference))
-}

services/migrations/gitea_uploader.go

@@ -17,6 +17,7 @@ import (
 
 	"code.gitea.io/gitea/models"
 	"code.gitea.io/gitea/models/db"
+	"code.gitea.io/gitea/models/foreignreference"
 	issues_model "code.gitea.io/gitea/models/issues"
 	repo_model "code.gitea.io/gitea/models/repo"
 	user_model "code.gitea.io/gitea/models/user"
@@ -402,6 +403,16 @@ func (g *GiteaLocalUploader) CreateIssues(issues ...*base.Issue) error {
 			Labels:      labels,
 			CreatedUnix: timeutil.TimeStamp(issue.Created.Unix()),
 			UpdatedUnix: timeutil.TimeStamp(issue.Updated.Unix()),
+			ForeignReference: &foreignreference.ForeignReference{
+				LocalIndex:   issue.GetLocalIndex(),
+				ForeignIndex: strconv.FormatInt(issue.GetForeignIndex(), 10),
+				RepoID:       g.repo.ID,
+				Type:         foreignreference.TypeIssue,
+			},
+		}
+
+		if is.ForeignReference.ForeignIndex == "0" {
+			is.ForeignReference.ForeignIndex = strconv.FormatInt(is.Index, 10)
 		}
 
 		if err := g.remapUser(issue, &is); err != nil {

tests/integration/empty_repo_test.go

@@ -11,8 +11,6 @@ import (
 	"code.gitea.io/gitea/models/unittest"
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/tests"
-
-	"github.com/stretchr/testify/assert"
 )
 
 func TestEmptyRepo(t *testing.T) {
@@ -23,8 +21,7 @@ func TestEmptyRepo(t *testing.T) {
 		"commit/1ae57b34ccf7e18373",
 		"graph",
 	}
-	emptyRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 5})
+	emptyRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{}, unittest.Cond("is_empty = ?", true))
-	assert.True(t, emptyRepo.IsEmpty)
 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: emptyRepo.OwnerID})
 	for _, subpath := range subpaths {
 		req := NewRequestf(t, "GET", "/%s/%s/%s", owner.Name, emptyRepo.Name, subpath)

web_src/js/components/ActivityHeatmap.vue

@@ -18,6 +18,7 @@
 import {CalendarHeatmap} from 'vue3-calendar-heatmap';
 
 export default {
+  name: 'ActivityHeatmap',
   components: {CalendarHeatmap},
   props: {
     values: {

web_src/js/components/ContextPopup.vue

@@ -46,13 +46,19 @@ const luminance = (colorString) => {
 const luminanceThreshold = 0.179;
 
 export default {
-  components: {SvgIcon},
+  name: 'ContextPopup',
+
+  components: {
+    SvgIcon,
+  },
+
   data: () => ({
     loading: false,
     issue: null,
     i18nErrorOccurred: i18n.error_occurred,
     i18nErrorMessage: null,
   }),
+
   computed: {
     createdAt() {
       return new Date(this.issue.created_at).toLocaleDateString(undefined, {year: 'numeric', month: 'short', day: 'numeric'});
@@ -101,6 +107,7 @@ export default {
       });
     }
   },
+
   mounted() {
     this.$refs.root.addEventListener('us-load-context-popup', (e) => {
       const data = e.detail;
@@ -109,6 +116,7 @@ export default {
       }
     });
   },
+
   methods: {
     load(data) {
       this.loading = true;

web_src/js/components/DiffFileList.vue

@@ -27,9 +27,12 @@ import {doLoadMoreFiles} from '../features/repo-diff.js';
 const {pageData} = window.config;
 
 export default {
+  name: 'DiffFileList',
+
   data: () => {
     return pageData.diffFileInfo;
   },
+
   watch: {
     fileListIsVisible(newValue) {
       if (newValue === true) {
@@ -41,12 +44,15 @@ export default {
       }
     }
   },
+
   mounted() {
     document.getElementById('show-file-list-btn').addEventListener('click', this.toggleFileList);
   },
+
   unmounted() {
     document.getElementById('show-file-list-btn').removeEventListener('click', this.toggleFileList);
   },
+
   methods: {
     toggleFileList() {
       this.fileListIsVisible = !this.fileListIsVisible;

web_src/js/components/DiffFileTree.vue

@@ -21,12 +21,15 @@ const {pageData} = window.config;
 const LOCAL_STORAGE_KEY = 'diff_file_tree_visible';
 
 export default {
+  name: 'DiffFileTree',
   components: {DiffFileTreeItem},
+
   data: () => {
     const fileTreeIsVisible = localStorage.getItem(LOCAL_STORAGE_KEY) === 'true';
     pageData.diffFileInfo.fileTreeIsVisible = fileTreeIsVisible;
     return pageData.diffFileInfo;
   },
+
   computed: {
     fileTree() {
       const result = [];
@@ -91,6 +94,7 @@ export default {
       return result;
     }
   },
+
   mounted() {
     // ensure correct buttons when we are mounted to the dom
     this.adjustToggleButton(this.fileTreeIsVisible);
@@ -121,7 +125,7 @@ export default {
       doLoadMoreFiles(this.link, this.diffEnd, () => {
         this.isLoadingNewData = false;
       });
-    },
+    }
   },
 };
 </script>

web_src/js/components/DiffFileTreeItem.vue

@@ -43,7 +43,11 @@
 import {SvgIcon} from '../svg.js';
 
 export default {
-  components: {SvgIcon},
+  name: 'DiffFileTreeItem',
+  components: {
+    SvgIcon,
+  },
+
   props: {
     item: {
       type: Object,
@@ -55,6 +59,7 @@ export default {
       default: true
     }
   },
+
   data: () => ({
     collapsed: false,
   }),

web_src/js/components/PullRequestMergeForm.vue

@@ -111,7 +111,11 @@ import {SvgIcon} from '../svg.js';
 const {csrfToken, pageData} = window.config;
 
 export default {
-  components: {SvgIcon},
+  name: 'PullRequestMergeForm',
+  components: {
+    SvgIcon,
+  },
+
   data: () => ({
     csrfToken,
     mergeForm: pageData.pullRequestMergeForm,
@@ -133,17 +137,20 @@ export default {
     showMergeStyleMenu: false,
     showActionForm: false,
   }),
+
   computed: {
     mergeButtonStyleClass() {
       if (this.mergeForm.allOverridableChecksOk) return 'green';
       return this.autoMergeWhenSucceed ? 'blue' : 'red';
     }
   },
+
   watch: {
     mergeStyle(val) {
       this.mergeStyleDetail = this.mergeForm.mergeStyles.find((e) => e.name === val);
     }
   },
+
   created() {
     this.mergeStyleAllowedCount = this.mergeForm.mergeStyles.reduce((v, msd) => v + (msd.allowed ? 1 : 0), 0);
 
@@ -151,12 +158,15 @@ export default {
     if (!mergeStyle) mergeStyle = this.mergeForm.mergeStyles.find((e) => e.allowed)?.name;
     this.switchMergeStyle(mergeStyle, !this.mergeForm.canMergeNow);
   },
+
   mounted() {
     document.addEventListener('mouseup', this.hideMergeStyleMenu);
   },
+
   unmounted() {
     document.removeEventListener('mouseup', this.hideMergeStyleMenu);
   },
+
   methods: {
     hideMergeStyleMenu() {
       this.showMergeStyleMenu = false;

web_src/js/features/clipboard.js

@@ -44,7 +44,7 @@ function fallbackCopyToClipboard(text) {
 
 // For all DOM elements with [data-clipboard-target] or [data-clipboard-text],
 // this copy-to-clipboard will work for them
-export function initGlobalCopyToClipboardListener() {
+export default function initGlobalCopyToClipboardListener() {
   document.addEventListener('click', (e) => {
     let target = e.target;
     // in case <button data-clipboard-text><svg></button>, so we just search

web_src/js/features/colorpicker.js

@@ -1,4 +1,4 @@
-export async function createColorPicker($els) {
+export default async function createColorPicker($els) {
   if (!$els || !$els.length) return;
 
   await Promise.all([

web_src/js/features/common-global.js

@@ -1,7 +1,7 @@
 import $ from 'jquery';
 import 'jquery.are-you-sure';
 import {mqBinarySearch} from '../utils.js';
-import {createDropzone} from './dropzone.js';
+import createDropzone from './dropzone.js';
 import {initCompColorPicker} from './comp/ColorPicker.js';
 import {showGlobalErrorMessage} from '../bootstrap.js';
 import {attachDropdownAria} from './aria.js';

web_src/js/features/comp/ColorPicker.js

@@ -1,5 +1,5 @@
 import $ from 'jquery';
-import {createColorPicker} from '../colorpicker.js';
+import createColorPicker from '../colorpicker.js';
 
 export function initCompColorPicker() {
   createColorPicker($('.color-picker'));

web_src/js/features/comp/EasyMDE.js

@@ -1,5 +1,5 @@
 import $ from 'jquery';
-import {attachTribute} from '../tribute.js';
+import attachTribute from '../tribute.js';
 import {handleGlobalEnterQuickSubmit} from './QuickSubmit.js';
 
 /**

web_src/js/features/comp/SearchUserBox.js

@@ -2,6 +2,7 @@ import $ from 'jquery';
 import {htmlEscape} from 'escape-goat';
 
 const {appSubUrl} = window.config;
+
 const looksLikeEmailAddressCheck = /^\S+@\S+$/;
 
 export function initCompSearchUserBox() {

web_src/js/features/comp/WebHookEditor.js

@@ -1,5 +1,4 @@
 import $ from 'jquery';
-
 const {csrfToken} = window.config;
 
 export function initCompWebHookEditor() {

web_src/js/features/contextpopup.js

@@ -4,7 +4,7 @@ import ContextPopup from '../components/ContextPopup.vue';
 import {parseIssueHref} from '../utils.js';
 import {createTippy} from '../modules/tippy.js';
 
-export function initContextPopups() {
+export default function initContextPopups() {
   const refIssues = $('.ref-issue');
   if (!refIssues.length) return;
 

web_src/js/features/copycontent.js

@@ -1,7 +1,6 @@
 import {copyToClipboard} from './clipboard.js';
 import {showTemporaryTooltip} from '../modules/tippy.js';
 import {convertImage} from '../utils.js';
-
 const {i18n} = window.config;
 
 async function doCopy(content, btn) {

web_src/js/features/dropzone.js

@@ -1,4 +1,4 @@
-export async function createDropzone(el, opts) {
+export default async function createDropzone(el, opts) {
   const [{Dropzone}] = await Promise.all([
     import(/* webpackChunkName: "dropzone" */'dropzone'),
     import(/* webpackChunkName: "dropzone" */'dropzone/dist/dropzone.css'),

web_src/js/features/emoji.js

@@ -1,6 +1,7 @@
 import emojis from '../../../assets/emoji.json';
 
-const {assetUrlPrefix, customEmojis} = window.config;
+const {assetUrlPrefix} = window.config;
+const {customEmojis} = window.config;
 
 const tempMap = {...customEmojis};
 for (const {emoji, aliases} of emojis) {

web_src/js/features/file-fold.js

@@ -1,5 +1,6 @@
 import {svg} from '../svg.js';
 
+
 // Hides the file if newFold is true, and shows it otherwise. The actual hiding is performed using CSS.
 //
 // The fold arrow is the icon displayed on the upper left of the file box, especially intended for components having the 'fold-file' class.

web_src/js/features/formatting.js

@@ -1,6 +1,7 @@
 import {prettyNumber} from '../utils.js';
 
 const {lang} = document.documentElement;
+
 const dateFormatter = new Intl.DateTimeFormat(lang, {year: 'numeric', month: 'long', day: 'numeric'});
 const shortDateFormatter = new Intl.DateTimeFormat(lang, {year: 'numeric', month: 'short', day: 'numeric'});
 const dateTimeFormatter = new Intl.DateTimeFormat(lang, {year: 'numeric', month: 'short', day: 'numeric', hour: 'numeric', minute: 'numeric', second: 'numeric'});

web_src/js/features/heatmap.js

@@ -1,8 +1,7 @@
 import {createApp} from 'vue';
 import ActivityHeatmap from '../components/ActivityHeatmap.vue';
 import {translateMonth, translateDay} from '../utils.js';
-
+export default function initHeatmap() {
-export function initHeatmap() {
   const el = document.getElementById('user-heatmap');
   if (!el) return;
 

web_src/js/features/imagediff.js

@@ -34,7 +34,7 @@ function getDefaultSvgBoundsIfUndefined(svgXml, src) {
   return null;
 }
 
-export function initImageDiff() {
+export default function initImageDiff() {
   function createContext(image1, image2) {
     const size1 = {
       width: image1 && image1.width || 0,

web_src/js/features/repo-diff-filetree.js

@@ -2,7 +2,7 @@ import {createApp} from 'vue';
 import DiffFileTree from '../components/DiffFileTree.vue';
 import DiffFileList from '../components/DiffFileList.vue';
 
-export function initDiffFileTree() {
+export default function initDiffFileTree() {
   const el = document.getElementById('diff-file-tree');
   if (!el) return;
 

web_src/js/features/repo-findfile.js

@@ -1,6 +1,6 @@
 import $ from 'jquery';
-import {svg} from '../svg.js';
 
+import {svg} from '../svg.js';
 const {csrf} = window.config;
 
 const threshold = 50;

web_src/js/features/repo-graph.js

@@ -1,6 +1,6 @@
 import $ from 'jquery';
 
-export function initRepoGraphGit() {
+export default function initRepoGraphGit() {
   const graphContainer = document.getElementById('git-graph-container');
   if (!graphContainer) return;
 

web_src/js/features/repo-issue-pr-form.js

@@ -1,7 +1,7 @@
 import {createApp} from 'vue';
 import PullRequestMergeForm from '../components/PullRequestMergeForm.vue';
 
-export function initRepoPullRequestMergeForm() {
+export default function initPullRequestMergeForm() {
   const el = document.getElementById('pull-request-merge-form');
   if (!el) return;
 

web_src/js/features/repo-issue.js

@@ -1,6 +1,6 @@
 import $ from 'jquery';
 import {htmlEscape} from 'escape-goat';
-import {attachTribute} from './tribute.js';
+import attachTribute from './tribute.js';
 import {createCommentEasyMDE, getAttachedEasyMDE} from './comp/EasyMDE.js';
 import {initEasyMDEImagePaste} from './comp/ImagePaste.js';
 import {initCompMarkupContentPreviewTab} from './comp/MarkupContentPreview.js';

web_src/js/features/repo-legacy.js

@@ -3,28 +3,33 @@ import {createCommentEasyMDE, getAttachedEasyMDE} from './comp/EasyMDE.js';
 import {initCompMarkupContentPreviewTab} from './comp/MarkupContentPreview.js';
 import {initEasyMDEImagePaste} from './comp/ImagePaste.js';
 import {
-  initRepoIssueBranchSelect, initRepoIssueCodeCommentCancel, initRepoIssueCommentDelete,
+  initRepoIssueBranchSelect, initRepoIssueCodeCommentCancel,
-  initRepoIssueComments, initRepoIssueDependencyDelete, initRepoIssueReferenceIssue,
+  initRepoIssueCommentDelete,
-  initRepoIssueStatusButton, initRepoIssueTitleEdit, initRepoIssueWipToggle,
+  initRepoIssueComments, initRepoIssueDependencyDelete,
-  initRepoPullRequestUpdate, updateIssuesMeta,
+  initRepoIssueReferenceIssue, initRepoIssueStatusButton,
+  initRepoIssueTitleEdit,
+  initRepoIssueWipToggle, initRepoPullRequestUpdate,
+  updateIssuesMeta,
 } from './repo-issue.js';
 import {initUnicodeEscapeButton} from './repo-unicode-escape.js';
 import {svg} from '../svg.js';
 import {htmlEscape} from 'escape-goat';
 import {initRepoBranchTagDropdown} from '../components/RepoBranchTagDropdown.js';
 import {
-  initRepoCloneLink, initRepoCommonBranchOrTagDropdown, initRepoCommonFilterSearchDropdown,
+  initRepoCloneLink,
+  initRepoCommonBranchOrTagDropdown,
+  initRepoCommonFilterSearchDropdown,
   initRepoCommonLanguageStats,
 } from './repo-common.js';
 import {initCitationFileCopyContent} from './citation.js';
 import {initCompLabelEdit} from './comp/LabelEdit.js';
 import {initRepoDiffConversationNav} from './repo-diff.js';
-import {attachTribute} from './tribute.js';
+import attachTribute from './tribute.js';
-import {createDropzone} from './dropzone.js';
+import createDropzone from './dropzone.js';
 import {initCommentContent, initMarkupContent} from '../markup/content.js';
 import {initCompReactionSelector} from './comp/ReactionSelector.js';
 import {initRepoSettingBranches} from './repo-settings.js';
-import {initRepoPullRequestMergeForm} from './repo-issue-pr-form.js';
+import initRepoPullRequestMergeForm from './repo-issue-pr-form.js';
 
 const {csrfToken} = window.config;
 

web_src/js/features/repo-migration.js

@@ -10,7 +10,7 @@ const $lfsSettings = $('#lfs_settings');
 const $lfsEndpoint = $('#lfs_endpoint');
 const $items = $('#migrate_items').find('input[type=checkbox]');
 
-export function initRepoMigration() {
+export default function initRepoMigration() {
   checkAuth();
   setLFSSettingsVisibility();
 

web_src/js/features/repo-projects.js

@@ -84,7 +84,7 @@ async function initRepoProjectSortable() {
   }
 }
 
-export function initRepoProject() {
+export default function initRepoProject() {
   if (!$('.repository.projects').length) {
     return;
   }

web_src/js/features/repo-release.js

@@ -1,5 +1,5 @@
 import $ from 'jquery';
-import {attachTribute} from './tribute.js';
+import attachTribute from './tribute.js';
 import {initCompMarkupContentPreviewTab} from './comp/MarkupContentPreview.js';
 import {initEasyMDEImagePaste} from './comp/ImagePaste.js';
 import {createCommentEasyMDE} from './comp/EasyMDE.js';

web_src/js/features/serviceworker.js

@@ -35,7 +35,7 @@ async function checkCacheValidity() {
   }
 }
 
-export async function initServiceWorker() {
+export default async function initServiceWorker() {
   if (!('serviceWorker' in navigator)) return;
 
   if (useServiceWorker) {

web_src/js/features/tablesort.js

@@ -1,4 +1,4 @@
-export function initTableSort() {
+export default function initTableSort() {
   for (const header of document.querySelectorAll('th[data-sortt-asc]') || []) {
     const sorttAsc = header.getAttribute('data-sortt-asc');
     const sorttDesc = header.getAttribute('data-sortt-desc');

web_src/js/features/tribute.js

@@ -49,7 +49,7 @@ function makeCollections({mentions, emoji}) {
   return collections;
 }
 
-export async function attachTribute(elementOrNodeList, {mentions, emoji} = {}) {
+export default async function attachTribute(elementOrNodeList, {mentions, emoji} = {}) {
   if (!window.config.requireTribute || !elementOrNodeList) return;
   const nodes = Array.from('length' in elementOrNodeList ? elementOrNodeList : [elementOrNodeList]);
   if (!nodes.length) return;

web_src/js/index.js

@@ -6,16 +6,16 @@ import {initVueEnv} from './components/VueComponentLoader.js';
 import {initRepoActivityTopAuthorsChart} from './components/RepoActivityTopAuthors.vue';
 import {initDashboardRepoList} from './components/DashboardRepoList.js';
 
-import {attachTribute} from './features/tribute.js';
+import attachTribute from './features/tribute.js';
-import {initGlobalCopyToClipboardListener} from './features/clipboard.js';
+import initGlobalCopyToClipboardListener from './features/clipboard.js';
-import {initContextPopups} from './features/contextpopup.js';
+import initContextPopups from './features/contextpopup.js';
-import {initRepoGraphGit} from './features/repo-graph.js';
+import initRepoGraphGit from './features/repo-graph.js';
-import {initHeatmap} from './features/heatmap.js';
+import initHeatmap from './features/heatmap.js';
-import {initImageDiff} from './features/imagediff.js';
+import initImageDiff from './features/imagediff.js';
-import {initRepoMigration} from './features/repo-migration.js';
+import initRepoMigration from './features/repo-migration.js';
-import {initRepoProject} from './features/repo-projects.js';
+import initRepoProject from './features/repo-projects.js';
-import {initServiceWorker} from './features/serviceworker.js';
+import initServiceWorker from './features/serviceworker.js';
-import {initTableSort} from './features/tablesort.js';
+import initTableSort from './features/tablesort.js';
 import {initAdminUserListSearchForm} from './features/admin/users.js';
 import {initAdminConfigs} from './features/admin/config.js';
 import {initMarkupAnchors} from './markup/anchors.js';
@@ -24,7 +24,7 @@ import {initRepoIssueContentHistory} from './features/repo-issue-content.js';
 import {initStopwatch} from './features/stopwatch.js';
 import {initFindFileInRepo} from './features/repo-findfile.js';
 import {initCommentContent, initMarkupContent} from './markup/content.js';
-import {initDiffFileTree} from './features/repo-diff-filetree.js';
+import initDiffFileTree from './features/repo-diff-filetree.js';
 
 import {initUserAuthLinkAccountView, initUserAuthOauth2} from './features/user-auth.js';
 import {

web_src/js/svg.js

@@ -26,6 +26,7 @@ import octiconSidebarExpand from '../../public/img/svg/octicon-sidebar-expand.sv
 import octiconTriangleDown from '../../public/img/svg/octicon-triangle-down.svg';
 import octiconX from '../../public/img/svg/octicon-x.svg';
 
+
 export const svgs = {
   'octicon-chevron-down': octiconChevronDown,
   'octicon-chevron-right': octiconChevronRight,
@@ -56,6 +57,7 @@ export const svgs = {
   'octicon-x': octiconX,
 };
 
+
 const parser = new DOMParser();
 const serializer = new XMLSerializer();