faraday/test/request_middleware_test.rb
Hawk Newton 565b2a49af Make multipart boundary unique (#673)
* Make multipart boundary unique

* Use a distinct connection each time
2017-03-03 11:24:37 +01:00

127 lines
4.4 KiB
Ruby

# encoding: utf-8
require File.expand_path('../helper', __FILE__)
Faraday::CompositeReadIO.class_eval { attr_reader :ios }
class RequestMiddlewareTest < Faraday::TestCase
def conn
Faraday.new do |b|
b.request :multipart
b.request :url_encoded
b.adapter :test do |stub|
stub.post('/echo') do |env|
posted_as = env[:request_headers]['Content-Type']
[200, {'Content-Type' => posted_as}, env[:body]]
end
end
end
end
def test_does_nothing_without_payload
response = conn.post('/echo')
assert_nil response.headers['Content-Type']
assert response.body.empty?
end
def test_ignores_custom_content_type
response = conn.post('/echo', { :some => 'data' }, 'content-type' => 'application/x-foo')
assert_equal 'application/x-foo', response.headers['Content-Type']
assert_equal({ :some => 'data' }, response.body)
end
def test_url_encoded_no_header
response = conn.post('/echo', { :fruit => %w[apples oranges] })
assert_equal 'application/x-www-form-urlencoded', response.headers['Content-Type']
assert_equal 'fruit%5B%5D=apples&fruit%5B%5D=oranges', response.body
end
def test_url_encoded_with_header
response = conn.post('/echo', {'a'=>123}, 'content-type' => 'application/x-www-form-urlencoded')
assert_equal 'application/x-www-form-urlencoded', response.headers['Content-Type']
assert_equal 'a=123', response.body
end
def test_url_encoded_nested
response = conn.post('/echo', { :user => {:name => 'Mislav', :web => 'mislav.net'} })
assert_equal 'application/x-www-form-urlencoded', response.headers['Content-Type']
expected = { 'user' => {'name' => 'Mislav', 'web' => 'mislav.net'} }
assert_equal expected, Faraday::Utils.parse_nested_query(response.body)
end
def test_url_encoded_non_nested
response = conn.post('/echo', { :dimensions => ['date', 'location']}) do |req|
req.options.params_encoder = Faraday::FlatParamsEncoder
end
assert_equal 'application/x-www-form-urlencoded', response.headers['Content-Type']
expected = { 'dimensions' => ['date', 'location'] }
assert_equal expected, Faraday::Utils.parse_query(response.body)
assert_equal 'dimensions=date&dimensions=location', response.body
end
def test_url_encoded_unicode
err = capture_warnings {
response = conn.post('/echo', {:str => "eé cç aã aâ"})
assert_equal "str=e%C3%A9+c%C3%A7+a%C3%A3+a%C3%A2", response.body
}
assert err.empty?, "stderr did include: #{err}"
end
def test_url_encoded_nested_keys
response = conn.post('/echo', {'a'=>{'b'=>{'c'=>['d']}}})
assert_equal "a%5Bb%5D%5Bc%5D%5B%5D=d", response.body
end
def test_multipart
# assume params are out of order
regexes = [
/name\=\"a\"/,
/name=\"b\[c\]\"\; filename\=\"request_middleware_test\.rb\"/,
/name=\"b\[d\]\"/]
payload = {:a => 1, :b => {:c => Faraday::UploadIO.new(__FILE__, 'text/x-ruby'), :d => 2}}
response = conn.post('/echo', payload)
assert_kind_of Faraday::CompositeReadIO, response.body
assert response.headers['Content-Type'].start_with?(
"multipart/form-data; boundary=%s" % Faraday::Request::Multipart::DEFAULT_BOUNDARY_PREFIX,
)
response.body.send(:ios).map{|io| io.read}.each do |io|
if re = regexes.detect { |r| io =~ r }
regexes.delete re
end
end
assert_equal [], regexes
end
def test_multipart_with_arrays
# assume params are out of order
regexes = [
/name\=\"a\"/,
/name=\"b\[\]\[c\]\"\; filename\=\"request_middleware_test\.rb\"/,
/name=\"b\[\]\[d\]\"/]
payload = {:a => 1, :b =>[{:c => Faraday::UploadIO.new(__FILE__, 'text/x-ruby'), :d => 2}]}
response = conn.post('/echo', payload)
assert_kind_of Faraday::CompositeReadIO, response.body
assert response.headers['Content-Type'].start_with?(
"multipart/form-data; boundary=%s" % Faraday::Request::Multipart::DEFAULT_BOUNDARY_PREFIX,
)
response.body.send(:ios).map{|io| io.read}.each do |io|
if re = regexes.detect { |r| io =~ r }
regexes.delete re
end
end
assert_equal [], regexes
end
def test_multipart_unique_boundary
payload = {:a => 1, :b =>[{:c => Faraday::UploadIO.new(__FILE__, 'text/x-ruby'), :d => 2}]}
response1 = conn.post('/echo', payload)
response2 = conn.post('/echo', payload)
assert response1.headers['Content-Type'] != response2.headers['Content-Type']
end
end