sharpetronics/faraday
1
0
Fork 0
mirror of https://github.com/lostisland/faraday.git synced 2025-08-23 00:01:48 -04:00
Code Issues Projects Releases Wiki Activity
1,334 Commits 16 Branches 140 Tags
Commit Graph

1334 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
risk danger olson
bd322bba6b chore: rubocop lint Metrics/LineLength (#938) 2019-03-08 17:45:12 +00:00
Mattia
4102f3add4
Removes legacy tests as replaced by RSpec (#939) 2019-03-08 11:00:56 +00:00
Mattia
626d68f6ff
Adds rack adapter to RSpec tests (#937) 2019-03-07 23:18:29 +00:00
risk danger olson
c58723d028
Merge pull request #933 from lostisland/rubocop-style-classvars 
Rubocop: style/classvars
 2019-03-07 10:47:38 -07:00
rick olson
490ee83ddf Merge branch 'master' into rubocop-style-classvars 2019-03-07 10:37:20 -07:00
rick olson
4d88475295 remove #constantize use and unnecessary nil checks 2019-03-07 10:28:55 -07:00
Mattia
609d1768cb
Adds em-synchrony adapter to RSpec tests (#936) 2019-03-07 13:23:41 +00:00
rick olson
726de4a186 use a descriptive variable name 2019-03-06 11:23:52 -07:00
rick olson
907c5190b1 add AdapterRegistry spec 2019-03-06 10:14:10 -07:00
rick olson
73747c66b7 Merge branch 'master' into rubocop-style-classvars 2019-03-06 09:30:09 -07:00
risk danger olson
c801391d18
Merge pull request #932 from lostisland/em-http-tests 
Adds em-http adapter to RSpec tests
 2019-03-06 09:29:15 -07:00
Sergey Prikhodko
1d3d675821 Add the log formatter that is easy to override and safe to inherit (#889) 2019-03-06 16:13:14 +00:00
iMacTia
04dff67cfa Fixes an issue with macOS require order. 2019-03-06 09:20:47 +00:00
iMacTia
28e995d9c6 Merge branch 'master' of https://github.com/lostisland/faraday into em-http-tests 
# Conflicts:
#	spec/spec_helper.rb
 2019-03-06 08:53:40 +00:00
Geoff Hubbard
b9ea1d92ce Accurate test code coverage percentage (#934) 2019-03-06 08:46:51 +00:00
rick olson
00cbb94f3d chore: update rubocop_todo 2019-03-05 11:38:44 -07:00
rick olson
5f276b36fa replace @@classvars with AdapterRegistry usage 2019-03-05 11:38:24 -07:00
rick olson
dcb7030289 always require 'monitor' since it's used by AdapterRegistry too. 2019-03-05 11:38:07 -07:00
rick olson
e8382421aa reimplement const-lookup from Faraday::RackBuilder::Handler 2019-03-05 11:37:42 -07:00
rick olson
04b90eb43e chore: replace class vars with class instance var 
probably unnecessary since the integration test suite is going away
 2019-03-05 11:33:15 -07:00
iMacTia
ab33c8ace1 Adds em-http adapter to RSpec tests 2019-03-05 18:26:46 +00:00
Mattia
ded4f6ef9a
Fixes Rubocop Style/GuardClause (#931) 2019-03-05 12:25:15 +00:00
Geoff Hubbard
e342992751 chore: Rubocop lint Style/MissingRespondToMissing (#930) 2019-03-04 23:25:25 +01:00
Geoff Hubbard
dbba0734d6 Fix test order dependency in default_connection proxy test (#929) 
* Fix the default_connection proxy test

The assignment to the mock connection:

`Faraday.default_connection = mock_connection`

was persisting throughout the tests.

If the random number generator is unlucky the following error occurs:

\#<Double "Connection"> was originally created in one example but has leaked into another example and can no longer be used.  rspec-mocks' doubles are designed to only last for one example, and you need to create a new one in each example you wish to use it for.

This commit fixes the issue by explicitly setting the default_connection
back to nil in an "after" block after the tests have run.

Subsequent calls to `default_connection` within the test suite then
behave as previously expected irrespective of the random test ordering.
 2019-03-04 23:16:10 +01:00
Geoff Hubbard
c5ceb2679c chore: RuboCop lint Style/MethodMissingSuper (#928) 2019-03-04 21:07:33 +00:00
Mattia
6b0eb71322
chore: RuboCop lint Metrics/BlockLength (#927) 2019-03-04 21:02:46 +00:00
Mattia
ef4044281d chore: RuboCop lint Style/IfUnlessModifier (#926) 
* Fixes Rubocop Style/IfUnlessModifier

* Update lib/faraday/adapter/httpclient.rb

Co-Authored-By: iMacTia <iMacTia@users.noreply.github.com>

* Update lib/faraday/request/retry.rb

Co-Authored-By: iMacTia <iMacTia@users.noreply.github.com>
 2019-03-04 14:49:25 +01:00
Olle Jonsson
8ba22d5da2
Merge pull request #925 from lostisland/fix/rubocop-style-m 
chore: RuboCop lint Style/M*
 2019-03-04 14:23:41 +01:00
iMacTia
2a04aeadb3 Fixes Rubocop Style/ModuleFunction 2019-03-04 13:01:46 +00:00
iMacTia
f3e9adba3b Fixes Rubocop Style/MutableConstant 2019-03-04 12:55:20 +00:00
Ted Johansson
5b49e6c9b2 Chore: RuboCop Style/MultilineIfModifier (#924) 2019-03-04 08:40:44 +01:00
Olle Jonsson
c209c41da6
RuboCop rule: Allow !! (#922) 
* RuboCop rule: Allow !!

* chore: Regenerate RuboCop TODO
 2019-03-03 23:27:34 +01:00
Mattia
fb21e2db1a chore: RuboCop lint Style/N* (#921) 
* Fixes Rubocop Style/NumericPredicate

* Fixes Rubocop Style/NilComparison
 2019-03-03 22:40:17 +01:00
Olle Jonsson
1a7ce3e367
Merge pull request #920 from lostisland/fix/rubocop-style-p 
chore: RuboCop lint Style/P*
 2019-03-03 20:36:28 +01:00
Olle Jonsson
8140cba74c Drop scripts/release, scripts/package (#919) 
* Drop scripts/release
  - GitHub Releases are used to create and annotate tags
  - Travis CI publishes and pushes gems

* Drop script/package
 2019-03-03 19:30:40 +00:00
Olle Jonsson
af1c1b5bb6 Drop auto-generated bin/ (#918) 2019-03-03 19:26:18 +00:00
iMacTia
f8f5985f3e Fixes Rubocop Style/ParallelAssignment 2019-03-03 19:23:46 +00:00
iMacTia
376eb2307a Fixes Rubocop Style/ParenthesesAroundCondition 2019-03-03 19:21:51 +00:00
iMacTia
49073081c8 Fixes Rubocop Style/PerlBackrefs 2019-03-03 19:20:53 +00:00
iMacTia
cfb80e55af Fixes Rubocop Style/PreferredHashMethods 2019-03-03 19:19:36 +00:00
iMacTia
5d4ed5e401 Fixes Rubocop Style/Proc 2019-03-03 19:08:54 +00:00
Olle Jonsson
b80111bed5 Excon adapter: extract methods (#916) 2019-03-03 19:00:49 +00:00
htwroclau
1fe9763c19 chore: Fix RuboCop Style/IfInsideElse (#915) 2019-03-03 18:38:56 +01:00
Olle Jonsson
1c0f43b9fd chore: RuboCop lint Style/MultilineTernaryOperator (#913) 2019-03-03 16:42:31 +00:00
htwroclau
801f7d517e chore: Fix RuboCop Style/FormatStringToken (#914) 2019-03-03 13:08:08 +01:00
Mattia
d657e3d3c3 chore: RuboCop lints Style/R* (#910) 
* Fixes Rubocop Style/RescueStandardError

* Fixes Rubocop Style/RegexpLiteral

* Fixes Rubocop Style/RaiseArgs
 2019-03-03 10:50:49 +01:00
Olle Jonsson
ea61fd7e44
Merge pull request #909 from lostisland/fix/rubocop-style-s 
chore: RuboCop lints Style/S*
 2019-03-03 10:22:54 +01:00
iMacTia
06a7c74162 Merge branch 'master' of https://github.com/lostisland/faraday into fix/rubocop-style-s 
# Conflicts:
#	.rubocop_todo.yml
 2019-03-03 08:59:49 +00:00
htwroclau
f1d0b3933d chore: Fix RuboCop Style/EmptyMethod (#912) 2019-03-03 08:58:00 +00:00
iMacTia
7931f07d6f Regenerates Rubocop TODOs. 2019-03-02 16:36:16 +00:00