117 Commits

Author SHA1 Message Date
Matt
3835b48d80
Add support for a new ParallelManager#execute method. (#1584)
* Add support for a new `ParallelManager#execute` method.

The new interface passes the parallel block with all the requests to the ParallelManager, instead of running it beforehand.

This allows for better, stateless ParallelManager implementations.

Fixes https://github.com/lostisland/faraday/issues/1583

* Update docs/adapters/custom/parallel-requests.md

Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>

---------

Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
2024-08-22 13:05:07 +01:00
Mattia Giuffrida
f0f549d7ef Fix Rubocop offenses 2023-12-28 18:09:17 +01:00
Matt
43d6797770
Enables and fixes all new cops. (#1443) 2022-08-08 15:46:54 +01:00
Matt
506e97afe6
Fix passing a URL with embedded basic auth (#1324) 2021-09-13 16:36:26 +01:00
Olle Jonsson
abe78b5df5 Lint: Lint/RedundantSafeNavigation 2021-08-17 08:44:04 +02:00
Olle Jonsson
fa26357178 Lint: Performance/BlockGivenWithExplicitBlock, and...
also Performance/RedundantSplitRegexpArgument.
2021-08-17 08:44:04 +02:00
Olle Jonsson
120c56988e Lint: skip Performance/StringInclude
We are after the side-effect of setting something in the last match,
from this "useless" RegExp.
2021-08-17 08:44:04 +02:00
Olle Jonsson
f1f36be663 Lint: Style/PerlBackrefs 2021-08-17 08:44:04 +02:00
Olle Jonsson
b79a36f65f Lint: Style/NegatedIfElseCondition 2021-08-17 08:44:04 +02:00
Olle Jonsson
4f6d2f830e RuboCop: Update .rubocop_todo.yml 2021-08-17 08:44:04 +02:00
Olle Jonsson
e640be9866 Lint Style/RedundantBegin 2021-08-17 08:44:04 +02:00
Olle Jonsson
59c32867b3 Regenerate RuboCop TODO file 2021-08-17 08:44:04 +02:00
Matt
fa612a060a
[1.x] Deprecate Authorization helpers in Faraday::Connection (#1306) 2021-08-14 13:30:11 +01:00
Catalin
53e4baedc7
Add proxy setting when url_prefix is changed (#1276)
* Add proxy setting when url_prefix is changed

Without this setting, setting the url_prefix after
a Faraday::Connection is initialized results in no_proxy
settings ignored when using relative paths.

* Increase Rubocop Metrics/ClassLength
2021-04-28 15:54:08 +02:00
Olle Jonsson
952dac0b4c Update RuboCop TODO file
Fixes #1258
2021-04-14 08:52:10 +02:00
yarafan
0ed6480f6e
escape colon in path segment (#1237) 2021-01-18 16:18:21 +00:00
Samuel Williams
4d49b031cd
It was off by 1. 2019-11-13 09:40:40 +09:00
Olle Jonsson
03a0217354
RuboCop TODO update (#968) 2019-04-08 21:59:10 +02:00
risk danger olson
5063ffe963 rubocop: fix Style/Documentation offenses (#951)
* rubocop: fix Style/Documentation offenses

* no test dir

* use @see tag

* put @example after @params, before @return
2019-03-21 09:40:49 +01:00
Ted Johansson
88698363fd Chore: RuboCop Style/MultipleComparison (#923) 2019-03-11 20:59:09 +00:00
Geoff Hubbard
6ff61c0ecc chore: RuboCop lint Style/Globalvars (#943) 2019-03-09 13:23:48 +00:00
risk danger olson
bd322bba6b chore: rubocop lint Metrics/LineLength (#938) 2019-03-08 17:45:12 +00:00
rick olson
490ee83ddf Merge branch 'master' into rubocop-style-classvars 2019-03-07 10:37:20 -07:00
Mattia
609d1768cb
Adds em-synchrony adapter to RSpec tests (#936) 2019-03-07 13:23:41 +00:00
rick olson
00cbb94f3d chore: update rubocop_todo 2019-03-05 11:38:44 -07:00
Mattia
ded4f6ef9a
Fixes Rubocop Style/GuardClause (#931) 2019-03-05 12:25:15 +00:00
Geoff Hubbard
e342992751 chore: Rubocop lint Style/MissingRespondToMissing (#930) 2019-03-04 23:25:25 +01:00
Geoff Hubbard
c5ceb2679c chore: RuboCop lint Style/MethodMissingSuper (#928) 2019-03-04 21:07:33 +00:00
Mattia
6b0eb71322
chore: RuboCop lint Metrics/BlockLength (#927) 2019-03-04 21:02:46 +00:00
Mattia
ef4044281d chore: RuboCop lint Style/IfUnlessModifier (#926)
* Fixes Rubocop Style/IfUnlessModifier

* Update lib/faraday/adapter/httpclient.rb

Co-Authored-By: iMacTia <iMacTia@users.noreply.github.com>

* Update lib/faraday/request/retry.rb

Co-Authored-By: iMacTia <iMacTia@users.noreply.github.com>
2019-03-04 14:49:25 +01:00
iMacTia
2a04aeadb3 Fixes Rubocop Style/ModuleFunction 2019-03-04 13:01:46 +00:00
iMacTia
f3e9adba3b Fixes Rubocop Style/MutableConstant 2019-03-04 12:55:20 +00:00
Ted Johansson
5b49e6c9b2 Chore: RuboCop Style/MultilineIfModifier (#924) 2019-03-04 08:40:44 +01:00
Olle Jonsson
c209c41da6
RuboCop rule: Allow !! (#922)
* RuboCop rule: Allow !!

* chore: Regenerate RuboCop TODO
2019-03-03 23:27:34 +01:00
Mattia
fb21e2db1a chore: RuboCop lint Style/N* (#921)
* Fixes Rubocop Style/NumericPredicate

* Fixes Rubocop Style/NilComparison
2019-03-03 22:40:17 +01:00
iMacTia
f8f5985f3e Fixes Rubocop Style/ParallelAssignment 2019-03-03 19:23:46 +00:00
iMacTia
376eb2307a Fixes Rubocop Style/ParenthesesAroundCondition 2019-03-03 19:21:51 +00:00
iMacTia
49073081c8 Fixes Rubocop Style/PerlBackrefs 2019-03-03 19:20:53 +00:00
iMacTia
cfb80e55af Fixes Rubocop Style/PreferredHashMethods 2019-03-03 19:19:36 +00:00
iMacTia
5d4ed5e401 Fixes Rubocop Style/Proc 2019-03-03 19:08:54 +00:00
htwroclau
1fe9763c19 chore: Fix RuboCop Style/IfInsideElse (#915) 2019-03-03 18:38:56 +01:00
Olle Jonsson
1c0f43b9fd chore: RuboCop lint Style/MultilineTernaryOperator (#913) 2019-03-03 16:42:31 +00:00
htwroclau
801f7d517e chore: Fix RuboCop Style/FormatStringToken (#914) 2019-03-03 13:08:08 +01:00
Mattia
d657e3d3c3 chore: RuboCop lints Style/R* (#910)
* Fixes Rubocop Style/RescueStandardError

* Fixes Rubocop Style/RegexpLiteral

* Fixes Rubocop Style/RaiseArgs
2019-03-03 10:50:49 +01:00
iMacTia
06a7c74162 Merge branch 'master' of https://github.com/lostisland/faraday into fix/rubocop-style-s
# Conflicts:
#	.rubocop_todo.yml
2019-03-03 08:59:49 +00:00
htwroclau
f1d0b3933d chore: Fix RuboCop Style/EmptyMethod (#912) 2019-03-03 08:58:00 +00:00
iMacTia
7931f07d6f Regenerates Rubocop TODOs. 2019-03-02 16:36:16 +00:00
iMacTia
228df3da71 Fixes Rubocop Style/SafeNavigation. 2019-03-02 16:35:22 +00:00
iMacTia
15303a3415 Fixes Rubocop Style/SingleLineMethods. 2019-03-02 16:33:29 +00:00
iMacTia
a41b6ac8d9 Fixes Rubocop Style/SpecialGlobalVars. 2019-03-02 16:32:29 +00:00