ensure consistent handling of connection failures

All adapters should now raise Faraday::Error::ConnectionFailed

lib/faraday/adapter/net_http_persistent.rb

@@ -18,6 +18,8 @@ module Faraday
       rescue Net::HTTP::Persistent::Error => error
         if error.message.include? 'Timeout'
           raise Faraday::Error::TimeoutError, error
+        elsif error.message.include? 'connection refused'
+          raise Faraday::Error::ConnectionFailed, error
         else
           raise
         end

lib/faraday/adapter/patron.rb

@@ -31,7 +31,7 @@ module Faraday
         response = begin
           data = env[:body] ? env[:body].to_s : nil
           session.request(env[:method], env[:url].to_s, env[:request_headers], :data => data)
-        rescue Errno::ECONNREFUSED
+        rescue Errno::ECONNREFUSED, ::Patron::ConnectionFailed
           raise Error::ConnectionFailed, $!
         end
 

lib/faraday/adapter/typhoeus.rb

@@ -56,6 +56,15 @@ module Faraday
             end
           end
 
+          case resp.curl_return_code
+          when 0
+            # everything OK
+          when 7
+            raise Error::ConnectionFailed, resp.curl_error_message
+          else
+            raise Error::ClientError, resp.curl_error_message
+          end
+
           save_response(env, resp.code, resp.body) do |response_headers|
             response_headers.parse resp.headers
           end

test/adapters/integration.rb

@@ -166,6 +166,12 @@ module Adapters
         end
       end
 
+      def test_connection_error
+        assert_raises Faraday::Error::ConnectionFailed do
+          get 'http://localhost:4'
+        end
+      end
+
       def test_empty_body_response_represented_as_blank_string
         response = get('204')
         assert_equal '', response.body

test/adapters/rack_test.rb

@@ -22,5 +22,8 @@ module Adapters
       rescue Faraday::Error::ClientError
       end
     end
+
+    # test not applicable
+    undef test_connection_error
   end
 end