From 89b1fe3da978c59436d72e9e1e7cc14b69f11b97 Mon Sep 17 00:00:00 2001 From: Matt Date: Thu, 11 Aug 2022 13:48:13 +0100 Subject: [PATCH] Explicitly pass `reason_phrase` to `save_response` in test adapter. (#1445) Fixes #1444 --- lib/faraday/adapter/test.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/faraday/adapter/test.rb b/lib/faraday/adapter/test.rb index 55adfd63..b8a5b28a 100644 --- a/lib/faraday/adapter/test.rb +++ b/lib/faraday/adapter/test.rb @@ -283,7 +283,11 @@ module Faraday else stub.block.call(env, meta) end - save_response(env, status, body, headers) + + # We need to explicitly pass `reason_phrase = nil` here to avoid keyword args conflicts. + # See https://github.com/lostisland/faraday/issues/1444 + # TODO: remove `nil` explicit reason_phrase once Ruby 3.0 becomes minimum req. version + save_response(env, status, body, headers, nil) @app.call(env) end