sharpetronics/faraday
1
0
Fork 0
mirror of https://github.com/lostisland/faraday.git synced 2025-08-30 00:03:09 -04:00
Code Issues Projects Releases Wiki Activity

Strip out extra new lines from basic auth headers

Browse Source
This commit is contained in:
Carl Lerche 2010-11-13 03:41:04 +08:00 committed by José Valim
parent 53d4244e97
commit 7ff6f56701
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/faraday/connection.rb
View File

@ -81,7 +81,9 @@ module Faraday
end
def basic_auth(login, pass)
@headers['authorization'] = "Basic #{Base64.encode64("#{login}:#{pass}").strip}"
auth = Base64.encode64("#{login}:#{pass}")
auth.gsub!("\n", "")
@headers['authorization'] = "Basic #{auth}"
end
def token_auth(token, options = {})

6
test/connection_test.rb
View File

@ -58,6 +58,12 @@ class TestConnection < Faraday::TestCase
assert_equal 'Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==', conn.headers['Authorization']
end
def test_long_basic_auth_sets_authorization_header_without_new_lines
conn = Faraday::Connection.new
conn.basic_auth "A" * 255, ""
assert_equal "Basic #{'QUFB' * 85}Og==", conn.headers['Authorization']
end
def test_auto_parses_basic_auth_from_url
conn = Faraday::Connection.new :url => "http://aladdin:opensesame@sushi.com/fish"
assert_equal 'Basic YWxhZGRpbjpvcGVuc2VzYW1l', conn.headers['Authorization']